Remove CapabilityControl from CurrentUser

Browse Source

Drop the capabilities reference from all user objects.  Most global
capabilities can be checked with the PermissionBackend.

QoS, query limits, and emailing reviewers still require the capability
object.  Bundle its factory into the call sites that need it.

Continue caching the CapabilityControl in an opaque property on the
CurrentUser, and also in the DefaultPermissionBackend.WithUserImpl.
Both of these sites reduce evaluations for critical properties like
"administrateServer".

Change-Id: I5aae8200e0a579ac1295a3fb7005703fd39d2696

...

This commit is contained in:

Shawn Pearce

2017-04-29 14:23:56 -07:00

committed by David Pursehouse

parent f4001aa356

commit 6302ccb2bb

33 changed files with 222 additions and 217 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

2

plugins/replication

Submodule plugins/replication updated: 2a4d0bfe10...1085b45303