Remove kind attribute from REST containers

It seems like new REST endpoints don't include "kind" attribute. This
change removes it from the code and documentation.

Change-Id: Ia73fb92ce01461e7de140b138fc72583b00170bc
This commit is contained in:
David Ostrovsky 2014-05-29 22:23:41 +02:00 committed by David Ostrovsky
parent 7af3ec348e
commit 631c963931
20 changed files with 0 additions and 111 deletions

View File

@ -753,7 +753,6 @@ entries is returned.
)]}' )]}'
[ [
{ {
"kind": "gerritcodereview#group",
"id": "global%3AAnonymous-Users", "id": "global%3AAnonymous-Users",
"url": "#/admin/groups/uuid-global%3AAnonymous-Users", "url": "#/admin/groups/uuid-global%3AAnonymous-Users",
"options": { "options": {
@ -763,7 +762,6 @@ entries is returned.
"owner_id": "6a1e70e1a88782771a91808c8af9bbb7a9871389" "owner_id": "6a1e70e1a88782771a91808c8af9bbb7a9871389"
}, },
{ {
"kind": "gerritcodereview#group",
"id": "834ec36dd5e0ed21a2ff5d7e2255da082d63bbd7", "id": "834ec36dd5e0ed21a2ff5d7e2255da082d63bbd7",
"url": "#/admin/groups/uuid-834ec36dd5e0ed21a2ff5d7e2255da082d63bbd7", "url": "#/admin/groups/uuid-834ec36dd5e0ed21a2ff5d7e2255da082d63bbd7",
"options": { "options": {
@ -773,7 +771,6 @@ entries is returned.
"owner_id": "834ec36dd5e0ed21a2ff5d7e2255da082d63bbd7" "owner_id": "834ec36dd5e0ed21a2ff5d7e2255da082d63bbd7"
}, },
{ {
"kind": "gerritcodereview#group",
"id": "global%3ARegistered-Users", "id": "global%3ARegistered-Users",
"url": "#/admin/groups/uuid-global%3ARegistered-Users", "url": "#/admin/groups/uuid-global%3ARegistered-Users",
"options": { "options": {
@ -948,7 +945,6 @@ link:rest-api-changes.html#change-info[ChangeInfo] entities.
)]}' )]}'
[ [
{ {
"kind": "gerritcodereview#change",
"id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940", "id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940",
"project": "myProject", "project": "myProject",
"branch": "master", "branch": "master",

View File

@ -43,7 +43,6 @@ the resulting change.
)]}' )]}'
{ {
"kind": "gerritcodereview#change",
"id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9941", "id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9941",
"project": "myProject", "project": "myProject",
"branch": "master", "branch": "master",
@ -94,7 +93,6 @@ Query for open changes of watched projects:
)]}' )]}'
[ [
{ {
"kind": "gerritcodereview#change",
"id": "demo~master~Idaf5e098d70898b7119f6f4af5a6c13343d64b57", "id": "demo~master~Idaf5e098d70898b7119f6f4af5a6c13343d64b57",
"project": "demo", "project": "demo",
"branch": "master", "branch": "master",
@ -113,7 +111,6 @@ Query for open changes of watched projects:
}, },
}, },
{ {
"kind": "gerritcodereview#change",
"id": "demo~master~I09c8041b5867d5b33170316e2abc34b79bbb8501", "id": "demo~master~I09c8041b5867d5b33170316e2abc34b79bbb8501",
"project": "demo", "project": "demo",
"branch": "master", "branch": "master",
@ -169,7 +166,6 @@ Query that retrieves changes for a user's dashboard:
[ [
[ [
{ {
"kind": "gerritcodereview#change",
"id": "demo~master~Idaf5e098d70898b7119f6f4af5a6c13343d64b57", "id": "demo~master~Idaf5e098d70898b7119f6f4af5a6c13343d64b57",
"project": "demo", "project": "demo",
"branch": "master", "branch": "master",
@ -318,7 +314,6 @@ default. Optional fields are:
)]}' )]}'
[ [
{ {
"kind": "gerritcodereview#change",
"id": "demo~master~I7ea46d2e2ee5c64c0d807677859cfb7d90b8966a", "id": "demo~master~I7ea46d2e2ee5c64c0d807677859cfb7d90b8966a",
"project": "gerrit", "project": "gerrit",
"branch": "master", "branch": "master",
@ -455,7 +450,6 @@ describes the change.
)]}' )]}'
{ {
"kind": "gerritcodereview#change",
"id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940", "id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940",
"project": "myProject", "project": "myProject",
"branch": "master", "branch": "master",
@ -506,7 +500,6 @@ describes the change.
)]}' )]}'
{ {
"kind": "gerritcodereview#change",
"id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940", "id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940",
"project": "myProject", "project": "myProject",
"branch": "master", "branch": "master",
@ -757,7 +750,6 @@ describes the abandoned change.
)]}' )]}'
{ {
"kind": "gerritcodereview#change",
"id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940", "id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940",
"project": "myProject", "project": "myProject",
"branch": "master", "branch": "master",
@ -817,7 +809,6 @@ describes the restored change.
)]}' )]}'
{ {
"kind": "gerritcodereview#change",
"id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940", "id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940",
"project": "myProject", "project": "myProject",
"branch": "master", "branch": "master",
@ -875,7 +866,6 @@ is included.
)]}' )]}'
{ {
"kind": "gerritcodereview#change",
"id": "myProject~master~I3ea943139cb62e86071996f2480e58bf3eeb9dd2", "id": "myProject~master~I3ea943139cb62e86071996f2480e58bf3eeb9dd2",
"project": "myProject", "project": "myProject",
"branch": "master", "branch": "master",
@ -968,7 +958,6 @@ describes the reverting change.
)]}' )]}'
{ {
"kind": "gerritcodereview#change",
"id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940", "id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940",
"project": "myProject", "project": "myProject",
"branch": "master", "branch": "master",
@ -1034,7 +1023,6 @@ describes the submitted/merged change.
)]}' )]}'
{ {
"kind": "gerritcodereview#change",
"id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940", "id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940",
"project": "myProject", "project": "myProject",
"branch": "master", "branch": "master",
@ -1124,7 +1112,6 @@ an link:#included-in-info[IncludedInInfo] entity is returned.
)]}' )]}'
{ {
"kind": "gerritcodereview#includedininfo",
"branches": [ "branches": [
"master" "master"
], ],
@ -1159,7 +1146,6 @@ As result a list of link:#reviewer-info[ReviewerInfo] entries is returned.
)]}' )]}'
[ [
{ {
"kind": "gerritcodereview#reviewer",
"approvals": { "approvals": {
"Verified": "+1", "Verified": "+1",
"Code-Review": "+2" "Code-Review": "+2"
@ -1169,7 +1155,6 @@ As result a list of link:#reviewer-info[ReviewerInfo] entries is returned.
"email": "john.doe@example.com" "email": "john.doe@example.com"
}, },
{ {
"kind": "gerritcodereview#reviewer",
"approvals": { "approvals": {
"Verified": " 0", "Verified": " 0",
"Code-Review": "-1" "Code-Review": "-1"
@ -1206,7 +1191,6 @@ As result a list of link:#suggested-reviewer-info[SuggestedReviewerInfo] entries
)]}' )]}'
[ [
{ {
"kind": "gerritcodereview#suggestedreviewer",
"account": { "account": {
"_account_id": 1000097, "_account_id": 1000097,
"name": "Jane Roe", "name": "Jane Roe",
@ -1214,7 +1198,6 @@ As result a list of link:#suggested-reviewer-info[SuggestedReviewerInfo] entries
} }
}, },
{ {
"kind": "gerritcodereview#suggestedreviewer",
"group": { "group": {
"id": "4fd581c0657268f2bdcc26699fbf9ddb76e3a279", "id": "4fd581c0657268f2bdcc26699fbf9ddb76e3a279",
"name": "Joiner" "name": "Joiner"
@ -1247,7 +1230,6 @@ describes the reviewer.
)]}' )]}'
{ {
"kind": "gerritcodereview#reviewer",
"approvals": { "approvals": {
"Verified": "+1", "Verified": "+1",
"Code-Review": "+2" "Code-Review": "+2"
@ -1292,7 +1274,6 @@ returned that describes the newly added reviewers.
{ {
"reviewers": [ "reviewers": [
{ {
"kind": "gerritcodereview#reviewer",
"approvals": { "approvals": {
"Verified": " 0", "Verified": " 0",
"Code-Review": " 0" "Code-Review": " 0"
@ -1394,7 +1375,6 @@ describes the revision.
)]}' )]}'
{ {
"kind": "gerritcodereview#commit",
"parents": [ "parents": [
{ {
"commit": "1eee2c9d8f352483781e772f35dc586a69ff5646", "commit": "1eee2c9d8f352483781e772f35dc586a69ff5646",
@ -1449,7 +1429,6 @@ for the current patch set.
)]}' )]}'
{ {
"kind": "gerritcodereview#change",
"id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940", "id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940",
"project": "myProject", "project": "myProject",
"branch": "master", "branch": "master",
@ -1632,7 +1611,6 @@ is included.
)]}' )]}'
{ {
"kind": "gerritcodereview#change",
"id": "myProject~master~I3ea943139cb62e86071996f2480e58bf3eeb9dd2", "id": "myProject~master~I3ea943139cb62e86071996f2480e58bf3eeb9dd2",
"project": "myProject", "project": "myProject",
"branch": "master", "branch": "master",
@ -2002,14 +1980,12 @@ sorted by file path.
{ {
"gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java": [ "gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java": [
{ {
"kind": "gerritcodereview#comment",
"id": "TvcXrmjM", "id": "TvcXrmjM",
"line": 23, "line": 23,
"message": "[nit] trailing whitespace", "message": "[nit] trailing whitespace",
"updated": "2013-02-26 15:40:43.986000000" "updated": "2013-02-26 15:40:43.986000000"
}, },
{ {
"kind": "gerritcodereview#comment",
"id": "TveXwFiA", "id": "TveXwFiA",
"line": 49, "line": 49,
"in_reply_to": "TfYX-Iuo", "in_reply_to": "TfYX-Iuo",
@ -2054,7 +2030,6 @@ describes the draft comment.
)]}' )]}'
{ {
"kind": "gerritcodereview#comment",
"id": "TvcXrmjM", "id": "TvcXrmjM",
"path": "gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java", "path": "gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java",
"line": 23, "line": 23,
@ -2088,7 +2063,6 @@ describes the draft comment.
)]}' )]}'
{ {
"kind": "gerritcodereview#comment",
"id": "TvcXrmjM", "id": "TvcXrmjM",
"path": "gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java", "path": "gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java",
"line": 23, "line": 23,
@ -2131,7 +2105,6 @@ describes the draft comment.
)]}' )]}'
{ {
"kind": "gerritcodereview#comment",
"id": "TvcXrmjM", "id": "TvcXrmjM",
"path": "gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java", "path": "gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java",
"line": 23, "line": 23,
@ -2185,7 +2158,6 @@ sorted by file path.
{ {
"gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java": [ "gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java": [
{ {
"kind": "gerritcodereview#comment",
"id": "TvcXrmjM", "id": "TvcXrmjM",
"line": 23, "line": 23,
"message": "[nit] trailing whitespace", "message": "[nit] trailing whitespace",
@ -2197,7 +2169,6 @@ sorted by file path.
} }
}, },
{ {
"kind": "gerritcodereview#comment",
"id": "TveXwFiA", "id": "TveXwFiA",
"line": 49, "line": 49,
"in_reply_to": "TfYX-Iuo", "in_reply_to": "TfYX-Iuo",
@ -2237,7 +2208,6 @@ describes the published comment.
)]}' )]}'
{ {
"kind": "gerritcodereview#comment",
"id": "TvcXrmjM", "id": "TvcXrmjM",
"path": "gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java", "path": "gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java",
"line": 23, "line": 23,
@ -2577,7 +2547,6 @@ describes the resulting cherry picked change.
)]}' )]}'
{ {
"kind": "gerritcodereview#change",
"id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9941", "id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9941",
"project": "myProject", "project": "myProject",
"branch": "release-branch", "branch": "release-branch",
@ -2629,7 +2598,6 @@ describes the change.
)]}' )]}'
{ {
"kind": "gerritcodereview#change",
"id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9941", "id": "myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9941",
"project": "myProject", "project": "myProject",
"branch": "release-branch", "branch": "release-branch",
@ -2793,7 +2761,6 @@ The `ChangeInfo` entity contains information about a change.
[options="header",width="50%",cols="1,^1,5"] [options="header",width="50%",cols="1,^1,5"]
|================================== |==================================
|Field Name ||Description |Field Name ||Description
|`kind` ||`gerritcodereview#change`
|`id` || |`id` ||
The ID of the change in the format "'<project>\~<branch>~<Change-Id>'", The ID of the change in the format "'<project>\~<branch>~<Change-Id>'",
where 'project', 'branch' and 'Change-Id' are URL encoded. For 'branch' the where 'project', 'branch' and 'Change-Id' are URL encoded. For 'branch' the
@ -2906,7 +2873,6 @@ The `CommentInfo` entity contains information about an inline comment.
[options="header",width="50%",cols="1,^1,5"] [options="header",width="50%",cols="1,^1,5"]
|=========================== |===========================
|Field Name ||Description |Field Name ||Description
|`kind` ||`gerritcodereview#comment`
|`id` ||The URL encoded UUID of the comment. |`id` ||The URL encoded UUID of the comment.
|`path` |optional| |`path` |optional|
The path of the file for which the inline comment was done. + The path of the file for which the inline comment was done. +
@ -2942,8 +2908,6 @@ comment.
[options="header",width="50%",cols="1,^1,5"] [options="header",width="50%",cols="1,^1,5"]
|=========================== |===========================
|Field Name ||Description |Field Name ||Description
|`kind` |optional|
Must be `gerritcodereview#comment` if provided.
|`id` |optional| |`id` |optional|
The URL encoded UUID of the comment if an existing draft comment should The URL encoded UUID of the comment if an existing draft comment should
be updated. be updated.
@ -3302,7 +3266,6 @@ In addition `ReviewerInfo` has the following fields:
[options="header",width="50%",cols="1,6"] [options="header",width="50%",cols="1,6"]
|========================== |==========================
|Field Name |Description |Field Name |Description
|`kind` |`gerritcodereview#reviewer`
|`approvals` | |`approvals` |
The approvals of the reviewer as a map that maps the label names to the The approvals of the reviewer as a map that maps the label names to the
approval values ("`-2`", "`-1`", " `0`", "`+1`", "`+2`"). approval values ("`-2`", "`-1`", " `0`", "`+1`", "`+2`").
@ -3479,7 +3442,6 @@ change was merged into and tags it was tagged with.
[options="header",width="50%",cols="1,6"] [options="header",width="50%",cols="1,6"]
|========================== |==========================
|Field Name |Description |Field Name |Description
|`kind` |`gerritcodereview#includedininfo`
|`branches` | The list of branches this change was merged into. |`branches` | The list of branches this change was merged into.
Each branch is listed without the 'refs/head/' prefix. Each branch is listed without the 'refs/head/' prefix.
|`tags` | The list of tags this change was tagged with. |`tags` | The list of tags this change was tagged with.

View File

@ -312,82 +312,66 @@ The entries in the map are sorted by capability ID.
)]}' )]}'
{ {
"accessDatabase": { "accessDatabase": {
"kind": "gerritcodereview#capability",
"id": "accessDatabase", "id": "accessDatabase",
"name": "Access Database" "name": "Access Database"
}, },
"administrateServer": { "administrateServer": {
"kind": "gerritcodereview#capability",
"id": "administrateServer", "id": "administrateServer",
"name": "Administrate Server" "name": "Administrate Server"
}, },
"createAccount": { "createAccount": {
"kind": "gerritcodereview#capability",
"id": "createAccount", "id": "createAccount",
"name": "Create Account" "name": "Create Account"
}, },
"createGroup": { "createGroup": {
"kind": "gerritcodereview#capability",
"id": "createGroup", "id": "createGroup",
"name": "Create Group" "name": "Create Group"
}, },
"createProject": { "createProject": {
"kind": "gerritcodereview#capability",
"id": "createProject", "id": "createProject",
"name": "Create Project" "name": "Create Project"
}, },
"emailReviewers": { "emailReviewers": {
"kind": "gerritcodereview#capability",
"id": "emailReviewers", "id": "emailReviewers",
"name": "Email Reviewers" "name": "Email Reviewers"
}, },
"flushCaches": { "flushCaches": {
"kind": "gerritcodereview#capability",
"id": "flushCaches", "id": "flushCaches",
"name": "Flush Caches" "name": "Flush Caches"
}, },
"killTask": { "killTask": {
"kind": "gerritcodereview#capability",
"id": "killTask", "id": "killTask",
"name": "Kill Task" "name": "Kill Task"
}, },
"priority": { "priority": {
"kind": "gerritcodereview#capability",
"id": "priority", "id": "priority",
"name": "Priority" "name": "Priority"
}, },
"queryLimit": { "queryLimit": {
"kind": "gerritcodereview#capability",
"id": "queryLimit", "id": "queryLimit",
"name": "Query Limit" "name": "Query Limit"
}, },
"runGC": { "runGC": {
"kind": "gerritcodereview#capability",
"id": "runGC", "id": "runGC",
"name": "Run Garbage Collection" "name": "Run Garbage Collection"
}, },
"streamEvents": { "streamEvents": {
"kind": "gerritcodereview#capability",
"id": "streamEvents", "id": "streamEvents",
"name": "Stream Events" "name": "Stream Events"
}, },
"viewCaches": { "viewCaches": {
"kind": "gerritcodereview#capability",
"id": "viewCaches", "id": "viewCaches",
"name": "View Caches" "name": "View Caches"
}, },
"viewConnections": { "viewConnections": {
"kind": "gerritcodereview#capability",
"id": "viewConnections", "id": "viewConnections",
"name": "View Connections" "name": "View Connections"
}, },
"viewPlugins": { "viewPlugins": {
"kind": "gerritcodereview#capability",
"id": "viewPlugins", "id": "viewPlugins",
"name": "View Plugins" "name": "View Plugins"
}, },
"viewQueue": { "viewQueue": {
"kind": "gerritcodereview#capability",
"id": "viewQueue", "id": "viewQueue",
"name": "View Queue" "name": "View Queue"
} }
@ -480,7 +464,6 @@ The `CapabilityInfo` entity contains information about a capability.
[options="header",width="50%",cols="1,6"] [options="header",width="50%",cols="1,6"]
|================================= |=================================
|Field Name |Description |Field Name |Description
|`kind` |`gerritcodereview#capability`
|`id` |capability ID |`id` |capability ID
|`name` |capability name |`name` |capability name
|================================= |=================================

View File

@ -35,7 +35,6 @@ by group name.
)]}' )]}'
{ {
"Administrators": { "Administrators": {
"kind": "gerritcodereview#group",
"id": "6a1e70e1a88782771a91808c8af9bbb7a9871389", "id": "6a1e70e1a88782771a91808c8af9bbb7a9871389",
"url": "#/admin/groups/uuid-6a1e70e1a88782771a91808c8af9bbb7a9871389", "url": "#/admin/groups/uuid-6a1e70e1a88782771a91808c8af9bbb7a9871389",
"options": { "options": {
@ -46,7 +45,6 @@ by group name.
"owner_id": "6a1e70e1a88782771a91808c8af9bbb7a9871389" "owner_id": "6a1e70e1a88782771a91808c8af9bbb7a9871389"
}, },
"Anonymous Users": { "Anonymous Users": {
"kind": "gerritcodereview#group",
"id": "global%3AAnonymous-Users", "id": "global%3AAnonymous-Users",
"url": "#/admin/groups/uuid-global%3AAnonymous-Users", "url": "#/admin/groups/uuid-global%3AAnonymous-Users",
"options": { "options": {
@ -57,7 +55,6 @@ by group name.
"owner_id": "6a1e70e1a88782771a91808c8af9bbb7a9871389" "owner_id": "6a1e70e1a88782771a91808c8af9bbb7a9871389"
}, },
"MyProject_Committers": { "MyProject_Committers": {
"kind": "gerritcodereview#group",
"id": "834ec36dd5e0ed21a2ff5d7e2255da082d63bbd7", "id": "834ec36dd5e0ed21a2ff5d7e2255da082d63bbd7",
"url": "#/admin/groups/uuid-834ec36dd5e0ed21a2ff5d7e2255da082d63bbd7", "url": "#/admin/groups/uuid-834ec36dd5e0ed21a2ff5d7e2255da082d63bbd7",
"options": { "options": {
@ -68,7 +65,6 @@ by group name.
"owner_id": "834ec36dd5e0ed21a2ff5d7e2255da082d63bbd7" "owner_id": "834ec36dd5e0ed21a2ff5d7e2255da082d63bbd7"
}, },
"Non-Interactive Users": { "Non-Interactive Users": {
"kind": "gerritcodereview#group",
"id": "5057f3cbd3519d6ab69364429a89ffdffba50f73", "id": "5057f3cbd3519d6ab69364429a89ffdffba50f73",
"url": "#/admin/groups/uuid-5057f3cbd3519d6ab69364429a89ffdffba50f73", "url": "#/admin/groups/uuid-5057f3cbd3519d6ab69364429a89ffdffba50f73",
"options": { "options": {
@ -79,7 +75,6 @@ by group name.
"owner_id": "6a1e70e1a88782771a91808c8af9bbb7a9871389" "owner_id": "6a1e70e1a88782771a91808c8af9bbb7a9871389"
}, },
"Project Owners": { "Project Owners": {
"kind": "gerritcodereview#group",
"id": "global%3AProject-Owners", "id": "global%3AProject-Owners",
"url": "#/admin/groups/uuid-global%3AProject-Owners", "url": "#/admin/groups/uuid-global%3AProject-Owners",
"options": { "options": {
@ -90,7 +85,6 @@ by group name.
"owner_id": "6a1e70e1a88782771a91808c8af9bbb7a9871389" "owner_id": "6a1e70e1a88782771a91808c8af9bbb7a9871389"
}, },
"Registered Users": { "Registered Users": {
"kind": "gerritcodereview#group",
"id": "global%3ARegistered-Users", "id": "global%3ARegistered-Users",
"url": "#/admin/groups/uuid-global%3ARegistered-Users", "url": "#/admin/groups/uuid-global%3ARegistered-Users",
"options": { "options": {
@ -147,7 +141,6 @@ returned.
)]}' )]}'
{ {
"MyProject-Committers": { "MyProject-Committers": {
"kind": "gerritcodereview#group",
"id": "9999c971bb4ab872aab759d8c49833ee6b9ff320", "id": "9999c971bb4ab872aab759d8c49833ee6b9ff320",
"url": "#/admin/groups/uuid-9999c971bb4ab872aab759d8c49833ee6b9ff320", "url": "#/admin/groups/uuid-9999c971bb4ab872aab759d8c49833ee6b9ff320",
"options": { "options": {
@ -203,7 +196,6 @@ describes the group.
)]}' )]}'
{ {
"kind": "gerritcodereview#group",
"id": "6a1e70e1a88782771a91808c8af9bbb7a9871389", "id": "6a1e70e1a88782771a91808c8af9bbb7a9871389",
"name": "Administrators", "name": "Administrators",
"url": "#/admin/groups/uuid-6a1e70e1a88782771a91808c8af9bbb7a9871389", "url": "#/admin/groups/uuid-6a1e70e1a88782771a91808c8af9bbb7a9871389",
@ -251,7 +243,6 @@ describes the created group.
)]}' )]}'
{ {
"kind": "gerritcodereview#group",
"id": "9999c971bb4ab872aab759d8c49833ee6b9ff320", "id": "9999c971bb4ab872aab759d8c49833ee6b9ff320",
"name": "MyProject-Committers", "name": "MyProject-Committers",
"url": "#/admin/groups/uuid-9999c971bb4ab872aab759d8c49833ee6b9ff320", "url": "#/admin/groups/uuid-9999c971bb4ab872aab759d8c49833ee6b9ff320",
@ -293,7 +284,6 @@ describes the group.
)]}' )]}'
{ {
"kind": "gerritcodereview#group",
"id": "6a1e70e1a88782771a91808c8af9bbb7a9871389", "id": "6a1e70e1a88782771a91808c8af9bbb7a9871389",
"name": "Administrators", "name": "Administrators",
"url": "#/admin/groups/uuid-6a1e70e1a88782771a91808c8af9bbb7a9871389", "url": "#/admin/groups/uuid-6a1e70e1a88782771a91808c8af9bbb7a9871389",
@ -544,7 +534,6 @@ describes the owner group.
)]}' )]}'
{ {
"kind": "gerritcodereview#group",
"id": "6a1e70e1a88782771a91808c8af9bbb7a9871389", "id": "6a1e70e1a88782771a91808c8af9bbb7a9871389",
"name": "Administrators", "name": "Administrators",
"url": "#/admin/groups/uuid-6a1e70e1a88782771a91808c8af9bbb7a9871389", "url": "#/admin/groups/uuid-6a1e70e1a88782771a91808c8af9bbb7a9871389",
@ -591,7 +580,6 @@ describes the new owner group.
)]}' )]}'
{ {
"kind": "gerritcodereview#group",
"id": "6a1e70e1a88782771a91808c8af9bbb7a9871389", "id": "6a1e70e1a88782771a91808c8af9bbb7a9871389",
"name": "Administrators", "name": "Administrators",
"url": "#/admin/groups/uuid-6a1e70e1a88782771a91808c8af9bbb7a9871389", "url": "#/admin/groups/uuid-6a1e70e1a88782771a91808c8af9bbb7a9871389",
@ -892,7 +880,6 @@ The entries in the list are sorted by group name and UUID.
)]}' )]}'
[ [
{ {
"kind": "gerritcodereview#group",
"id": "7ca042f4d5847936fcb90ca91057673157fd06fc", "id": "7ca042f4d5847936fcb90ca91057673157fd06fc",
"name": "MyProject-Verifiers", "name": "MyProject-Verifiers",
"url": "#/admin/groups/uuid-7ca042f4d5847936fcb90ca91057673157fd06fc", "url": "#/admin/groups/uuid-7ca042f4d5847936fcb90ca91057673157fd06fc",
@ -929,7 +916,6 @@ describes the included group.
)]}' )]}'
{ {
"kind": "gerritcodereview#group",
"id": "7ca042f4d5847936fcb90ca91057673157fd06fc", "id": "7ca042f4d5847936fcb90ca91057673157fd06fc",
"name": "MyProject-Verifiers", "name": "MyProject-Verifiers",
"url": "#/admin/groups/uuid-7ca042f4d5847936fcb90ca91057673157fd06fc", "url": "#/admin/groups/uuid-7ca042f4d5847936fcb90ca91057673157fd06fc",
@ -966,7 +952,6 @@ describes the included group.
)]}' )]}'
{ {
"kind": "gerritcodereview#group",
"id": "6a1e70e1a88782771a91808c8af9bbb7a9871389", "id": "6a1e70e1a88782771a91808c8af9bbb7a9871389",
"name": "MyGroup", "name": "MyGroup",
"url": "#/admin/groups/uuid-6a1e70e1a88782771a91808c8af9bbb7a9871389", "url": "#/admin/groups/uuid-6a1e70e1a88782771a91808c8af9bbb7a9871389",
@ -1027,7 +1012,6 @@ group was already included in the group.
)]}' )]}'
[ [
{ {
"kind": "gerritcodereview#group",
"id": "6a1e70e1a88782771a91808c8af9bbb7a9871389", "id": "6a1e70e1a88782771a91808c8af9bbb7a9871389",
"name": "MyGroup", "name": "MyGroup",
"url": "#/admin/groups/uuid-6a1e70e1a88782771a91808c8af9bbb7a9871389", "url": "#/admin/groups/uuid-6a1e70e1a88782771a91808c8af9bbb7a9871389",
@ -1038,7 +1022,6 @@ group was already included in the group.
"owner_id": "6a1e70e1a88782771a91808c8af9bbb7a9871389" "owner_id": "6a1e70e1a88782771a91808c8af9bbb7a9871389"
}, },
{ {
"kind": "gerritcodereview#group",
"id": "5057f3cbd3519d6ab69364429a89ffdffba50f73", "id": "5057f3cbd3519d6ab69364429a89ffdffba50f73",
"name": "MyOtherGroup", "name": "MyOtherGroup",
"url": "#/admin/groups/uuid-5057f3cbd3519d6ab69364429a89ffdffba50f73", "url": "#/admin/groups/uuid-5057f3cbd3519d6ab69364429a89ffdffba50f73",
@ -1133,7 +1116,6 @@ a Gerrit internal group, or an external group that is known to Gerrit.
[options="header",width="50%",cols="1,^1,5"] [options="header",width="50%",cols="1,^1,5"]
|=========================== |===========================
|Field Name ||Description |Field Name ||Description
|`kind` ||`gerritcodereview#group`
|`id` ||The URL encoded UUID of the group. |`id` ||The URL encoded UUID of the group.
|`name` | |`name` |
not set if returned in a map where the group name is used as map key| not set if returned in a map where the group name is used as map key|

View File

@ -45,13 +45,11 @@ by plugin ID.
)]}' )]}'
{ {
"delete-project": { "delete-project": {
"kind": "gerritcodereview#plugin",
"id": "delete-project", "id": "delete-project",
"index_url": "plugins/delete-project/", "index_url": "plugins/delete-project/",
"version": "2.9-SNAPSHOT" "version": "2.9-SNAPSHOT"
}, },
"reviewers-by-blame": { "reviewers-by-blame": {
"kind": "gerritcodereview#plugin",
"id": "reviewers-by-blame", "id": "reviewers-by-blame",
"index_url": "plugins/reviewers-by-blame/", "index_url": "plugins/reviewers-by-blame/",
"version": "2.9-SNAPSHOT", "version": "2.9-SNAPSHOT",
@ -103,7 +101,6 @@ describes the plugin.
)]}' )]}'
{ {
"kind": "gerritcodereview#plugin",
"id": "delete-project", "id": "delete-project",
"version": "2.8" "version": "2.8"
} }
@ -135,7 +132,6 @@ describes the plugin.
)]}' )]}'
{ {
"kind": "gerritcodereview#plugin",
"id": "delete-project", "id": "delete-project",
"version": "2.8" "version": "2.8"
} }
@ -165,7 +161,6 @@ describes the plugin.
)]}' )]}'
{ {
"kind": "gerritcodereview#plugin",
"id": "delete-project", "id": "delete-project",
"version": "2.8" "version": "2.8"
} }
@ -201,7 +196,6 @@ describes the plugin.
)]}' )]}'
{ {
"kind": "gerritcodereview#plugin",
"id": "delete-project", "id": "delete-project",
"version": "2.8", "version": "2.8",
"disabled": true "disabled": true
@ -232,7 +226,6 @@ describes the plugin.
)]}' )]}'
{ {
"kind": "gerritcodereview#plugin",
"id": "delete-project", "id": "delete-project",
"version": "2.8", "version": "2.8",
"disabled": true "disabled": true
@ -257,7 +250,6 @@ The `PluginInfo` entity describes a plugin.
[options="header",width="50%",cols="1,^2,4"] [options="header",width="50%",cols="1,^2,4"]
|======================= |=======================
|Field Name ||Description |Field Name ||Description
|`kind` ||`gerritcodereview#plugin`
|`id` ||The ID of the plugin. |`id` ||The ID of the plugin.
|`version` ||The version of the plugin. |`version` ||The version of the plugin.
|`index_url`|optional|URL of the plugin's default page. |`index_url`|optional|URL of the plugin's default page.

View File

@ -439,7 +439,6 @@ read access to `refs/meta/config`.
)]}' )]}'
{ {
"kind": "gerritcodereview#project_config",
"description": "demo project", "description": "demo project",
"use_contributor_agreements": { "use_contributor_agreements": {
"value": true, "value": true,
@ -528,7 +527,6 @@ ConfigInfo] entity.
)]}' )]}'
{ {
"kind": "gerritcodereview#project_config",
"use_contributor_agreements": { "use_contributor_agreements": {
"value": false, "value": false,
"configured_value": "FALSE", "configured_value": "FALSE",
@ -925,7 +923,6 @@ List all dashboards for the `work/my-project` project:
)]}' )]}'
[ [
{ {
"kind": "gerritcodereview#dashboard",
"id": "main:closed", "id": "main:closed",
"ref": "main", "ref": "main",
"path": "closed", "path": "closed",
@ -977,7 +974,6 @@ that describes the dashboard.
)]}' )]}'
{ {
"kind": "gerritcodereview#dashboard",
"id": "main:closed", "id": "main:closed",
"ref": "main", "ref": "main",
"path": "closed", "path": "closed",
@ -1014,7 +1010,6 @@ dashboard-id.
)]}' )]}'
{ {
"kind": "gerritcodereview#dashboard",
"id": "main:closed", "id": "main:closed",
"ref": "main", "ref": "main",
"path": "closed", "path": "closed",
@ -1070,7 +1065,6 @@ link:#dashboard-info[DashboardInfo] entity.
)]}' )]}'
{ {
"kind": "gerritcodereview#dashboard",
"id": "main:closed", "id": "main:closed",
"ref": "main", "ref": "main",
"path": "closed", "path": "closed",
@ -1331,7 +1325,6 @@ dashboard.
[options="header",width="50%",cols="1,^2,4"] [options="header",width="50%",cols="1,^2,4"]
|=============================== |===============================
|Field Name ||Description |Field Name ||Description
|`kind` ||`gerritcodereview#dashboard`
|`id` || |`id` ||
The ID of the dashboard. The ID has the format '<ref>:<path>', The ID of the dashboard. The ID has the format '<ref>:<path>',
where ref and path are URL encoded. where ref and path are URL encoded.

View File

@ -61,7 +61,6 @@ public class ReviewInput extends JavaScriptObject {
var l=m[p]; var l=m[p];
for (var i=0;i<l.length;i++) { for (var i=0;i<l.length;i++) {
var c=l[i]; var c=l[i];
delete c['kind'];
delete c['path']; delete c['path'];
delete c['updated']; delete c['updated'];
} }

View File

@ -99,8 +99,6 @@ public class GetPreferences implements RestReadView<AccountResource> {
} }
public static class PreferenceInfo { public static class PreferenceInfo {
final String kind = "gerritcodereview#preferences";
Short changesPerPage; Short changesPerPage;
Boolean showSiteHeader; Boolean showSiteHeader;
Boolean useFlashClipboard; Boolean useFlashClipboard;

View File

@ -919,7 +919,6 @@ public class ChangeJson {
} }
public static class ChangeInfo { public static class ChangeInfo {
public final String kind = "gerritcodereview#change";
public String id; public String id;
public String project; public String project;
public String branch; public String branch;

View File

@ -24,8 +24,6 @@ import com.google.gerrit.server.account.AccountInfo;
import java.sql.Timestamp; import java.sql.Timestamp;
public class CommentInfo { public class CommentInfo {
final String kind = "gerritcodereview#comment";
String id; String id;
String path; String path;
Side side; Side side;

View File

@ -79,7 +79,6 @@ class IncludedIn implements RestReadView<ChangeResource> {
} }
static class IncludedInInfo { static class IncludedInInfo {
String kind = "gerritcodereview#includedininfo";
Collection<String> branches; Collection<String> branches;
Collection<String> tags; Collection<String> tags;

View File

@ -37,7 +37,6 @@ import java.util.Collections;
@Singleton @Singleton
class PutDraft implements RestModifyView<DraftResource, Input> { class PutDraft implements RestModifyView<DraftResource, Input> {
static class Input { static class Input {
String kind;
String id; String id;
String path; String path;
Side side; Side side;
@ -65,8 +64,6 @@ class PutDraft implements RestModifyView<DraftResource, Input> {
PatchLineComment c = rsrc.getComment(); PatchLineComment c = rsrc.getComment();
if (in == null || in.message == null || in.message.trim().isEmpty()) { if (in == null || in.message == null || in.message.trim().isEmpty()) {
return delete.get().apply(rsrc, null); return delete.get().apply(rsrc, null);
} else if (in.kind != null && !"gerritcodereview#comment".equals(in.kind)) {
throw new BadRequestException("expected kind gerritcodereview#comment");
} else if (in.id != null && !rsrc.getId().equals(in.id)) { } else if (in.id != null && !rsrc.getId().equals(in.id)) {
throw new BadRequestException("id must match URL"); throw new BadRequestException("id must match URL");
} else if (in.line != null && in.line < 0) { } else if (in.line != null && in.line < 0) {

View File

@ -132,7 +132,6 @@ public class ReviewerJson {
} }
public static class ReviewerInfo extends AccountInfo { public static class ReviewerInfo extends AccountInfo {
final String kind = "gerritcodereview#reviewer";
Map<String, String> approvals; Map<String, String> approvals;
protected ReviewerInfo(Account.Id id) { protected ReviewerInfo(Account.Id id) {

View File

@ -269,7 +269,6 @@ public class SuggestReviewers implements RestReadView<ChangeResource> {
} }
public static class SuggestedReviewerInfo implements Comparable<SuggestedReviewerInfo> { public static class SuggestedReviewerInfo implements Comparable<SuggestedReviewerInfo> {
String kind = "gerritcodereview#suggestedreviewer";
public AccountInfo account; public AccountInfo account;
public GroupBaseInfo group; public GroupBaseInfo group;

View File

@ -86,7 +86,6 @@ public class ListCapabilities implements RestReadView<ConfigResource> {
} }
public static class CapabilityInfo { public static class CapabilityInfo {
final String kind = "gerritcodereview#capability";
public String id; public String id;
public String name; public String name;

View File

@ -127,7 +127,6 @@ public class GroupJson {
} }
public static class GroupInfo extends GroupBaseInfo { public static class GroupInfo extends GroupBaseInfo {
final String kind = "gerritcodereview#group";
public String url; public String url;
public GroupOptionsInfo options; public GroupOptionsInfo options;

View File

@ -127,7 +127,6 @@ public class ListPlugins implements RestReadView<TopLevelResource> {
} }
static class PluginInfo { static class PluginInfo {
final String kind = "gerritcodereview#plugin";
String id; String id;
String version; String version;
String indexUrl; String indexUrl;

View File

@ -39,8 +39,6 @@ import java.util.Map;
import java.util.TreeMap; import java.util.TreeMap;
public class ConfigInfo { public class ConfigInfo {
public final String kind = "gerritcodereview#project_config";
public String description; public String description;
public InheritedBooleanInfo useContributorAgreements; public InheritedBooleanInfo useContributorAgreements;
public InheritedBooleanInfo useContentMerge; public InheritedBooleanInfo useContentMerge;

View File

@ -205,7 +205,6 @@ class DashboardsCollection implements
} }
static class DashboardInfo { static class DashboardInfo {
final String kind = "gerritcodereview#dashboard";
String id; String id;
String project; String project;
String definingProject; String definingProject;

View File

@ -205,7 +205,6 @@ public class CommentsTest {
private static void assertComment(PatchLineComment plc, CommentInfo ci) { private static void assertComment(PatchLineComment plc, CommentInfo ci) {
assertEquals(plc.getKey().get(), ci.id); assertEquals(plc.getKey().get(), ci.id);
assertEquals(plc.getParentUuid(), ci.inReplyTo); assertEquals(plc.getParentUuid(), ci.inReplyTo);
assertEquals("gerritcodereview#comment", ci.kind);
assertEquals(plc.getMessage(), ci.message); assertEquals(plc.getMessage(), ci.message);
assertNotNull(ci.author); assertNotNull(ci.author);
assertEquals(plc.getAuthor(), ci.author._id); assertEquals(plc.getAuthor(), ci.author._id);