opendev/gerrit
Code Issues Proposed changes

SideBySide2: Simplify logic for showing/hiding header

Browse Source 
The file header and Gerrit menus should show/hide together.
Consolidate the logic for this into one place and simplify the
conditional value to be consistent between them:

  true means show headers,
  false means hide headers.

Change-Id: Iae59a40369ef698279eee2c1faa2b147fbb622c8
This commit is contained in:
Shawn Pearce
2013-11-21 01:33:15 -08:00
parent 6df77ca646
commit 63543e9188
3 changed files with 12 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/ScrollSynchronizer.java
View File

@@ -39,12 +39,10 @@ class ScrollSynchronizer {
private void updateScreenHeader(ScrollInfo si) {
if (si.getTop() == 0 && !Gerrit.isHeaderVisible()) {
Gerrit.setHeaderVisible(true);
diffTable.updateFileCommentVisibility(false);
diffTable.setHeaderVisible(true);
} else if (si.getTop() > 0.5 * si.getClientHeight()
&& Gerrit.isHeaderVisible()) {
Gerrit.setHeaderVisible(false);
diffTable.updateFileCommentVisibility(true);
diffTable.setHeaderVisible(false);
}
}