opendev/gerrit
Code Issues Proposed changes

ElasticRestClientProvider: Make client field volatile

Browse Source 
ErrorProne reports a warning [1] that double-checked locking on
non-volatile fields is unsafe.

[1] http://errorprone.info/bugpattern/DoubleCheckedLocking

Change-Id: I4277a4910bd93fab9f072323a69bbf19472eb590
This commit is contained in:
David Pursehouse 2018-08-28 17:31:37 +09:00
parent 7b7c4d318a
commit 63899d219e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-elasticsearch/src/main/java/com/google/gerrit/elasticsearch/ElasticRestClientProvider.java
View File

@ -40,7 +40,7 @@ class ElasticRestClientProvider implements Provider<RestClient>, LifecycleListen
private final ElasticConfiguration cfg; private final ElasticConfiguration cfg;
private RestClient client; private volatile RestClient client;
private ElasticQueryAdapter adapter; private ElasticQueryAdapter adapter;
@Inject @Inject