opendev/gerrit
Code Issues Proposed changes

Remove UpdateUI#pruneSchema method

Browse Source 
Change-Id: Ibb5d3e74463bd72279bff6f0b104e97f1cc80194
This commit is contained in:
Dave Borowitz
2018-12-17 14:59:24 -08:00
parent b397acf45e
commit 63c60a4831
3 changed files with 0 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
java/com/google/gerrit/pgm/init/BaseInit.java
View File

@@ -45,7 +45,6 @@ import com.google.gerrit.server.securestore.SecureStore;
import com.google.gerrit.server.securestore.SecureStoreClassName;
import com.google.gerrit.server.securestore.SecureStoreProvider;
import com.google.gwtorm.server.OrmException;
import com.google.gwtorm.server.StatementExecutor;
import com.google.inject.AbstractModule;
import com.google.inject.CreationException;
import com.google.inject.Guice;
@@ -388,12 +387,6 @@ public class BaseInit extends SiteProgram {
public boolean isBatch() {
return consoleUi.isBatch();
}
@Override
public void pruneSchema(StatementExecutor e, List<String> prune) {
// Do nothing in NoteDb.
// TODO(dborowitz): Remove this method in the base class.
}
}
}

5
java/com/google/gerrit/server/schema/UpdateUI.java
View File

@@ -14,9 +14,6 @@
package com.google.gerrit.server.schema;
import com.google.gwtorm.server.OrmException;
import com.google.gwtorm.server.StatementExecutor;
import java.util.List;
import java.util.Set;
public interface UpdateUI {
@@ -37,6 +34,4 @@ public interface UpdateUI {
String readString(String defaultValue, Set<String> allowedValues, String message);
boolean isBatch();
void pruneSchema(StatementExecutor e, List<String> pruneList) throws OrmException;
}

10
java/com/google/gerrit/testing/TestUpdateUI.java
View File

@@ -15,9 +15,6 @@
package com.google.gerrit.testing;
import com.google.gerrit.server.schema.UpdateUI;
import com.google.gwtorm.server.OrmException;
import com.google.gwtorm.server.StatementExecutor;
import java.util.List;
import java.util.Set;
public class TestUpdateUI implements UpdateUI {
@@ -41,11 +38,4 @@ public class TestUpdateUI implements UpdateUI {
public boolean isBatch() {
return true;
}
@Override
public void pruneSchema(StatementExecutor e, List<String> pruneList) throws OrmException {
for (String sql : pruneList) {
e.execute(sql);
}
}
}