opendev/gerrit
Code Issues Proposed changes

Rewrite on-tap to on-click

Browse Source 
Polymer recommends to prefer click events over Polymer tap events.
Performance on initializing on-click is much better than on-tap.

https://polymer-library.polymer-project.org/2.0/docs/devguide/gesture-events

Change-Id: I0aec1ddcc9ad74f7880e7fd7ca0689b5c8c84796
This commit is contained in:
Milutin Kristofic
2019-09-27 15:41:53 +02:00
parent bfa2a6e897
commit 63cf95d19d
52 changed files with 128 additions and 127 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.html
View File

@@ -217,28 +217,28 @@ limitations under the License.
<span class$="[[_computeUploadHelpContainerClass(change, account)]]">
<gr-button link
class="upload"
on-tap="_handleUploadTap">Update Change</gr-button>
on-click="_handleUploadTap">Update Change</gr-button>
</span>
<span class="downloadContainer desktop">
<gr-button link
class="download"
on-tap="_handleDownloadTap">Download</gr-button>
on-click="_handleDownloadTap">Download</gr-button>
</span>
<span class$="includedInContainer [[_hideIncludedIn(change)]] desktop">
<gr-button link
class="includedIn"
on-tap="_handleIncludedInTap">Included In</gr-button>
on-click="_handleIncludedInTap">Included In</gr-button>
</span>
<template is="dom-if"
if="[[_fileListActionsVisible(shownFileCount, _maxFilesForBulkActions)]]">
<gr-button
id="expandBtn"
link
on-tap="_expandAllDiffs">Expand All</gr-button>
on-click="_expandAllDiffs">Expand All</gr-button>
<gr-button
id="collapseBtn"
link
on-tap="_collapseAllDiffs">Collapse All</gr-button>
on-click="_collapseAllDiffs">Collapse All</gr-button>
</template>
<template is="dom-if"
if="[[!_fileListActionsVisible(shownFileCount, _maxFilesForBulkActions)]]">
@@ -262,7 +262,7 @@ limitations under the License.
has-tooltip
title="Diff preferences"
class="prefsButton desktop"
on-tap="_handlePrefsTap"><iron-icon icon="gr-icons:settings"></iron-icon></gr-button>
on-click="_handlePrefsTap"><iron-icon icon="gr-icons:settings"></iron-icon></gr-button>
</span>
</div>
</div>