CreateChange: move code for creating commit message to a method
Change-Id: I3d55aa5efb5cfdc923e16f80680547b495e53c22
This commit is contained in:
@@ -191,25 +191,7 @@ public class CreateChange
|
|||||||
|
|
||||||
Timestamp now = TimeUtil.nowTs();
|
Timestamp now = TimeUtil.nowTs();
|
||||||
PersonIdent author = me.newCommitterIdent(now, serverTimeZone);
|
PersonIdent author = me.newCommitterIdent(now, serverTimeZone);
|
||||||
|
String commitMessage = getCommitMessage(input.subject, me, oi, mergeTip, author);
|
||||||
// Add a Change-Id line if there isn't already one
|
|
||||||
String commitMessage = input.subject;
|
|
||||||
if (ChangeIdUtil.indexOfChangeId(commitMessage, "\n") == -1) {
|
|
||||||
ObjectId treeId = mergeTip == null ? emptyTreeId(oi) : mergeTip.getTree();
|
|
||||||
ObjectId id = ChangeIdUtil.computeChangeId(treeId, mergeTip, author, author, commitMessage);
|
|
||||||
commitMessage = ChangeIdUtil.insertId(commitMessage, id);
|
|
||||||
}
|
|
||||||
|
|
||||||
if (Boolean.TRUE.equals(me.state().getGeneralPreferences().signedOffBy)) {
|
|
||||||
commitMessage =
|
|
||||||
Joiner.on("\n")
|
|
||||||
.join(
|
|
||||||
commitMessage.trim(),
|
|
||||||
String.format(
|
|
||||||
"%s%s",
|
|
||||||
SIGNED_OFF_BY_TAG,
|
|
||||||
me.state().getAccount().getNameEmail(anonymousCowardName)));
|
|
||||||
}
|
|
||||||
|
|
||||||
RevCommit c;
|
RevCommit c;
|
||||||
if (input.merge != null) {
|
if (input.merge != null) {
|
||||||
@@ -391,6 +373,35 @@ public class CreateChange
|
|||||||
return parentCommit;
|
return parentCommit;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private String getCommitMessage(
|
||||||
|
String subject,
|
||||||
|
IdentifiedUser me,
|
||||||
|
ObjectInserter objectInserter,
|
||||||
|
RevCommit mergeTip,
|
||||||
|
PersonIdent author)
|
||||||
|
throws IOException {
|
||||||
|
// Add a Change-Id line if there isn't already one
|
||||||
|
String commitMessage = subject;
|
||||||
|
if (ChangeIdUtil.indexOfChangeId(commitMessage, "\n") == -1) {
|
||||||
|
ObjectId treeId = mergeTip == null ? emptyTreeId(objectInserter) : mergeTip.getTree();
|
||||||
|
ObjectId id = ChangeIdUtil.computeChangeId(treeId, mergeTip, author, author, commitMessage);
|
||||||
|
commitMessage = ChangeIdUtil.insertId(commitMessage, id);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (Boolean.TRUE.equals(me.state().getGeneralPreferences().signedOffBy)) {
|
||||||
|
commitMessage =
|
||||||
|
Joiner.on("\n")
|
||||||
|
.join(
|
||||||
|
commitMessage.trim(),
|
||||||
|
String.format(
|
||||||
|
"%s%s",
|
||||||
|
SIGNED_OFF_BY_TAG,
|
||||||
|
me.state().getAccount().getNameEmail(anonymousCowardName)));
|
||||||
|
}
|
||||||
|
|
||||||
|
return commitMessage;
|
||||||
|
}
|
||||||
|
|
||||||
private static RevCommit newCommit(
|
private static RevCommit newCommit(
|
||||||
ObjectInserter oi,
|
ObjectInserter oi,
|
||||||
RevWalk rw,
|
RevWalk rw,
|
||||||
|
|||||||
Reference in New Issue
Block a user