opendev/gerrit
Code Issues Proposed changes

FileInfo: Include size delta

Browse Source 
Reviewers are interested in the size of a change that was done to a
file. This is why for non-binary files the number of inserted/deleted
lines is shown. For binary files there is no indication of how big the
change was. With this change we compute for the file size delta in
bytes and return it in the FileInfo. The client can use this
information to show the file size increase/decrease in the file list
(not done in this change).

Please note that a field was added to PatchListEntry and hence the
diff cache must be flushed once.

Change-Id: I0252387099c724251b71480c36b52b7f8d46e713
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2015-10-08 15:53:20 +02:00
parent 0d9f089856
commit 640f984b54
5 changed files with 83 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
Documentation/rest-api-changes.txt
View File

@@ -405,29 +405,36 @@ default. Optional fields are:
},
"files": {
"gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeCache.java": {
"lines_deleted": 8
"lines_deleted": 8,
"size_delta": -412
},
"gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeDetailCache.java": {
"lines_inserted": 1
"lines_inserted": 1,
"size_delta": 23
},
"gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeScreen.java": {
"lines_inserted": 11,
"lines_deleted": 19
"lines_deleted": 19,
"size_delta": -298
},
"gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeTable.java": {
"lines_inserted": 23,
"lines_deleted": 20
"lines_deleted": 20,
"size_delta": 132
},
"gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/StarCache.java": {
"status": "D",
"lines_deleted": 139
"lines_deleted": 139,
"size_delta": -5512
},
"gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/StarredChanges.java": {
"status": "A",
"lines_inserted": 204
"lines_inserted": 204,
"size_delta": 8345
},
"gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/Screen.java": {
"lines_deleted": 9
"lines_deleted": 9,
"size_delta": -343
}
}
}
@@ -3254,11 +3261,13 @@ sorted by file path.
{
"/COMMIT_MSG": {
"status": "A",
"lines_inserted": 7
"lines_inserted": 7,
"size_delta": 551
},
"gerrit-server/src/main/java/com/google/gerrit/server/project/RefControl.java": {
"lines_inserted": 5,
"lines_deleted": 3
"lines_deleted": 3,
"size_delta": 98
}
}
----
@@ -4199,6 +4208,8 @@ Not set for binary files or if no lines were inserted.
|`lines_deleted` |optional|
Number of deleted lines. +
Not set for binary files or if no lines were deleted.
|`size_delta` ||
Number of bytes by which the file size increased/decreased.
|=============================
[[fix-input]]