From 64ae6233944949c0cd14a96608a8f003a05fd91c Mon Sep 17 00:00:00 2001 From: Edwin Kempin Date: Tue, 2 Jan 2018 14:07:57 +0100 Subject: [PATCH] GpgKeys: Remove redundant validity check of the ID string The same check is performed in parseFingerprint. Change-Id: I87d085ab6fb56b76742368c4cabacc465634ccc3 Signed-off-by: Edwin Kempin --- java/com/google/gerrit/gpg/server/GpgKeys.java | 5 ----- 1 file changed, 5 deletions(-) diff --git a/java/com/google/gerrit/gpg/server/GpgKeys.java b/java/com/google/gerrit/gpg/server/GpgKeys.java index 303499ee2e..63c0476f0d 100644 --- a/java/com/google/gerrit/gpg/server/GpgKeys.java +++ b/java/com/google/gerrit/gpg/server/GpgKeys.java @@ -91,11 +91,6 @@ public class GpgKeys implements ChildCollection { public GpgKey parse(AccountResource parent, IdString id) throws ResourceNotFoundException, PGPException, OrmException, IOException { checkVisible(self, parent); - String str = CharMatcher.whitespace().removeFrom(id.get()).toUpperCase(); - if ((str.length() != 8 && str.length() != 40) - || !CharMatcher.anyOf("0123456789ABCDEF").matchesAllOf(str)) { - throw new ResourceNotFoundException(id); - } byte[] fp = parseFingerprint(id.get(), getGpgExtIds(parent)); try (PublicKeyStore store = storeProvider.get()) {