opendev/gerrit
Code Issues Proposed changes

Remove Apache Codec Dependency from ChangeEditIT

Browse Source 
Change-Id: I130222c479d267ef5ea694438f7f05472ef70db6
This commit is contained in:
Patrick Hiesel
2016-12-07 11:50:10 +01:00
committed by David Pursehouse
parent 732103129f
commit 654b8033df
3 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/edit/BUCK
View File

@@ -4,7 +4,6 @@ acceptance_tests(
group = 'edit',
srcs = ['ChangeEditIT.java'],
deps = [
'//lib/commons:codec',
'//lib/joda:joda-time',
],
labels = ['edit'],

1
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/edit/BUILD
View File

@@ -5,7 +5,6 @@ acceptance_tests(
group = "edit",
labels = ["edit"],
deps = [
"//lib/commons:codec",
"//lib/joda:joda-time",
],
)

6
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/edit/ChangeEditIT.java
View File

@@ -65,7 +65,6 @@ import com.google.gson.stream.JsonReader;
import com.google.gwtorm.server.SchemaFactory;
import com.google.inject.Inject;
import org.apache.commons.codec.binary.StringUtils;
import org.eclipse.jgit.internal.storage.dfs.InMemoryRepository;
import org.eclipse.jgit.junit.TestRepository;
import org.eclipse.jgit.lib.ObjectId;
@@ -646,16 +645,15 @@ public class ChangeEditIT extends AbstractDaemonTest {
Optional<ChangeEdit> edit = editUtil.byChange(change);
assertThat(modifier.modifyFile(edit.get(), FILE_NAME, RawInputUtil.create(CONTENT_NEW2)))
.isEqualTo(RefUpdate.Result.FORCED);
edit = editUtil.byChange(change);
RestResponse r = adminRestSession.getJsonAccept(urlEditFile());
r.assertOK();
assertThat(readContentFromJson(r)).isEqualTo(
StringUtils.newStringUtf8(CONTENT_NEW2));
new String(CONTENT_NEW2, UTF_8));
r = adminRestSession.getJsonAccept(urlEditFile(true));
r.assertOK();
assertThat(readContentFromJson(r)).isEqualTo(
StringUtils.newStringUtf8(CONTENT_OLD));
new String(CONTENT_OLD, UTF_8));
}
@Test