Merge branch 'stable-2.6'

* stable-2.6:
  Show 'No Differences' if diff is empty
  Add theme that displays Diffy on the left side of the top menu
  Support '${project}' token in dashboard title and description
  Minor corrections in the 2.6 release notes
This commit is contained in:
Shawn Pearce
2013-04-05 11:54:38 -07:00
8 changed files with 83 additions and 31 deletions

View File

@@ -61,6 +61,8 @@ import com.google.gwtexpui.globalkey.client.KeyCommand;
import com.google.gwtexpui.globalkey.client.KeyCommandSet;
import com.google.gwtexpui.safehtml.client.SafeHtmlBuilder;
import org.eclipse.jgit.diff.Edit;
import java.util.ArrayList;
import java.util.List;
@@ -239,13 +241,27 @@ public abstract class AbstractPatchContentTable extends NavigationTable<Object>
render(s, d);
}
protected boolean hasDifferences(final PatchScript script) {
// True if there are differences between the two patch sets
boolean hasEdits = !script.getEdits().isEmpty();
// True if this change is a mode change or a pure rename/copy
boolean hasMeta = !script.getPatchHeader().isEmpty();
protected boolean hasDifferences(PatchScript script) {
return hasEdits(script) || hasMeta(script);
}
return hasEdits || hasMeta;
public boolean isPureMetaChange(PatchScript script) {
return !hasEdits(script) && hasMeta(script);
}
// True if there are differences between the two patch sets
private boolean hasEdits(PatchScript script) {
for (Edit e : script.getEdits()) {
if (e.getType() != Edit.Type.EMPTY) {
return true;
}
}
return false;
}
// True if this change is a mode change or a pure rename/copy
private boolean hasMeta(PatchScript script) {
return !script.getPatchHeader().isEmpty();
}
protected void appendNoDifferences(SafeHtmlBuilder m) {

View File

@@ -420,14 +420,10 @@ public abstract class PatchScreen extends Screen implements
break;
}
}
// True if there are differences between the two patch sets
boolean hasEdits = !script.getEdits().isEmpty();
// True if this change is a mode change or a pure rename/copy
boolean hasMeta = !script.getPatchHeader().isEmpty();
boolean pureMetaChange = !hasEdits && hasMeta;
if (contentTable instanceof SideBySideTable && pureMetaChange && !contentTable.isDisplayBinary) {
if (contentTable instanceof SideBySideTable
&& contentTable.isPureMetaChange(script)
&& !contentTable.isDisplayBinary) {
// User asked for SideBySide (or a link guessed, wrong) and we can't
// show a pure-rename change there accurately. Switch to
// the unified view instead. User can set file comments on binary file