Use static inner classes where appropriate

The classes:

 - ProjectInfoScreen.ProjectDownloadPanel
 - ListAccess.AccessSectionInfo

have inner classes which according to Findbugs:

"does not use its embedded reference to the object which created it.
This reference makes the instances of the class larger, and may keep
the reference to the creator object alive longer than necessary."

Make these inner classes static.

Change-Id: I9d544ff83d9647420a9d182643a60fa539bbce19
This commit is contained in:
David Pursehouse
2015-07-07 19:22:06 +09:00
parent b3941cb807
commit 6634f2c18b
2 changed files with 2 additions and 2 deletions

View File

@@ -690,7 +690,7 @@ public class ProjectInfoScreen extends ProjectScreen {
return pluginConfigValues;
}
public class ProjectDownloadPanel extends DownloadPanel {
public static class ProjectDownloadPanel extends DownloadPanel {
public ProjectDownloadPanel(String project, boolean isAllowsAnonymous) {
super(project, isAllowsAnonymous);
}