Use static inner classes where appropriate
The classes: - ProjectInfoScreen.ProjectDownloadPanel - ListAccess.AccessSectionInfo have inner classes which according to Findbugs: "does not use its embedded reference to the object which created it. This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary." Make these inner classes static. Change-Id: I9d544ff83d9647420a9d182643a60fa539bbce19
This commit is contained in:
@@ -690,7 +690,7 @@ public class ProjectInfoScreen extends ProjectScreen {
|
||||
return pluginConfigValues;
|
||||
}
|
||||
|
||||
public class ProjectDownloadPanel extends DownloadPanel {
|
||||
public static class ProjectDownloadPanel extends DownloadPanel {
|
||||
public ProjectDownloadPanel(String project, boolean isAllowsAnonymous) {
|
||||
super(project, isAllowsAnonymous);
|
||||
}
|
||||
|
Reference in New Issue
Block a user