opendev/gerrit
Code Issues Proposed changes

TreeModificationSubject: Remove unnecessary message for simpler code

Browse Source 
This change is the same as I97c81bf2c was for RobotCommentInfoSubject.
When migrated off the named() method, which we can't use in the future
anymore, the resulting code would be unnecessarily complex without
adding any real value. Hence, shortcut the migration and remove the
named parameter. Also simplify the code with a more concise expression.

Change-Id: I8c88f2bddac44fafb0cf875c23fdd0e3cd161810
This commit is contained in:
Alice Kober-Sotzek
2019-05-02 21:37:02 +02:00
parent 46eb541d7e
commit 6645292eeb
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
javatests/com/google/gerrit/server/edit/tree/TreeModificationSubject.java
View File

@@ -33,9 +33,7 @@ public class TreeModificationSubject extends Subject<TreeModificationSubject, Tr
public static ListSubject<TreeModificationSubject, TreeModification> assertThatList(
List<TreeModification> treeModifications) {
return assertAbout(ListSubject.elements())
.thatCustom(treeModifications, treeModifications())
.named("treeModifications");
return ListSubject.assertThat(treeModifications, treeModifications());
}
private TreeModificationSubject(