From 359cd63caf3dfa8feac71c6d92ec06e87bfc60f5 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Wed, 1 Aug 2018 11:12:04 +0200 Subject: [PATCH 1/2] dev-contributing: use buildifer 0.15.0 Version 0.15.0 is the latest. Running it on the build files does not result in any formatting changes. Change-Id: I6e9ad5c8cf4cba4e775fcce88b6e79fb57ed2e71 --- Documentation/dev-contributing.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/dev-contributing.txt b/Documentation/dev-contributing.txt index cff941e729..a6fdee8f8e 100644 --- a/Documentation/dev-contributing.txt +++ b/Documentation/dev-contributing.txt @@ -155,7 +155,7 @@ To format Java source code, Gerrit uses the link:https://github.com/google/google-java-format[`google-java-format`] tool (version 1.5), and to format Bazel BUILD, WORKSPACE and .bzl files the link:https://github.com/bazelbuild/buildtools/tree/master/buildifier[`buildifier`] -tool (version 0.12.0). +tool (version 0.15.0). These tools automatically apply format according to the style guides; this streamlines code review by reducing the need for time-consuming, tedious, and contentious discussions about trivial issues like whitespace. From c0c935d2b327fd55c228f8391e14a30682b7765c Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Wed, 1 Aug 2018 15:32:29 +0200 Subject: [PATCH 2/2] Clarify that receive.maxObjectSizeLimit does not get inherited Change-Id: If10ace95990a3ef032da4d700333dc76501ec9e6 --- Documentation/config-project-config.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/config-project-config.txt b/Documentation/config-project-config.txt index 611085278d..649bbf876a 100644 --- a/Documentation/config-project-config.txt +++ b/Documentation/config-project-config.txt @@ -141,7 +141,8 @@ objects which are too large to Gerrit. This setting can also be set in receive.maxObjectSizeLimit]). + The project specific setting in `project.config` is only honored when it -further reduces the global limit. +further reduces the global limit. The setting is not inherited from the +parent project; it must be explicitly set per project. + Default is zero. +