opendev/gerrit
Code Issues Proposed changes

AbstractQueryChangesTest: Add coverage for is:reviewer and reviewer:self

Browse Source 
Bug: Issue 8605
Change-Id: I592d7c24261490376ba972edc3cecb59471079da
This commit is contained in:
David Pursehouse
2018-04-16 11:51:33 +02:00
parent bf8b5dd993
commit 66a701ca27
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gerrit-server/src/test/java/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java
View File

@@ -1627,6 +1627,7 @@ public abstract class AbstractQueryChangesTest extends GerritServerTests {
TestRepository<Repo> repo = createProject("repo"); TestRepository<Repo> repo = createProject("repo");
Change change1 = insert(repo, newChange(repo)); Change change1 = insert(repo, newChange(repo));
Change change2 = insert(repo, newChange(repo)); Change change2 = insert(repo, newChange(repo));
Change change3 = insert(repo, newChange(repo));
insert(repo, newChange(repo)); insert(repo, newChange(repo));
AddReviewerInput rin = new AddReviewerInput(); AddReviewerInput rin = new AddReviewerInput();
@@ -1639,6 +1640,12 @@ public abstract class AbstractQueryChangesTest extends GerritServerTests {
rin.state = ReviewerState.CC; rin.state = ReviewerState.CC;
gApi.changes().id(change2.getId().get()).addReviewer(rin); gApi.changes().id(change2.getId().get()).addReviewer(rin);
assertQuery("is:reviewer");
assertQuery("reviewer:self");
gApi.changes().id(change3.getChangeId()).revision("current").review(ReviewInput.recommend());
assertQuery("is:reviewer", change3);
assertQuery("reviewer:self", change3);
if (notesMigration.readChanges()) { if (notesMigration.readChanges()) {
assertQuery("reviewer:" + user1, change1); assertQuery("reviewer:" + user1, change1);
assertQuery("cc:" + user1, change2); assertQuery("cc:" + user1, change2);