opendev/gerrit
Code Issues Proposed changes

Merge "ProjectsCollection: Add debug log with project state"

Browse Source
This commit is contained in:
Dave Borowitz
2018-09-27 13:40:13 +00:00
committed by Gerrit Code Review
parent 4125462910 513eb4a39a
commit 66db48d4c7
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
java/com/google/gerrit/server/restapi/project/ProjectsCollection.java
View File

@@ -15,6 +15,7 @@
package com.google.gerrit.server.restapi.project; package com.google.gerrit.server.restapi.project;
import com.google.common.collect.ListMultimap; import com.google.common.collect.ListMultimap;
import com.google.common.flogger.FluentLogger;
import com.google.gerrit.common.Nullable; import com.google.gerrit.common.Nullable;
import com.google.gerrit.extensions.registration.DynamicMap; import com.google.gerrit.extensions.registration.DynamicMap;
import com.google.gerrit.extensions.restapi.AuthException; import com.google.gerrit.extensions.restapi.AuthException;
@@ -46,6 +47,8 @@ import org.eclipse.jgit.lib.Constants;
@Singleton @Singleton
public class ProjectsCollection public class ProjectsCollection
implements RestCollection<TopLevelResource, ProjectResource>, NeedsParams { implements RestCollection<TopLevelResource, ProjectResource>, NeedsParams {
private static final FluentLogger logger = FluentLogger.forEnclosingClass();
private final DynamicMap<RestView<ProjectResource>> views; private final DynamicMap<RestView<ProjectResource>> views;
private final Provider<ListProjects> list; private final Provider<ListProjects> list;
private final Provider<QueryProjects> queryProjects; private final Provider<QueryProjects> queryProjects;
@@ -143,6 +146,8 @@ public class ProjectsCollection
return null; return null;
} }
logger.atFine().log("Project %s has state %s", nameKey, state.getProject().getState());
if (checkAccess) { if (checkAccess) {
// Hidden projects(permitsRead = false) should only be accessible by the project owners. // Hidden projects(permitsRead = false) should only be accessible by the project owners.
// WRITE_CONFIG is checked here because it's only allowed to project owners (ACCESS may also // WRITE_CONFIG is checked here because it's only allowed to project owners (ACCESS may also