opendev/gerrit
Code Issues Proposed changes

EmailIT: Use String#replace method instead String#replaceAll

Browse Source 
String#replaceAll uses a regular expression when searching targets which
is not needed to replace '@'.

Change-Id: I0b109ab61545648f1c62dd5f9b238de3f78ff0cf
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2017-02-10 11:28:36 +01:00
parent 9204602888
commit 678ea8eaf7
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/account/EmailIT.java
View File

@@ -42,7 +42,7 @@ public class EmailIT extends AbstractDaemonTest {
String email = "foo.bar2@example.com";
assertThat(getEmails()).doesNotContain(email);
createEmail(email.replaceAll("@", "%40"));
createEmail(email.replace("@", "%40"));
assertThat(getEmails()).contains(email);
}
@@ -67,8 +67,7 @@ public class EmailIT extends AbstractDaemonTest {
createEmail(email);
assertThat(getEmails()).contains(email);
RestResponse r =
adminRestSession.delete("/accounts/self/emails/" + email.replaceAll("@", "%40"));
RestResponse r = adminRestSession.delete("/accounts/self/emails/" + email.replace("@", "%40"));
r.assertNoContent();
assertThat(getEmails()).doesNotContain(email);
}