opendev/gerrit
Code Issues Proposed changes

Create account-indexed extension point

Browse Source 
Add a new extension point so that plugins can be notified when an
account has been indexed.

Change-Id: I5cba1be9df06b70d870540722d099c3d8397c351
This commit is contained in:
Hugo Arès
2017-04-24 13:44:43 +02:00
parent 345b93f6bc
commit 682171fc81
4 changed files with 50 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/config/GerritGlobalModule.java
View File

@@ -29,6 +29,7 @@ import com.google.gerrit.extensions.config.DownloadCommand;
import com.google.gerrit.extensions.config.DownloadScheme;
import com.google.gerrit.extensions.config.ExternalIncludedIn;
import com.google.gerrit.extensions.config.FactoryModule;
import com.google.gerrit.extensions.events.AccountIndexedListener;
import com.google.gerrit.extensions.events.AgreementSignupListener;
import com.google.gerrit.extensions.events.ChangeAbandonedListener;
import com.google.gerrit.extensions.events.ChangeIndexedListener;
@@ -319,6 +320,7 @@ public class GerritGlobalModule extends FactoryModule {
DynamicSet.setOf(binder(), PostReceiveHook.class);
DynamicSet.setOf(binder(), PreUploadHook.class);
DynamicSet.setOf(binder(), PostUploadHook.class);
DynamicSet.setOf(binder(), AccountIndexedListener.class);
DynamicSet.setOf(binder(), ChangeIndexedListener.class);
DynamicSet.setOf(binder(), NewProjectCreatedListener.class);
DynamicSet.setOf(binder(), ProjectDeletedListener.class);

14
gerrit-server/src/main/java/com/google/gerrit/server/index/account/AccountIndexerImpl.java
View File

@@ -16,6 +16,8 @@ package com.google.gerrit.server.index.account;
import com.google.common.collect.ImmutableSet;
import com.google.gerrit.common.Nullable;
import com.google.gerrit.extensions.events.AccountIndexedListener;
import com.google.gerrit.extensions.registration.DynamicSet;
import com.google.gerrit.reviewdb.client.Account;
import com.google.gerrit.server.account.AccountCache;
import com.google.gerrit.server.account.AccountState;
@@ -34,21 +36,26 @@ public class AccountIndexerImpl implements AccountIndexer {
}
private final AccountCache byIdCache;
private final DynamicSet<AccountIndexedListener> indexedListener;
private final AccountIndexCollection indexes;
private final AccountIndex index;
@AssistedInject
AccountIndexerImpl(AccountCache byIdCache,
DynamicSet<AccountIndexedListener> indexedListener,
@Assisted AccountIndexCollection indexes) {
this.byIdCache = byIdCache;
this.indexedListener = indexedListener;
this.indexes = indexes;
this.index = null;
}
@AssistedInject
AccountIndexerImpl(AccountCache byIdCache,
DynamicSet<AccountIndexedListener> indexedListener,
@Assisted AccountIndex index) {
this.byIdCache = byIdCache;
this.indexedListener = indexedListener;
this.indexes = null;
this.index = index;
}
@@ -58,6 +65,13 @@ public class AccountIndexerImpl implements AccountIndexer {
for (Index<?, AccountState> i : getWriteIndexes()) {
i.replace(byIdCache.get(id));
}
fireAccountIndexedEvent(id.get());
}
private void fireAccountIndexedEvent(int id) {
for (AccountIndexedListener listener : indexedListener) {
listener.onAccountIndexed(id);
}
}
private Collection<AccountIndex> getWriteIndexes() {