opendev/gerrit
Code Issues Proposed changes

AccountIT#putStatus: Unset status at test end

Browse Source 
This test modifies the status of the admin account but other tests may
expect that the status was not set. It currently only works because the
test also sets the status in the cached TestAccount instance. This will
stop working when we reset account branches after each test because then
the status in the cached TestAccount will not match with the status in
NoteDb after the reset. Instead unset the status at the test end. This
also verifies that unsetting the status works.

Change-Id: I44e77fc300d5c1c7fee8ad231aeec109455e2f64
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2017-11-28 10:41:17 +01:00
parent c17e94ccfc
commit 68b8da7437
2 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
java/com/google/gerrit/acceptance/TestAccount.java
View File

@@ -47,7 +47,6 @@ public class TestAccount {
public final String fullName;
public final KeyPair sshKey;
public final String httpPassword;
public String status;
TestAccount(
Account.Id id,