opendev/gerrit
Code Issues Proposed changes

Don't include directory entries in GWT UI zip files

Browse Source 
Currently, the GWT UI zip files contain some empty bazel directories:

$ unzip -l bazel-genfiles/gerrit-gwtui/ui_optdbg.zip | grep bazel
Archive:  bazel-genfiles/gerrit-gwtui/ui_optdbg.zip
        0  2016-12-20 09:57   bazel-out/
        0  2016-12-20 09:57   bazel-out/local-fastbuild/
        0  2016-12-20 09:57   bazel-out/local-fastbuild/genfiles/
        0  2016-12-20 09:57   bazel-out/local-fastbuild/genfiles/gerrit-gwtui/

These end up making it into the WAR files, which is unfortunate. The
easiest way to eliminate these is to just omit all directories from
this one intermediate zip file. As there are several other
intermediate zip files, we actually still end up with directory
entries in the output WAR, just not these garbage ones.

Change-Id: I32bb39acc4d32207f9e006486cbba47fc06e0be0
This commit is contained in:
Dave Borowitz
2016-12-20 11:30:46 -05:00
parent 42ea853037
commit 68ea4b0075
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tools/bzl/gwt.bzl
View File

@@ -250,7 +250,7 @@ def gwt_genrule(suffix = ""):
' gerrit_ui/dbg_gerrit_ui.nocache.js;' +
'unzip -qo $$ROOT/$(location :%s);' % opt +
'mkdir -p $$(dirname $@);' +
'zip -qr $$ROOT/$@ .',
'zip -qrD $$ROOT/$@ .',
outs = ['ui_optdbg' + suffix + '.zip'],
visibility = ['//visibility:public'],
)