opendev/gerrit
Code Issues Proposed changes

bower2buck: Fix import to follow Google's Python Style Guide

Browse Source 
The Imports section of the style guide [1] says imports should
only be used for packages and modules.

[1] https://google.github.io/styleguide/pyguide.html?showone=Imports#Imports

Change-Id: Id293cc0a0243d7f4943fe5b7645f8798633c3423
This commit is contained in:
David Pursehouse
2016-10-20 08:45:56 +09:00
parent daf0e744ca
commit 6935c62ea8
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tools/js/bower2buck.py
View File

@@ -26,7 +26,7 @@ import subprocess
import sys import sys
import tempfile import tempfile
from tools.js.bowerutil import hash_bower_component from tools.js import bowerutil
# This script is run with `buck run`, but needs to shell out to buck; this is # This script is run with `buck run`, but needs to shell out to buck; this is
# only possible if we avoid buckd. # only possible if we avoid buckd.
@@ -77,7 +77,7 @@ class Rule(object):
self.version = bower_json['version'] self.version = bower_json['version']
self.deps = bower_json.get('dependencies', {}) self.deps = bower_json.get('dependencies', {})
self.license = bower_json.get('license', 'NO LICENSE') self.license = bower_json.get('license', 'NO LICENSE')
self.sha1 = hash_bower_component( self.sha1 = bowerutil.hash_bower_component(
hashlib.sha1(), os.path.dirname(bower_json_path)).hexdigest() hashlib.sha1(), os.path.dirname(bower_json_path)).hexdigest()
def to_rule(self, packages): def to_rule(self, packages):