opendev/gerrit
Code Issues Proposed changes

Change the number of reviewer suggestions from 10 to 6

Browse Source 
It is unlikely that users benefit from more than 6 suggestions. OTOH
big suggestion boxes can obscure useful content.

Bug: Issue 10793
Change-Id: Ib32833f01cb422f6c8873bdcdd79807055dfcdf2
This commit is contained in:
Ben Rohlfs
2019-04-29 23:15:57 +02:00
parent 3b78332bf8
commit 694acf9a4f
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js
View File

@@ -1526,7 +1526,9 @@
* @param {function(?Response, string=)=} opt_errFn * @param {function(?Response, string=)=} opt_errFn
*/ */
getChangeSuggestedReviewers(changeNum, inputVal, opt_errFn) { getChangeSuggestedReviewers(changeNum, inputVal, opt_errFn) {
const params = {n: 10}; // More suggestions may obscure content underneath in the reply dialog,
// see issue 10793.
const params = {n: 6};
if (inputVal) { params.q = inputVal; } if (inputVal) { params.q = inputVal; }
return this._getChangeURLAndFetch({ return this._getChangeURLAndFetch({
changeNum, changeNum,