From 695b756ef9e2b56e6fc92d4e96b6e379851e2a70 Mon Sep 17 00:00:00 2001
From: Kasper Nilsson <kaspern@google.com>
Date: Tue, 27 Feb 2018 13:37:44 -0800
Subject: [PATCH] Allow inputting refs or commits for rebase

The rebase dialog was updated recently with an autocomplete for change
numbers. Refs and commit hashes never appear in the autocomplete, thus
that change disabled the ability to rebase onto those types of entries.

This change adds an additional parameter to allow users to input values
other than the suggested change numbers, e.g. a ref.

Bug: Issue 8412
Change-Id: I90173641d0f0127abdb94edb994249851e4a2ca8
---
 .../gr-confirm-rebase-dialog/gr-confirm-rebase-dialog.html   | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/polygerrit-ui/app/elements/change/gr-confirm-rebase-dialog/gr-confirm-rebase-dialog.html b/polygerrit-ui/app/elements/change/gr-confirm-rebase-dialog/gr-confirm-rebase-dialog.html
index 4370d7e5ae..ea70de96a1 100644
--- a/polygerrit-ui/app/elements/change/gr-confirm-rebase-dialog/gr-confirm-rebase-dialog.html
+++ b/polygerrit-ui/app/elements/change/gr-confirm-rebase-dialog/gr-confirm-rebase-dialog.html
@@ -95,7 +95,7 @@ limitations under the License.
               type="radio"
               on-tap="_handleRebaseOnOther">
           <label id="rebaseOnOtherLabel" for="rebaseOnOtherInput">
-            Rebase on a specific change or ref <span hidden$="[[!hasParent]]">
+            Rebase on a specific change, ref, or commit <span hidden$="[[!hasParent]]">
               (breaks relation chain)
             </span>
           </label>
@@ -107,7 +107,8 @@ limitations under the License.
               text="{{_inputText}}"
               on-tap="_handleEnterChangeNumberTap"
               on-commit="_handleBaseSelected"
-              placeholder="Change number">
+              allow-non-suggested-values
+              placeholder="Change number, ref, or commit hash">
           </gr-autocomplete>
         </div>
       </div>