opendev/gerrit
Code Issues Proposed changes

Fix static analyzer findings

Browse Source 
In FakeChangeIndex, make static Schema declarations final.

In AbstractQueryAccountsTest, make the private inner class static.

Change-Id: Iaedae36d88df24a870470a704d0f2ca18e8c1e87
This commit is contained in:
Patrick Hiesel
2017-11-14 17:47:00 +01:00
committed by David Pursehouse
parent 272552ad6f
commit 69e587c017
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
javatests/com/google/gerrit/server/index/change/FakeChangeIndex.java
View File

@@ -30,10 +30,10 @@ import org.junit.Ignore;
@Ignore
public class FakeChangeIndex implements ChangeIndex {
static Schema<ChangeData> V1 =
static final Schema<ChangeData> V1 =
new Schema<>(1, ImmutableList.<FieldDef<ChangeData, ?>>of(ChangeField.STATUS));
static Schema<ChangeData> V2 =
static final Schema<ChangeData> V2 =
new Schema<>(2, ImmutableList.of(ChangeField.STATUS, ChangeField.PATH, ChangeField.UPDATED));
private static class Source implements ChangeDataSource {