From 69eb1512ef3a89603b7c6ddd63fe4e56e6eaf427 Mon Sep 17 00:00:00 2001 From: Wyatt Allen Date: Wed, 28 Mar 2018 17:14:51 -0700 Subject: [PATCH] Re-disable debounce on account entry The _getReviewerSuggestions method of gr-account-entry exits early if the change property has not yet been set. This had the effect of preventing a request for reviewer suggestions as soon as the change view loaded. Such a request would succeed if the user was logged in, but its result would be unused. If the user was not logged in it would fail and show an authentication toast. When the account entry autocomplete query was debounced, this rearranged the timing -- now _getReviewerSuggestions was called after the change property had been set so that it would not exit early and would trigger a toast for unauthenticated users. Disable debouncing in account entries again to preserve the original timing. This solution works for the time being -- until we can omit the unused account entries for unauthenticated users. Bug: Issue 8149 Change-Id: I50baebfdde0079470748834075d519510b519c57 --- .../app/elements/change/gr-account-entry/gr-account-entry.html | 1 + 1 file changed, 1 insertion(+) diff --git a/polygerrit-ui/app/elements/change/gr-account-entry/gr-account-entry.html b/polygerrit-ui/app/elements/change/gr-account-entry/gr-account-entry.html index 582c83bbe4..c94a7163e4 100644 --- a/polygerrit-ui/app/elements/change/gr-account-entry/gr-account-entry.html +++ b/polygerrit-ui/app/elements/change/gr-account-entry/gr-account-entry.html @@ -37,6 +37,7 @@ limitations under the License. threshold="[[suggestFrom]]" query="[[query]]" allow-non-suggested-values="[[allowAnyInput]]" + no-debounce on-commit="_handleInputCommit" clear-on-commit warn-uncommitted