opendev/gerrit
Code Issues Proposed changes

Merge branch 'stable-2.15'

Browse Source 
* stable-2.15:
  Bazel: Silent zip output in gerrit-antlr:query_antlr rule
  Provide mvn command output when VERBOSE set
  ReviewerRecommender: Prevent NPE when changeNotes is null
  ReviewerSuggestion: More Javadoc improvements

Change-Id: I433e257961e14b38332997daea8c6e39c42b7d98
This commit is contained in:
David Pursehouse
2018-02-08 17:30:40 +09:00
parent ebd7a9dd97 e277b1554f
commit 6a244f0967
4 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
java/com/google/gerrit/server/change/ReviewerSuggestion.java
View File

@@ -29,14 +29,15 @@ import java.util.Set;
@ExtensionPoint
public interface ReviewerSuggestion {
/**
* Reviewer suggestion.
* Suggest reviewers to add to a change.
*
* @param project The name key of the project the suggestion is for.
* @param changeId The changeId that the suggestion is for. Can be an {@code null}.
* @param query The query as typed by the user. Can be an {@code null}.
* @param changeId The changeId that the suggestion is for. Can be {@code null}.
* @param query The query as typed by the user. Can be {@code null}.
* @param candidates A set of candidates for the ranking. Can be empty.
* @return Set of suggested reviewers as a tuple of account id and score. The account ids listed
* here don't have to be a part of candidates.
* @return Set of {@link SuggestedReviewer}s. The {@link
* com.google.gerrit.reviewdb.client.Account.Id}s listed here don't have to be included in
* {@code candidates}.
*/
Set<SuggestedReviewer> suggestReviewers(
Project.NameKey project,