opendev/gerrit
Code Issues Proposed changes

Merge "Add some @Nullable annotations to VersionedMetaData"

Browse Source
This commit is contained in:
Edwin Kempin
2017-11-17 08:57:50 +00:00
committed by Gerrit Code Review
parent 8a712cbb29 014a9cfd4c
commit 6a70aea137
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
java/com/google/gerrit/server/git/VersionedMetaData.java
View File

@@ -17,6 +17,7 @@ package com.google.gerrit.server.git;
import static com.google.common.base.Preconditions.checkArgument; import static com.google.common.base.Preconditions.checkArgument;
import com.google.common.base.MoreObjects; import com.google.common.base.MoreObjects;
import com.google.gerrit.common.Nullable;
import java.io.BufferedReader; import java.io.BufferedReader;
import java.io.IOException; import java.io.IOException;
import java.io.StringReader; import java.io.StringReader;
@@ -76,7 +77,9 @@ public abstract class VersionedMetaData {
} }
} }
protected RevCommit revision; /** The revision at which the data was loaded. Is null for data yet to be created. */
@Nullable protected RevCommit revision;
protected RevWalk rw; protected RevWalk rw;
protected ObjectReader reader; protected ObjectReader reader;
protected ObjectInserter inserter; protected ObjectInserter inserter;
@@ -133,7 +136,8 @@ public abstract class VersionedMetaData {
* @throws IOException * @throws IOException
* @throws ConfigInvalidException * @throws ConfigInvalidException
*/ */
public void load(Repository db, ObjectId id) throws IOException, ConfigInvalidException { public void load(Repository db, @Nullable ObjectId id)
throws IOException, ConfigInvalidException {
try (RevWalk walk = new RevWalk(db)) { try (RevWalk walk = new RevWalk(db)) {
load(walk, id); load(walk, id);
} }