opendev/gerrit
Code Issues Proposed changes

Soy: Extend shortSubject to 72 chars

Browse Source 
The default wrap value is 72. Conform to that.

Change-Id: I6ca5824831a48e90e1b697fb153102c7e38adbd8
This commit is contained in:
Orgad Shaneh 2017-06-15 14:30:59 +03:00
parent c50c228684
commit 6add177648
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Documentation/config-mail.txt
View File

@ -201,7 +201,7 @@ The subject corresponding to the first patch set of the current change.
$change.shortSubject:: $change.shortSubject::
+ +
The subject limited to 63 characters, with an ellipsis if it exceeds that. The subject limited to 72 characters, with an ellipsis if it exceeds that.
$change.ownerEmail:: $change.ownerEmail::
+ +

4
gerrit-server/src/main/java/com/google/gerrit/server/mail/send/ChangeEmail.java
View File

@ -458,10 +458,10 @@ public abstract class ChangeEmail extends NotificationEmail {
changeData.put("subject", subject); changeData.put("subject", subject);
// shortSubject is the subject limited to 63 characters, with an ellipsis if // shortSubject is the subject limited to 63 characters, with an ellipsis if
// it exceeds that. // it exceeds that.
if (subject.length() < 64) { if (subject.length() < 73) {
changeData.put("shortSubject", subject); changeData.put("shortSubject", subject);
} else { } else {
changeData.put("shortSubject", subject.substring(0, 60) + "..."); changeData.put("shortSubject", subject.substring(0, 69) + "...");
} }
Map<String, Object> patchSetData = new HashMap<>(); Map<String, Object> patchSetData = new HashMap<>();