Merge "Label: Make the meaning of the blank cell visible"

This commit is contained in:
Dave Borowitz 2013-09-24 19:20:32 +00:00 committed by Gerrit Code Review
commit 6b091a0636
5 changed files with 10 additions and 1 deletions

View File

@ -48,6 +48,8 @@ public interface GerritConstants extends Constants {
String inactiveAccountBody(); String inactiveAccountBody();
String labelNotApplicable();
String menuAll(); String menuAll();
String menuAllOpen(); String menuAllOpen();
String menuAllMerged(); String menuAllMerged();

View File

@ -31,6 +31,8 @@ noSuchGroupTitle = Code Review - Unknown Group
inactiveAccountBody = This user is currently inactive. inactiveAccountBody = This user is currently inactive.
labelNotApplicable = Label not applicable
menuAll = All menuAll = All
menuAllOpen = Open menuAllOpen = Open
menuAllMerged = Merged menuAllMerged = Merged

View File

@ -141,6 +141,7 @@ public interface GerritCss extends CssResource {
String infoTable(); String infoTable();
String inputFieldTypeHint(); String inputFieldTypeHint();
String labelList(); String labelList();
String labelNotApplicable();
String leftMostCell(); String leftMostCell();
String lineHeader(); String lineHeader();
String lineNumber(); String lineNumber();

View File

@ -230,7 +230,8 @@ public class ChangeTable2 extends NavigationTable<ChangeInfo> {
LabelInfo label = c.label(name); LabelInfo label = c.label(name);
if (label == null) { if (label == null) {
table.clearCell(row, col); fmt.getElement(row, col).setTitle(Gerrit.C.labelNotApplicable());
fmt.addStyleName(row, col, Gerrit.RESOURCES.css().labelNotApplicable());
continue; continue;
} }

View File

@ -595,6 +595,9 @@ a:hover {
.changeTable .dataCell.singleLine { .changeTable .dataCell.singleLine {
white-space: nowrap; white-space: nowrap;
} }
.changeTable .dataCell.labelNotApplicable {
background: #F5F5F5;
}
.changeTable .iconHeader { .changeTable .iconHeader {
border-top: 1px solid backgroundColor; border-top: 1px solid backgroundColor;
border-bottom: 1px solid backgroundColor; border-bottom: 1px solid backgroundColor;