opendev/gerrit
Code Issues Proposed changes

SuggestAccounts: Use Ordering#sortedCopy(...) to order results

Browse Source 
Change-Id: Icdb3790c1098230827baa828282fa03479874fe1
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2016-06-29 10:08:21 +02:00
parent 6725d06c30
commit 6b0e761490
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gerrit-server/src/main/java/com/google/gerrit/server/account/SuggestAccounts.java
View File

@@ -30,7 +30,6 @@ import com.google.inject.Inject;
import org.eclipse.jgit.lib.Config; import org.eclipse.jgit.lib.Config;
import org.kohsuke.args4j.Option; import org.kohsuke.args4j.Option;
import java.util.ArrayList;
import java.util.Collections; import java.util.Collections;
import java.util.HashMap; import java.util.HashMap;
import java.util.LinkedHashMap; import java.util.LinkedHashMap;
@@ -137,9 +136,7 @@ public class SuggestAccounts implements RestReadView<TopLevelResource> {
} }
} }
List<AccountInfo> m = new ArrayList<>(matches.values()); return AccountInfoComparator.ORDER_NULLS_LAST.sortedCopy(matches.values());
Collections.sort(m, AccountInfoComparator.ORDER_NULLS_LAST);
return m;
} }
private boolean addSuggestion(Map<Account.Id, AccountInfo> map, Account a) { private boolean addSuggestion(Map<Account.Id, AccountInfo> map, Account a) {