opendev/gerrit
Code Issues Proposed changes

UiAction: Don't create a new instance each time it is used

Browse Source 
UiActions don't maintain state and can be therefore moved in Singleton
scope.

Change-Id: I27224edd37140dc7e20acef0e5d0b397aa661a7a
This commit is contained in:
David Ostrovsky
2014-05-20 14:48:39 +02:00
parent 2806f76434
commit 6be9b6f65a
14 changed files with 33 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-server/src/main/java/com/google/gerrit/server/project/ListBranches.java
View File

@@ -26,6 +26,7 @@ import com.google.gerrit.reviewdb.client.RefNames;
import com.google.gerrit.server.extensions.webui.UiActions;
import com.google.gerrit.server.git.GitRepositoryManager;
import com.google.inject.Inject;
import com.google.inject.Singleton;
import com.google.inject.util.Providers;
import org.eclipse.jgit.errors.RepositoryNotFoundException;
@@ -42,6 +43,7 @@ import java.util.Map;
import java.util.Set;
import java.util.TreeMap;
@Singleton
public class ListBranches implements RestReadView<ProjectResource> {
private final GitRepositoryManager repoManager;
private final DynamicMap<RestView<BranchResource>> branchViews;