diff --git a/java/com/google/gerrit/server/config/ChangeUpdateExecutor.java b/java/com/google/gerrit/server/config/ChangeUpdateExecutor.java deleted file mode 100644 index 4c9e5f034d..0000000000 --- a/java/com/google/gerrit/server/config/ChangeUpdateExecutor.java +++ /dev/null @@ -1,29 +0,0 @@ -// Copyright (C) 2012 The Android Open Source Project -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. - -package com.google.gerrit.server.config; - -import static java.lang.annotation.RetentionPolicy.RUNTIME; - -import com.google.common.util.concurrent.ListeningExecutorService; -import com.google.gerrit.server.update.BatchUpdate; -import com.google.inject.BindingAnnotation; -import java.lang.annotation.Retention; - -/** - * Marker on the global {@link ListeningExecutorService} used by asynchronous {@link BatchUpdate}s. - */ -@Retention(RUNTIME) -@BindingAnnotation -public @interface ChangeUpdateExecutor {} diff --git a/java/com/google/gerrit/server/config/SysExecutorModule.java b/java/com/google/gerrit/server/config/SysExecutorModule.java index 6c729d9073..e7f454056b 100644 --- a/java/com/google/gerrit/server/config/SysExecutorModule.java +++ b/java/com/google/gerrit/server/config/SysExecutorModule.java @@ -14,19 +14,13 @@ package com.google.gerrit.server.config; -import com.google.common.util.concurrent.ListeningExecutorService; import com.google.common.util.concurrent.MoreExecutors; -import com.google.common.util.concurrent.ThreadFactoryBuilder; import com.google.gerrit.server.FanOutExecutor; import com.google.gerrit.server.git.WorkQueue; -import com.google.gerrit.server.logging.LoggingContextAwareExecutorService; import com.google.inject.AbstractModule; import com.google.inject.Provides; import com.google.inject.Singleton; -import java.util.concurrent.ArrayBlockingQueue; import java.util.concurrent.ExecutorService; -import java.util.concurrent.ThreadPoolExecutor; -import java.util.concurrent.TimeUnit; import org.eclipse.jgit.lib.Config; /** @@ -73,28 +67,4 @@ public class SysExecutorModule extends AbstractModule { } return queues.createQueue(poolSize, "FanOut"); } - - @Provides - @Singleton - @ChangeUpdateExecutor - public ListeningExecutorService createChangeUpdateExecutor(@GerritServerConfig Config config) { - int poolSize = config.getInt("receive", null, "changeUpdateThreads", 1); - if (poolSize <= 1) { - return MoreExecutors.newDirectExecutorService(); - } - return MoreExecutors.listeningDecorator( - new LoggingContextAwareExecutorService( - MoreExecutors.getExitingExecutorService( - new ThreadPoolExecutor( - 1, - poolSize, - 10, - TimeUnit.MINUTES, - new ArrayBlockingQueue<>(poolSize), - new ThreadFactoryBuilder() - .setNameFormat("ChangeUpdate-%d") - .setDaemon(true) - .build(), - new ThreadPoolExecutor.CallerRunsPolicy())))); - } } diff --git a/java/com/google/gerrit/testing/InMemoryModule.java b/java/com/google/gerrit/testing/InMemoryModule.java index af9d8c3925..baccbf9de4 100644 --- a/java/com/google/gerrit/testing/InMemoryModule.java +++ b/java/com/google/gerrit/testing/InMemoryModule.java @@ -18,7 +18,6 @@ import static com.google.common.base.Preconditions.checkState; import static com.google.inject.Scopes.SINGLETON; import com.google.common.base.Strings; -import com.google.common.util.concurrent.ListeningExecutorService; import com.google.common.util.concurrent.MoreExecutors; import com.google.gerrit.acceptance.testsuite.project.ProjectOperations; import com.google.gerrit.acceptance.testsuite.project.ProjectOperationsImpl; @@ -48,7 +47,6 @@ import com.google.gerrit.server.config.AnonymousCowardName; import com.google.gerrit.server.config.AnonymousCowardNameProvider; import com.google.gerrit.server.config.CanonicalWebUrlModule; import com.google.gerrit.server.config.CanonicalWebUrlProvider; -import com.google.gerrit.server.config.ChangeUpdateExecutor; import com.google.gerrit.server.config.DefaultUrlFormatter; import com.google.gerrit.server.config.GerritGlobalModule; import com.google.gerrit.server.config.GerritInstanceNameModule; @@ -186,9 +184,6 @@ public class InMemoryModule extends FactoryModule { bind(GitRepositoryManager.class).to(InMemoryRepositoryManager.class); bind(InMemoryRepositoryManager.class).in(SINGLETON); bind(TrackingFooters.class).toProvider(TrackingFootersProvider.class).in(SINGLETON); - bind(ListeningExecutorService.class) - .annotatedWith(ChangeUpdateExecutor.class) - .toInstance(MoreExecutors.newDirectExecutorService()); bind(SecureStore.class).to(DefaultSecureStore.class); install(new InMemorySchemaModule());