opendev/gerrit
Code Issues Proposed changes

Rename change constants and messages classes

Browse Source 
This makes them more consistent with the naming of constants and
messages classes in other packages.

Also since the class names are no longer the same as the GWT base
interfaces, we don't need to explicitly specify the class names
in the declarations.

Change-Id: I7adcbd16625e5c60ea996e1372997002abcffab0
This commit is contained in:
David Pursehouse 2014-06-02 15:42:03 +09:00
parent 58bc313b0c
commit 6c9da6d836
5 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Constants.java → gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeConstants.java
View File

@ -14,7 +14,9 @@
package com.google.gerrit.client.change;
interface Constants extends com.google.gwt.i18n.client.Constants {
import com.google.gwt.i18n.client.Constants;
interface ChangeConstants extends Constants {
String previousChange();
String nextChange();
String openChange();

0
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Constants.properties → gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeConstants.properties
View File

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Messages.java → gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeMessages.java
View File

@ -14,7 +14,9 @@
package com.google.gerrit.client.change;
public interface Messages extends com.google.gwt.i18n.client.Messages {
import com.google.gwt.i18n.client.Messages;
public interface ChangeMessages extends Messages {
String patchSets(int currentlyViewedPatchSet, int currentPatchSet);
String changeWithNoRevisions(int changeId);
String relatedChanges(int count);

0
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Messages.properties → gerrit-gwtui/src/main/java/com/google/gerrit/client/change/ChangeMessages.properties
View File

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Resources.java
View File

@ -21,8 +21,8 @@ import com.google.gwt.resources.client.ImageResource;
public interface Resources extends ClientBundle {
public static final Resources I = GWT.create(Resources.class);
static final Constants C = GWT.create(Constants.class);
static final Messages M = GWT.create(Messages.class);
static final ChangeConstants C = GWT.create(ChangeConstants.class);
static final ChangeMessages M = GWT.create(ChangeMessages.class);
@Source("star_open.png") ImageResource star_open();
@Source("star_filled.png") ImageResource star_filled();