Fix some warnings raised by CheckStyle
- Change ordering of 'static', 'final', etc modifiers according to the order suggested by JLS. - Add comments in empty catch blocks for intentionally ignored exceptions. - Add curly braces around if-else blocks. - Move `catch` to same line as closing brace of preceding `try` blocks. - Wrap long lines. Note that this change does not fix all instances of the above errors across the entire code base. Change-Id: I24bb9649cc5013c249fa5d84e05322a5cdf2ace6
This commit is contained in:
@@ -96,7 +96,7 @@ public final class Plugin extends JavaScriptObject {
|
||||
|
||||
native void _initialized() /*-{ this._success = true }-*/;
|
||||
native void _loaded() /*-{ this._loadedGwt() }-*/;
|
||||
private static native final Plugin install(String u)
|
||||
private static final native Plugin install(String u)
|
||||
/*-{ return $wnd.Gerrit.installGwt(u) }-*/;
|
||||
|
||||
private static final native JavaScriptObject wrap(Screen.EntryPoint b) /*-{
|
||||
|
@@ -109,7 +109,7 @@ public class RestApi {
|
||||
get(NativeString.unwrap(cb));
|
||||
}
|
||||
|
||||
private native static void get(String p, JavaScriptObject r)
|
||||
private static native void get(String p, JavaScriptObject r)
|
||||
/*-{ $wnd.Gerrit.get(p, r) }-*/;
|
||||
|
||||
public <T extends JavaScriptObject>
|
||||
@@ -117,7 +117,7 @@ public class RestApi {
|
||||
put(path(), wrap(cb));
|
||||
}
|
||||
|
||||
private native static void put(String p, JavaScriptObject r)
|
||||
private static native void put(String p, JavaScriptObject r)
|
||||
/*-{ $wnd.Gerrit.put(p, r) }-*/;
|
||||
|
||||
public <T extends JavaScriptObject>
|
||||
@@ -125,7 +125,7 @@ public class RestApi {
|
||||
put(path(), content, wrap(cb));
|
||||
}
|
||||
|
||||
private native static
|
||||
private static native
|
||||
void put(String p, String c, JavaScriptObject r)
|
||||
/*-{ $wnd.Gerrit.put(p, c, r) }-*/;
|
||||
|
||||
@@ -134,7 +134,7 @@ public class RestApi {
|
||||
put(path(), content, wrap(cb));
|
||||
}
|
||||
|
||||
private native static
|
||||
private static native
|
||||
void put(String p, JavaScriptObject c, JavaScriptObject r)
|
||||
/*-{ $wnd.Gerrit.put(p, c, r) }-*/;
|
||||
|
||||
@@ -143,7 +143,7 @@ public class RestApi {
|
||||
post(path(), content, wrap(cb));
|
||||
}
|
||||
|
||||
private native static
|
||||
private static native
|
||||
void post(String p, String c, JavaScriptObject r)
|
||||
/*-{ $wnd.Gerrit.post(p, c, r) }-*/;
|
||||
|
||||
@@ -152,7 +152,7 @@ public class RestApi {
|
||||
post(path(), content, wrap(cb));
|
||||
}
|
||||
|
||||
private native static
|
||||
private static native
|
||||
void post(String p, JavaScriptObject c, JavaScriptObject r)
|
||||
/*-{ $wnd.Gerrit.post(p, c, r) }-*/;
|
||||
|
||||
@@ -160,10 +160,10 @@ public class RestApi {
|
||||
delete(path(), wrap(cb));
|
||||
}
|
||||
|
||||
private native static void delete(String p, JavaScriptObject r)
|
||||
private static native void delete(String p, JavaScriptObject r)
|
||||
/*-{ $wnd.Gerrit.del(p, r) }-*/;
|
||||
|
||||
private native static <T extends JavaScriptObject>
|
||||
private static native <T extends JavaScriptObject>
|
||||
JavaScriptObject wrap(AsyncCallback<T> b) /*-{
|
||||
return function(r) {
|
||||
b.@com.google.gwt.user.client.rpc.AsyncCallback::onSuccess(Ljava/lang/Object;)(r)
|
||||
|
Reference in New Issue
Block a user