opendev/gerrit
Code Issues Proposed changes

Remove all unneeded checks of primary storage of a change

Browse Source 
There is a remaining usage in ChangeUpdate which requires more work. It
already has a TODO.

Change-Id: I259f9740d1ca8c8af531b8ac61d392af98261971
Signed-off-by: Edwin Kempin <ekempin@google.com>
This commit is contained in:
Edwin Kempin
2018-12-13 11:34:30 +01:00
committed by Dave Borowitz
parent 758600436c
commit 6d82df9bbb
11 changed files with 21 additions and 234 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
java/com/google/gerrit/server/change/RebaseChangeOp.java
View File

@@ -71,7 +71,6 @@ public class RebaseChangeOp implements BatchUpdateOp {
private boolean validate = true;
private boolean checkAddPatchSetPermission = true;
private boolean forceContentMerge;
private boolean copyApprovals = true;
private boolean detailedCommitMessage;
private boolean postMessage = true;
private boolean matchAuthorToCommitterDate = false;
@@ -128,11 +127,6 @@ public class RebaseChangeOp implements BatchUpdateOp {
return this;
}
public RebaseChangeOp setCopyApprovals(boolean copyApprovals) {
this.copyApprovals = copyApprovals;
return this;
}
public RebaseChangeOp setDetailedCommitMessage(boolean detailedCommitMessage) {
this.detailedCommitMessage = detailedCommitMessage;
return this;
@@ -189,7 +183,6 @@ public class RebaseChangeOp implements BatchUpdateOp {
.setDescription("Rebase")
.setNotify(NotifyHandling.NONE)
.setFireRevisionCreated(fireRevisionCreated)
.setCopyApprovals(copyApprovals)
.setCheckAddPatchSetPermission(checkAddPatchSetPermission)
.setValidate(validate);
if (postMessage) {