opendev/gerrit
Code Issues Proposed changes

Show Status column header on the SSH key table

Browse Source 
This way its clear what this empty area is... its the status of the
key as far as the server knows it.

Change-Id: If15a838af9eb8f11a1a9b034d7a7414a30d96d9f
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2010-01-15 16:17:39 -08:00
parent fa29f879ae
commit 6e846566d6
3 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-gwtui/src/main/java/com/google/gerrit/client/account/AccountConstants.java
View File

@@ -53,6 +53,7 @@ public interface AccountConstants extends Constants {
String sshKeyAlgorithm();
String sshKeyKey();
String sshKeyComment();
String sshKeyStatus();
String addSshKeyPanelHeader();
String addSshKeyHelp();

1
gerrit-gwtui/src/main/java/com/google/gerrit/client/account/AccountConstants.properties
View File

@@ -33,6 +33,7 @@ sshKeyInvalid = Invalid Key
sshKeyAlgorithm = Algorithm
sshKeyKey = Key
sshKeyComment = Comment
sshKeyStatus = Status
sshHostKeyTitle = Server Host Key
sshHostKeyFingerprint = Fingerprint:

9
gerrit-gwtui/src/main/java/com/google/gerrit/client/account/SshPanel.java
View File

@@ -527,6 +527,7 @@ class SshPanel extends Composite {
private class SshKeyTable extends FancyFlexTable<AccountSshKey> {
SshKeyTable() {
table.setWidth("");
table.setText(0, 2, Util.C.sshKeyStatus());
table.setText(0, 3, Util.C.sshKeyAlgorithm());
table.setText(0, 4, Util.C.sshKeyKey());
table.setText(0, 5, Util.C.sshKeyComment());
@@ -584,9 +585,8 @@ class SshPanel extends Composite {
table.setWidget(row, 1, new CheckBox());
if (k.isValid()) {
table.setText(row, 2, "");
fmt
.removeStyleName(row, 2, Gerrit.RESOURCES.css()
.sshKeyPanelInvalid());
fmt.removeStyleName(row, 2, //
Gerrit.RESOURCES.css().sshKeyPanelInvalid());
} else {
table.setText(row, 2, Util.C.sshKeyInvalid());
fmt.addStyleName(row, 2, Gerrit.RESOURCES.css().sshKeyPanelInvalid());
@@ -596,9 +596,8 @@ class SshPanel extends Composite {
table.setText(row, 5, k.getComment());
fmt.addStyleName(row, 1, Gerrit.RESOURCES.css().iconCell());
fmt.addStyleName(row, 2, Gerrit.RESOURCES.css().iconCell());
fmt.addStyleName(row, 4, Gerrit.RESOURCES.css().sshKeyPanelEncodedKey());
for (int c = 3; c <= 5; c++) {
for (int c = 2; c <= 5; c++) {
fmt.addStyleName(row, c, Gerrit.RESOURCES.css().dataCell());
}