opendev/gerrit
Code Issues Proposed changes

RepoSequence: Remove unused increaseTo(int) method

Browse Source 
This method was only used to update the sequence in NoteDb when the
sequence was read from ReviewDb. The ReviewDb code is gone and hence
this method is no longer used.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I34d78ee0237f1b215c8f304fa72760b469e2cd72
This commit is contained in:
Edwin Kempin
2019-06-11 13:21:44 +02:00
parent 3977ad2795
commit 6f0e3ae683
2 changed files with 0 additions and 147 deletions
Download Patch File Download Diff File Expand all files Collapse all files

57
java/com/google/gerrit/server/notedb/RepoSequence.java
View File

@@ -238,31 +238,6 @@ public class RepoSequence {
}
}
public void increaseTo(int val) {
counterLock.lock();
try {
try (Repository repo = repoManager.openRepository(projectName);
RevWalk rw = new RevWalk(repo)) {
TryIncreaseTo attempt = new TryIncreaseTo(repo, rw, val);
RefUpdate ru = retryer.call(attempt);
// Null update is a sentinel meaning nothing to do.
if (ru != null) {
RefUpdateUtil.checkResult(ru);
}
counter = limit;
} catch (ExecutionException | RetryException e) {
if (e.getCause() != null) {
Throwables.throwIfInstanceOf(e.getCause(), StorageException.class);
}
throw new StorageException(e);
} catch (IOException e) {
throw new StorageException(e);
}
} finally {
counterLock.unlock();
}
}
private void acquire(int count) {
try (Repository repo = repoManager.openRepository(projectName);
RevWalk rw = new RevWalk(repo)) {
@@ -311,38 +286,6 @@ public class RepoSequence {
}
}
private class TryIncreaseTo implements Callable<RefUpdate> {
private final Repository repo;
private final RevWalk rw;
private final int value;
private TryIncreaseTo(Repository repo, RevWalk rw, int value) {
this.repo = repo;
this.rw = rw;
this.value = value;
}
@Override
public RefUpdate call() throws Exception {
Optional<IntBlob> blob = IntBlob.parse(repo, refName, rw);
afterReadRef.run();
ObjectId oldId;
if (!blob.isPresent()) {
oldId = ObjectId.zeroId();
} else {
oldId = blob.get().id();
int next = blob.get().value();
if (next >= value) {
// A concurrent write updated the ref already to this or a higher value; return null as a
// sentinel meaning nothing to do. Returning RefUpdate doesn't give us the flexibility to
// return any other kind of sentinel, since it's a fairly thick object.
return null;
}
}
return IntBlob.tryStore(repo, rw, projectName, refName, oldId, value, gitRefUpdated);
}
}
public static ReceiveCommand storeNew(ObjectInserter ins, String name, int val)
throws IOException {
ObjectId newId = ins.insert(OBJ_BLOB, Integer.toString(val).getBytes(UTF_8));