opendev/gerrit
Code Issues Proposed changes

Update approvals table when adding reviewer.

Browse Source 
Fixed a bug where the Approvals table wasn't updating after adding a
reviewer, which made it difficult to see if the add actually worked.

Signed-off-by: Brad Larson <bklarson@gmail.com>
This commit is contained in:
Brad Larson
2009-02-13 21:47:43 -06:00
parent 0b25c969e2
commit 6f334ea427
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/main/java/com/google/gerrit/client/changes/ApprovalTable.java
View File

@@ -19,6 +19,7 @@ import com.google.gerrit.client.SignedInListener;
import com.google.gerrit.client.data.AccountInfoCache;
import com.google.gerrit.client.data.ApprovalDetail;
import com.google.gerrit.client.data.ApprovalType;
import com.google.gerrit.client.data.ChangeDetail;
import com.google.gerrit.client.patches.PatchUtil;
import com.google.gerrit.client.reviewdb.Account;
import com.google.gerrit.client.reviewdb.ApprovalCategory;
@@ -27,6 +28,7 @@ import com.google.gerrit.client.reviewdb.Change;
import com.google.gerrit.client.reviewdb.ChangeApproval;
import com.google.gerrit.client.rpc.Common;
import com.google.gerrit.client.rpc.GerritCallback;
import com.google.gerrit.client.rpc.ScreenLoadCallback;
import com.google.gerrit.client.ui.AccountDashboardLink;
import com.google.gerrit.client.ui.AddMemberBox;
import com.google.gwt.user.client.ui.ClickListener;
@@ -204,6 +206,16 @@ public class ApprovalTable extends Composite {
public void onSuccess(final VoidResult result) {
addMemberBox.setEnabled(true);
addMemberBox.setText("");
Util.DETAIL_SVC.changeDetail(changeId,
new ScreenLoadCallback<ChangeDetail>() {
public void onSuccess(final ChangeDetail r) {
if (isAttached()) {
setAccountInfoCache(r.getAccounts());
display(r.getChange(), r.getMissingApprovals(), r
.getApprovals());
}
}
});
}
@Override