opendev/gerrit
Code Issues Proposed changes

Revert "Upgrade soy to 2020-08-24"

Browse Source 
This reverts commit bcdbc45e85.

Han-Wen reported this soy version to show performance issues in Gerrit:

"Google is tracking this internally as b/176094888; hopefully we can get
it fixed in Soy proper.

The problem is that template rendering went from 9ms to 30ms. We render
quite a few templates for a single email, so adds ~120ms to each
operation that sends out an email.

It looks like this caused a significant slowdown on the benchmark under
contrib/benchmark-createchange.go (using reftable as refstorage)."

Hence reverting this update until it's fixed upstream.

See https://gerrit-review.googlesource.com/c/gerrit/+/280196

Change-Id: Id98a5d93e316268e086cf6aa2be514a586dd3eee
This commit is contained in:
Matthias Sohn
2020-12-29 10:33:13 +01:00
parent 4600b1ed6e
commit 6fb02b5137
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
WORKSPACE
View File

@@ -752,8 +752,8 @@ maven_jar(
# Keep this version of Soy synchronized with the version used in Gitiles.
maven_jar(
name = "soy",
artifact = "com.google.template:soy:2020-08-24",
sha1 = "e774bf5cc95923d2685292883fe219e231346e50",
artifact = "com.google.template:soy:2019-10-08",
sha1 = "4518bf8bac2dbbed684849bc209c39c4cb546237",
)
maven_jar(