opendev/gerrit
Code Issues Proposed changes

DashboardIT: Fix dashboard name in dashboardDoesNotExist test

Browse Source 
The test was passing, but for the wrong reason. The expected format
of the dashboard name is "ref:name" and if the given dashboard does
not match that, 404 is returned.

The test was using the name "dashboard" which caused a 404 response
as mentioned above.

Change the dashboard name to "my:dashboard". The 404 is still
returned, but now for the correct reason.

Change-Id: I5bd5567be26d04f093df173c239fd3149585e163
This commit is contained in:
David Pursehouse
2017-09-19 19:31:24 +09:00
parent 3f956041ef
commit 701cbe3eec
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/project/DashboardIT.java
View File

@@ -30,6 +30,6 @@ public class DashboardIT extends AbstractDaemonTest {
@Test
public void dashboardDoesNotExist() throws Exception {
exception.expect(ResourceNotFoundException.class);
gApi.projects().name(project.get()).dashboard("dashboard").get();
gApi.projects().name(project.get()).dashboard("my:dashboard").get();
}
}