Admin-Project UI page accessible to users

Make the Admin->Projects page in the UI available to non-admin users.
The page will only show projects in which the user has read access.

Change-Id: I803609da4631cf037ba8b667ec927d1f9e3f8620

gerrit-common/src/main/java/com/google/gerrit/common/data/InheritedRefRight.java

@@ -23,6 +23,7 @@ import com.google.gerrit.reviewdb.RefRight;
 public class InheritedRefRight {
   private RefRight right;
   private boolean inherited;
+  private boolean owner;
 
   /**
    * Creates a instance of a {@link RefRight} with data about inheritance
@@ -35,10 +36,12 @@ public class InheritedRefRight {
    *
    * @param right the right
    * @param inherited true if the right is inherited, false otherwise
+   * @param owner true if right is owned by current user, false otherwise
    */
-  public InheritedRefRight(RefRight right, boolean inherited) {
+  public InheritedRefRight(RefRight right, boolean inherited, boolean owner) {
     this.right = right;
     this.inherited = inherited;
+    this.owner = owner;
   }
 
   public RefRight getRight() {
@@ -49,6 +52,10 @@ public class InheritedRefRight {
     return inherited;
   }
 
+  public boolean isOwner() {
+    return owner;
+  }
+
   @Override
   public boolean equals(Object o) {
     if (o instanceof InheritedRefRight) {

gerrit-common/src/main/java/com/google/gerrit/common/data/ListBranchesResult.java

@@ -0,0 +1,53 @@
+// Copyright (C) 2010 The Android Open Source Project
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package com.google.gerrit.common.data;
+
+import com.google.gerrit.reviewdb.Branch;
+
+import java.util.List;
+
+/**
+ * It holds list of branches and boolean to indicate
+ * if it is allowed to add new branches.
+ */
+public final class ListBranchesResult {
+  protected boolean canAdd;
+
+  protected List<Branch> branches;
+
+  protected ListBranchesResult() {
+  }
+
+  public ListBranchesResult(final List<Branch> branches, boolean canAdd) {
+    this.branches = branches;
+    this.canAdd = canAdd;
+  }
+
+  public boolean getCanAdd() {
+    return canAdd;
+  }
+
+  public void setCanAdd(boolean canAdd) {
+    this.canAdd = canAdd;
+  }
+
+  public List<Branch> getBranches() {
+    return branches;
+  }
+
+  public void setBranches(List<Branch> branches) {
+    this.branches = branches;
+  }
+}

gerrit-common/src/main/java/com/google/gerrit/common/data/ProjectAdminService.java

@@ -22,7 +22,6 @@ import com.google.gerrit.reviewdb.RefRight;
 import com.google.gwt.user.client.rpc.AsyncCallback;
 import com.google.gwtjsonrpc.client.RemoteJsonService;
 import com.google.gwtjsonrpc.client.RpcImpl;
-import com.google.gwtjsonrpc.client.VoidResult;
 import com.google.gwtjsonrpc.client.RpcImpl.Version;
 
 import java.util.List;
@@ -31,7 +30,7 @@ import java.util.Set;
 @RpcImpl(version = Version.V2_0)
 public interface ProjectAdminService extends RemoteJsonService {
   @SignInRequired
-  void ownedProjects(AsyncCallback<List<Project>> callback);
+  void visibleProjects(AsyncCallback<List<Project>> callback);
 
   @SignInRequired
   void projectDetail(Project.NameKey projectName,
@@ -43,7 +42,7 @@ public interface ProjectAdminService extends RemoteJsonService {
 
   @SignInRequired
   void deleteRight(Project.NameKey projectName, Set<RefRight.Key> ids,
-      AsyncCallback<VoidResult> callback);
+      AsyncCallback<ProjectDetail> callback);
 
   @SignInRequired
   void addRight(Project.NameKey projectName, ApprovalCategory.Id categoryId,
@@ -52,11 +51,11 @@ public interface ProjectAdminService extends RemoteJsonService {
 
   @SignInRequired
   void listBranches(Project.NameKey projectName,
-      AsyncCallback<List<Branch>> callback);
+      AsyncCallback<ListBranchesResult> callback);
 
   @SignInRequired
   void addBranch(Project.NameKey projectName, String branchName,
-      String startingRevision, AsyncCallback<List<Branch>> callback);
+      String startingRevision, AsyncCallback<ListBranchesResult> callback);
 
   @SignInRequired
   void deleteBranch(Project.NameKey projectName, Set<Branch.NameKey> ids,

gerrit-common/src/main/java/com/google/gerrit/common/data/ProjectDetail.java

@@ -24,6 +24,10 @@ public class ProjectDetail {
   public Project project;
   public Map<AccountGroup.Id, AccountGroup> groups;
   public List<InheritedRefRight> rights;
+  public boolean canModifyDescription;
+  public boolean canModifyMergeType;
+  public boolean canModifyAgreements;
+  public boolean canModifyAccess;
 
   public ProjectDetail() {
   }
@@ -39,4 +43,20 @@ public class ProjectDetail {
   public void setRights(final List<InheritedRefRight> r) {
     rights = r;
   }
+
+  public void setCanModifyDescription(final boolean cmd) {
+    canModifyDescription = cmd;
+  }
+
+  public void setCanModifyMergeType(final boolean cmmt) {
+    canModifyMergeType = cmmt;
+  }
+
+  public void setCanModifyAgreements(final boolean cma) {
+    canModifyAgreements = cma;
+  }
+
+  public void setCanModifyAccess(final boolean cma) {
+    canModifyAccess = cma;
+  }
 }

gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectBranchesPanel.java

@@ -17,6 +17,7 @@ package com.google.gerrit.client.admin;
 import com.google.gerrit.client.Gerrit;
 import com.google.gerrit.client.rpc.GerritCallback;
 import com.google.gerrit.client.ui.FancyFlexTable;
+import com.google.gerrit.common.data.ListBranchesResult;
 import com.google.gerrit.common.data.GitwebLink;
 import com.google.gerrit.common.errors.InvalidNameException;
 import com.google.gerrit.common.errors.InvalidRevisionException;
@@ -57,6 +58,8 @@ public class ProjectBranchesPanel extends Composite {
   private NpTextBox nameTxtBox;
   private NpTextBox irevTxtBox;
 
+  private final FlowPanel addPanel = new FlowPanel();
+
   public ProjectBranchesPanel(final Project.NameKey toShow) {
     final FlowPanel body = new FlowPanel();
     initBranches(body);
@@ -71,14 +74,20 @@ public class ProjectBranchesPanel extends Composite {
     super.onLoad();
 
     Util.PROJECT_SVC.listBranches(projectName,
-        new GerritCallback<List<Branch>>() {
+        new GerritCallback<ListBranchesResult>() {
-          public void onSuccess(final List<Branch> result) {
+          public void onSuccess(final ListBranchesResult result) {
             enableForm(true);
-            branches.display(result);
+            display(result.getBranches());
+            addPanel.setVisible(result.getCanAdd());
           }
         });
   }
 
+  private void display(final List<Branch> listBranches) {
+    branches.display(listBranches);
+    delBranch.setVisible(branches.hasBranchCanDelete());
+  }
+
   private void enableForm(final boolean on) {
     delBranch.setEnabled(on);
     addBranch.setEnabled(on);
@@ -87,7 +96,6 @@ public class ProjectBranchesPanel extends Composite {
   }
 
   private void initBranches(final Panel body) {
-    final FlowPanel addPanel = new FlowPanel();
     addPanel.setStyleName(Gerrit.RESOURCES.css().addSshKeyPanel());
 
     final Grid addGrid = new Grid(2, 2);
@@ -209,12 +217,12 @@ public class ProjectBranchesPanel extends Composite {
 
     addBranch.setEnabled(false);
     Util.PROJECT_SVC.addBranch(projectName, branchName, rev,
-        new GerritCallback<List<Branch>>() {
+        new GerritCallback<ListBranchesResult>() {
-          public void onSuccess(final List<Branch> result) {
+          public void onSuccess(final ListBranchesResult result) {
             addBranch.setEnabled(true);
             nameTxtBox.setText("");
             irevTxtBox.setText("");
-            branches.display(result);
+            display(result.getBranches());
           }
 
           @Override
@@ -239,6 +247,8 @@ public class ProjectBranchesPanel extends Composite {
   }
 
   private class BranchesTable extends FancyFlexTable<Branch> {
+    boolean canDelete;
+
     BranchesTable() {
       table.setWidth("");
       table.setText(0, 2, Util.C.columnBranchName());
@@ -282,6 +292,8 @@ public class ProjectBranchesPanel extends Composite {
     }
 
     void display(final List<Branch> result) {
+      canDelete = false;
+
       while (1 < table.getRowCount())
         table.removeRow(table.getRowCount() - 1);
 
@@ -296,7 +308,13 @@ public class ProjectBranchesPanel extends Composite {
     void populate(final int row, final Branch k) {
       final GitwebLink c = Gerrit.getConfig().getGitwebLink();
 
+      if (k.getCanDelete()) {
         table.setWidget(row, 1, new CheckBox());
+        canDelete = true;
+      } else {
+        table.setText(row, 1, "");
+      }
+
       table.setText(row, 2, k.getShortName());
 
       if (k.getRevision() != null) {
@@ -320,5 +338,9 @@ public class ProjectBranchesPanel extends Composite {
 
       setRowItem(row, k);
     }
+
+    boolean hasBranchCanDelete() {
+      return canDelete;
+    }
   }
 }

gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectInfoPanel.java

@@ -70,7 +70,7 @@ public class ProjectInfoPanel extends Composite {
 
   @Override
   protected void onLoad() {
-    enableForm(false);
+    enableForm(false, false, false);
     saveProject.setEnabled(false);
     super.onLoad();
     refresh();
@@ -80,18 +80,26 @@ public class ProjectInfoPanel extends Composite {
     Util.PROJECT_SVC.projectDetail(projectName,
         new GerritCallback<ProjectDetail>() {
           public void onSuccess(final ProjectDetail result) {
-            enableForm(true);
+            enableForm(result.canModifyAgreements,
+                result.canModifyDescription, result.canModifyMergeType);
+            saveProject.setVisible(
+                result.canModifyAgreements ||
+                result.canModifyDescription ||
+                result.canModifyMergeType);
             saveProject.setEnabled(false);
             display(result);
           }
         });
   }
 
-  private void enableForm(final boolean on) {
+  private void enableForm(final boolean canModifyAgreements,
-    submitType.setEnabled(on);
+      final boolean canModifyDescription, final boolean canModifyMergeType) {
-    descTxt.setEnabled(on);
+    submitType.setEnabled(canModifyMergeType);
-    useContributorAgreements.setEnabled(on);
+    descTxt.setEnabled(canModifyDescription);
-    useSignedOffBy.setEnabled(on);
+    useContributorAgreements.setEnabled(canModifyAgreements);
+    useSignedOffBy.setEnabled(canModifyAgreements);
+    saveProject.setEnabled(
+        canModifyAgreements || canModifyDescription || canModifyMergeType);
   }
 
   private void initDescription(final Panel body) {
@@ -185,13 +193,14 @@ public class ProjectInfoPanel extends Composite {
           .getValue(submitType.getSelectedIndex())));
     }
 
-    enableForm(false);
+    enableForm(false, false, false);
     saveProject.setEnabled(false);
 
     Util.PROJECT_SVC.changeProjectSettings(project,
         new GerritCallback<ProjectDetail>() {
           public void onSuccess(final ProjectDetail result) {
-            enableForm(true);
+            enableForm(result.canModifyAgreements,
+                result.canModifyDescription, result.canModifyMergeType);
             display(result);
           }
 

gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectListScreen.java

@@ -39,7 +39,7 @@ public class ProjectListScreen extends AccountScreen {
   @Override
   protected void onLoad() {
     super.onLoad();
-    Util.PROJECT_SVC.ownedProjects(new ScreenLoadCallback<List<Project>>(this) {
+    Util.PROJECT_SVC.visibleProjects(new ScreenLoadCallback<List<Project>>(this) {
       @Override
       protected void preDisplay(final List<Project> result) {
         projects.display(result);

gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectRightsPanel.java

@@ -54,7 +54,6 @@ import com.google.gwt.user.client.ui.FlexTable.FlexCellFormatter;
 import com.google.gwtexpui.globalkey.client.NpTextBox;
 import com.google.gwtexpui.safehtml.client.SafeHtml;
 import com.google.gwtexpui.safehtml.client.SafeHtmlBuilder;
-import com.google.gwtjsonrpc.client.VoidResult;
 
 import java.util.HashSet;
 import java.util.List;
@@ -76,6 +75,8 @@ public class ProjectRightsPanel extends Composite {
   private SuggestBox nameTxt;
   private NpTextBox referenceTxt;
 
+  private final FlowPanel addPanel = new FlowPanel();
+
   public ProjectRightsPanel(final Project.NameKey toShow) {
     projectName = toShow;
 
@@ -121,7 +122,6 @@ public class ProjectRightsPanel extends Composite {
   }
 
   private void initRights(final Panel body) {
-    final FlowPanel addPanel = new FlowPanel();
     addPanel.setStyleName(Gerrit.RESOURCES.css().addSshKeyPanel());
 
     final Grid addGrid = new Grid(5, 2);
@@ -223,7 +223,8 @@ public class ProjectRightsPanel extends Composite {
     delRight.addClickHandler(new ClickHandler() {
       @Override
       public void onClick(final ClickEvent event) {
-        rights.deleteChecked();
+        final HashSet<RefRight.Key> refRightIds = rights.getRefRightIdsChecked();
+        doDeleteRefRights(refRightIds);
       }
     });
 
@@ -254,6 +255,22 @@ public class ProjectRightsPanel extends Composite {
     parentName.setText(parent.get());
 
     rights.display(result.groups, result.rights);
+
+    addPanel.setVisible(result.canModifyAccess);
+    delRight.setVisible(rights.getCanDelete());
+  }
+
+  private void doDeleteRefRights(final HashSet<RefRight.Key> refRightIds) {
+    if (!refRightIds.isEmpty()) {
+      Util.PROJECT_SVC.deleteRight(projectName, refRightIds,
+          new GerritCallback<ProjectDetail>() {
+        @Override
+        public void onSuccess(final ProjectDetail result) {
+          //The user could no longer modify access after deleting a ref right.
+          display(result);
+        }
+      });
+    }
   }
 
   private void doAddNewRight() {
@@ -393,6 +410,8 @@ public class ProjectRightsPanel extends Composite {
   }
 
   private class RightsTable extends FancyFlexTable<RefRight> {
+    boolean canDelete;
+
     RightsTable() {
       table.setWidth("");
       table.setText(0, 2, Util.C.columnApprovalCategory());
@@ -408,7 +427,7 @@ public class ProjectRightsPanel extends Composite {
       fmt.addStyleName(0, 5, Gerrit.RESOURCES.css().dataHeader());
     }
 
-    void deleteChecked() {
+    HashSet<RefRight.Key> getRefRightIdsChecked() {
       final HashSet<RefRight.Key> refRightIds = new HashSet<RefRight.Key>();
       for (int row = 1; row < table.getRowCount(); row++) {
         RefRight r = getRowItem(row);
@@ -417,28 +436,13 @@ public class ProjectRightsPanel extends Composite {
           refRightIds.add(r.getKey());
         }
       }
-
+      return refRightIds;
-      GerritCallback<VoidResult> updateTable =
-          new GerritCallback<VoidResult>() {
-            @Override
-            public void onSuccess(final VoidResult result) {
-              for (int row = 1; row < table.getRowCount();) {
-                RefRight r = getRowItem(row);
-                if (r != null && refRightIds.contains(r.getKey())) {
-                  table.removeRow(row);
-                } else {
-                  row++;
-                }
-              }
-            }
-          };
-      if (!refRightIds.isEmpty()) {
-        Util.PROJECT_SVC.deleteRight(projectName, refRightIds, updateTable);
-      }
     }
 
     void display(final Map<AccountGroup.Id, AccountGroup> groups,
         final List<InheritedRefRight> refRights) {
+      canDelete = false;
+
       while (1 < table.getRowCount())
         table.removeRow(table.getRowCount() - 1);
 
@@ -450,8 +454,7 @@ public class ProjectRightsPanel extends Composite {
       }
     }
 
-    void populate(final int row,
+    void populate(final int row, final Map<AccountGroup.Id, AccountGroup> groups,
-        final Map<AccountGroup.Id, AccountGroup> groups,
         final InheritedRefRight r) {
       final GerritConfig config = Gerrit.getConfig();
       final RefRight right = r.getRight();
@@ -460,10 +463,11 @@ public class ProjectRightsPanel extends Composite {
               right.getApprovalCategoryId());
       final AccountGroup group = groups.get(right.getAccountGroupId());
 
-      if (r.isInherited()) {
+      if (r.isInherited() || !r.isOwner()) {
         table.setText(row, 1, "");
       } else {
         table.setWidget(row, 1, new CheckBox());
+        canDelete = true;
       }
 
       if (ar != null) {
@@ -525,5 +529,9 @@ public class ProjectRightsPanel extends Composite {
         m.append(e.getName());
       }
     }
+
+    private boolean getCanDelete() {
+      return canDelete;
+    }
   }
 }

gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/AddBranch.java

@@ -14,6 +14,7 @@
 
 package com.google.gerrit.httpd.rpc.project;
 
+import com.google.gerrit.common.data.ListBranchesResult;
 import com.google.gerrit.common.errors.InvalidNameException;
 import com.google.gerrit.common.errors.InvalidRevisionException;
 import com.google.gerrit.httpd.rpc.Handler;
@@ -42,9 +43,8 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 import java.io.IOException;
-import java.util.List;
 
-class AddBranch extends Handler<List<Branch>> {
+class AddBranch extends Handler<ListBranchesResult> {
   private static final Logger log = LoggerFactory.getLogger(AddBranch.class);
 
   interface Factory {
@@ -85,7 +85,7 @@ class AddBranch extends Handler<List<Branch>> {
   }
 
   @Override
-  public List<Branch> call() throws NoSuchProjectException,
+  public ListBranchesResult call() throws NoSuchProjectException,
       InvalidNameException, InvalidRevisionException, IOException {
     final ProjectControl projectControl =
         projectControlFactory.controlFor(projectName);

gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/DeleteRefRights.java

@@ -14,6 +14,7 @@
 
 package com.google.gerrit.httpd.rpc.project;
 
+import com.google.gerrit.common.data.ProjectDetail;
 import com.google.gerrit.httpd.rpc.Handler;
 import com.google.gerrit.reviewdb.Project;
 import com.google.gerrit.reviewdb.RefRight;
@@ -23,7 +24,6 @@ import com.google.gerrit.server.project.NoSuchRefException;
 import com.google.gerrit.server.project.ProjectCache;
 import com.google.gerrit.server.project.ProjectControl;
 import com.google.gerrit.server.project.RefControl;
-import com.google.gwtjsonrpc.client.VoidResult;
 import com.google.gwtorm.client.OrmException;
 import com.google.inject.Inject;
 import com.google.inject.assistedinject.Assisted;
@@ -31,12 +31,13 @@ import com.google.inject.assistedinject.Assisted;
 import java.util.Collections;
 import java.util.Set;
 
-class DeleteRefRights extends Handler<VoidResult> {
+class DeleteRefRights extends Handler<ProjectDetail> {
   interface Factory {
     DeleteRefRights create(@Assisted Project.NameKey projectName,
         @Assisted Set<RefRight.Key> toRemove);
   }
 
+  private final ProjectDetailFactory.Factory projectDetailFactory;
   private final ProjectControl.Factory projectControlFactory;
   private final ProjectCache projectCache;
   private final ReviewDb db;
@@ -45,11 +46,13 @@ class DeleteRefRights extends Handler<VoidResult> {
   private final Set<RefRight.Key> toRemove;
 
   @Inject
-  DeleteRefRights(final ProjectControl.Factory projectControlFactory,
+  DeleteRefRights(final ProjectDetailFactory.Factory projectDetailFactory,
+      final ProjectControl.Factory projectControlFactory,
       final ProjectCache projectCache, final ReviewDb db,
 
       @Assisted final Project.NameKey projectName,
       @Assisted final Set<RefRight.Key> toRemove) {
+    this.projectDetailFactory = projectDetailFactory;
     this.projectControlFactory = projectControlFactory;
     this.projectCache = projectCache;
     this.db = db;
@@ -59,7 +62,7 @@ class DeleteRefRights extends Handler<VoidResult> {
   }
 
   @Override
-  public VoidResult call() throws NoSuchProjectException, OrmException,
+  public ProjectDetail call() throws NoSuchProjectException, OrmException,
       NoSuchRefException {
     final ProjectControl projectControl =
         projectControlFactory.controlFor(projectName);
@@ -80,7 +83,7 @@ class DeleteRefRights extends Handler<VoidResult> {
       }
     }
     projectCache.evictAll();
-    return VoidResult.INSTANCE;
+    return projectDetailFactory.create(projectName).call();
   }
 
   private RefControl controlForRef(ProjectControl p, String ref) {

gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/ListBranches.java

@@ -14,6 +14,7 @@
 
 package com.google.gerrit.httpd.rpc.project;
 
+import com.google.gerrit.common.data.ListBranchesResult;
 import com.google.gerrit.httpd.rpc.Handler;
 import com.google.gerrit.reviewdb.Branch;
 import com.google.gerrit.reviewdb.Project;
@@ -21,6 +22,7 @@ import com.google.gerrit.reviewdb.RevId;
 import com.google.gerrit.server.git.GitRepositoryManager;
 import com.google.gerrit.server.project.NoSuchProjectException;
 import com.google.gerrit.server.project.ProjectControl;
+import com.google.gerrit.server.project.RefControl;
 import com.google.inject.Inject;
 import com.google.inject.assistedinject.Assisted;
 
@@ -36,7 +38,7 @@ import java.util.Comparator;
 import java.util.List;
 import java.util.Map;
 
-class ListBranches extends Handler<List<Branch>> {
+class ListBranches extends Handler<ListBranchesResult> {
   interface Factory {
     ListBranches create(@Assisted Project.NameKey name);
   }
@@ -58,7 +60,7 @@ class ListBranches extends Handler<List<Branch>> {
   }
 
   @Override
-  public List<Branch> call() throws NoSuchProjectException,
+  public ListBranchesResult call() throws NoSuchProjectException,
       RepositoryNotFoundException {
     final ProjectControl pctl = projectControlFactory.validateFor( //
         projectName, //
@@ -91,7 +93,8 @@ class ListBranches extends Handler<List<Branch>> {
           // showing the resolved value, show the name it references.
           //
           String target = ref.getTarget().getName();
-          if (!pctl.controlForRef(target).isVisible()) {
+          RefControl targetRefControl = pctl.controlForRef(target);
+          if (!targetRefControl.isVisible()) {
             continue;
           }
           if (target.startsWith(Constants.R_HEADS)) {
@@ -100,6 +103,8 @@ class ListBranches extends Handler<List<Branch>> {
 
           Branch b = createBranch(Constants.HEAD);
           b.setRevision(new RevId(target));
+          b.setCanDelete(targetRefControl.canDelete());
+
           if (Constants.HEAD.equals(ref.getName())) {
             headBranch = b;
           } else {
@@ -108,12 +113,17 @@ class ListBranches extends Handler<List<Branch>> {
           continue;
         }
 
+        RefControl refControl = pctl.controlForRef(ref.getName());
+
         if (ref.getName().startsWith(Constants.R_HEADS)
-            && pctl.controlForRef(ref.getName()).isVisible()) {
+            && refControl.isVisible()) {
           final Branch b = createBranch(ref.getName());
           if (ref.getObjectId() != null) {
             b.setRevision(new RevId(ref.getObjectId().name()));
           }
+
+          b.setCanDelete(refControl.canDelete());
+
           branches.add(b);
         }
       }
@@ -129,7 +139,7 @@ class ListBranches extends Handler<List<Branch>> {
     if (headBranch != null) {
       branches.add(0, headBranch);
     }
-    return branches;
+    return new ListBranchesResult(branches, pctl.canAddRefs());
   }
 
   private Branch createBranch(final String name) {

gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/ProjectAdminServiceImpl.java

@@ -14,6 +14,7 @@
 
 package com.google.gerrit.httpd.rpc.project;
 
+import com.google.gerrit.common.data.ListBranchesResult;
 import com.google.gerrit.common.data.ProjectAdminService;
 import com.google.gerrit.common.data.ProjectDetail;
 import com.google.gerrit.reviewdb.ApprovalCategory;
@@ -21,7 +22,6 @@ import com.google.gerrit.reviewdb.Branch;
 import com.google.gerrit.reviewdb.Project;
 import com.google.gerrit.reviewdb.RefRight;
 import com.google.gwt.user.client.rpc.AsyncCallback;
-import com.google.gwtjsonrpc.client.VoidResult;
 import com.google.inject.Inject;
 
 import java.util.List;
@@ -32,7 +32,7 @@ class ProjectAdminServiceImpl implements ProjectAdminService {
   private final ChangeProjectSettings.Factory changeProjectSettingsFactory;
   private final DeleteBranches.Factory deleteBranchesFactory;
   private final ListBranches.Factory listBranchesFactory;
-  private final OwnedProjects.Factory ownedProjectsFactory;
+  private final VisibleProjects.Factory visibleProjectsFactory;
   private final ProjectDetailFactory.Factory projectDetailFactory;
   private final AddRefRight.Factory addRefRightFactory;
   private final DeleteRefRights.Factory deleteRefRightsFactory;
@@ -42,7 +42,7 @@ class ProjectAdminServiceImpl implements ProjectAdminService {
       final ChangeProjectSettings.Factory changeProjectSettingsFactory,
       final DeleteBranches.Factory deleteBranchesFactory,
       final ListBranches.Factory listBranchesFactory,
-      final OwnedProjects.Factory ownedProjectsFactory,
+      final VisibleProjects.Factory visibleProjectsFactory,
       final ProjectDetailFactory.Factory projectDetailFactory,
       final AddRefRight.Factory addRefRightFactory,
       final DeleteRefRights.Factory deleteRefRightsFactory) {
@@ -50,15 +50,15 @@ class ProjectAdminServiceImpl implements ProjectAdminService {
     this.changeProjectSettingsFactory = changeProjectSettingsFactory;
     this.deleteBranchesFactory = deleteBranchesFactory;
     this.listBranchesFactory = listBranchesFactory;
-    this.ownedProjectsFactory = ownedProjectsFactory;
+    this.visibleProjectsFactory = visibleProjectsFactory;
     this.projectDetailFactory = projectDetailFactory;
     this.addRefRightFactory = addRefRightFactory;
     this.deleteRefRightsFactory = deleteRefRightsFactory;
   }
 
   @Override
-  public void ownedProjects(final AsyncCallback<List<Project>> callback) {
+  public void visibleProjects(final AsyncCallback<List<Project>> callback) {
-    ownedProjectsFactory.create().to(callback);
+    visibleProjectsFactory.create().to(callback);
   }
 
   @Override
@@ -75,7 +75,7 @@ class ProjectAdminServiceImpl implements ProjectAdminService {
 
   @Override
   public void deleteRight(final Project.NameKey projectName,
-      final Set<RefRight.Key> toRemove, final AsyncCallback<VoidResult> callback) {
+      final Set<RefRight.Key> toRemove, final AsyncCallback<ProjectDetail> callback) {
     deleteRefRightsFactory.create(projectName, toRemove).to(callback);
   }
 
@@ -90,7 +90,7 @@ class ProjectAdminServiceImpl implements ProjectAdminService {
 
   @Override
   public void listBranches(final Project.NameKey projectName,
-      final AsyncCallback<List<Branch>> callback) {
+      final AsyncCallback<ListBranchesResult> callback) {
     listBranchesFactory.create(projectName).to(callback);
   }
 
@@ -104,7 +104,7 @@ class ProjectAdminServiceImpl implements ProjectAdminService {
   @Override
   public void addBranch(final Project.NameKey projectName,
       final String branchName, final String startingRevision,
-      final AsyncCallback<List<Branch>> callback) {
+      final AsyncCallback<ListBranchesResult> callback) {
     addBranchFactory.create(projectName, branchName, startingRevision).to(
         callback);
   }

gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/ProjectDetailFactory.java

@@ -26,6 +26,7 @@ import com.google.gerrit.server.account.GroupCache;
 import com.google.gerrit.server.project.NoSuchProjectException;
 import com.google.gerrit.server.project.ProjectControl;
 import com.google.gerrit.server.project.ProjectState;
+import com.google.gerrit.server.project.RefControl;
 import com.google.inject.Inject;
 import com.google.inject.assistedinject.Assisted;
 
@@ -64,10 +65,10 @@ class ProjectDetailFactory extends Handler<ProjectDetail> {
 
   @Override
   public ProjectDetail call() throws NoSuchProjectException {
-    final ProjectState projectState =
+    final ProjectControl pc =
-        projectControlFactory.validateFor(projectName,
+        projectControlFactory.validateFor(projectName, ProjectControl.OWNER
-            ProjectControl.OWNER | ProjectControl.VISIBLE).getProjectState();
+            | ProjectControl.VISIBLE);
-
+    final ProjectState projectState = pc.getProjectState();
     final ProjectDetail detail = new ProjectDetail();
     detail.setProject(projectState.getProject());
 
@@ -75,7 +76,8 @@ class ProjectDetailFactory extends Handler<ProjectDetail> {
     final List<InheritedRefRight> refRights = new ArrayList<InheritedRefRight>();
 
     for (final RefRight r : projectState.getInheritedRights()) {
-      InheritedRefRight refRight = new InheritedRefRight(r, true);
+      InheritedRefRight refRight = new InheritedRefRight(
+          r, true, controlForRef(pc, r.getRefPattern()).isOwner());
       if (!refRights.contains(refRight)) {
         refRights.add(refRight);
         wantGroup(r.getAccountGroupId());
@@ -83,7 +85,8 @@ class ProjectDetailFactory extends Handler<ProjectDetail> {
     }
 
     for (final RefRight r : projectState.getLocalRights()) {
-      refRights.add(new InheritedRefRight(r, false));
+      refRights.add(new InheritedRefRight(
+          r, false, controlForRef(pc, r.getRefPattern()).isOwner()));
       wantGroup(r.getAccountGroupId());
     }
 
@@ -118,8 +121,15 @@ class ProjectDetailFactory extends Handler<ProjectDetail> {
       }
     });
 
+    final boolean userIsOwner = pc.isOwner();
+    final boolean userIsOwnerAnyRef = pc.isOwnerAnyRef();
+
     detail.setRights(refRights);
     detail.setGroups(groups);
+    detail.setCanModifyAccess(userIsOwnerAnyRef);
+    detail.setCanModifyAgreements(userIsOwner);
+    detail.setCanModifyDescription(userIsOwner);
+    detail.setCanModifyMergeType(userIsOwner);
     return detail;
   }
 
@@ -134,4 +144,11 @@ class ProjectDetailFactory extends Handler<ProjectDetail> {
       groups.put(groupId, groupCache.get(groupId));
     }
   }
+
+  private RefControl controlForRef(ProjectControl p, String ref) {
+    if (ref.endsWith("/*")) {
+      ref = ref.substring(0, ref.length() - 1);
+    }
+    return p.controlForRef(ref);
+  }
 }

gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/ProjectModule.java

@@ -34,7 +34,7 @@ public class ProjectModule extends RpcServletModule {
         factory(DeleteBranches.Factory.class);
         factory(DeleteRefRights.Factory.class);
         factory(ListBranches.Factory.class);
-        factory(OwnedProjects.Factory.class);
+        factory(VisibleProjects.Factory.class);
         factory(ProjectDetailFactory.Factory.class);
       }
     });

gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/project/VisibleProjects.java

@@ -14,27 +14,23 @@
 
 package com.google.gerrit.httpd.rpc.project;
 
+
 import com.google.gerrit.httpd.rpc.Handler;
-import com.google.gerrit.reviewdb.AccountGroup;
-import com.google.gerrit.reviewdb.ApprovalCategory;
 import com.google.gerrit.reviewdb.Project;
-import com.google.gerrit.reviewdb.RefRight;
 import com.google.gerrit.reviewdb.ReviewDb;
 import com.google.gerrit.server.IdentifiedUser;
 import com.google.gerrit.server.project.NoSuchProjectException;
 import com.google.gerrit.server.project.ProjectControl;
 import com.google.gwtorm.client.OrmException;
 import com.google.inject.Inject;
-
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Comparator;
-import java.util.HashSet;
 import java.util.List;
 
-class OwnedProjects extends Handler<List<Project>> {
+class VisibleProjects extends Handler<List<Project>> {
   interface Factory {
-    OwnedProjects create();
+    VisibleProjects create();
   }
 
   private final ProjectControl.Factory projectControlFactory;
@@ -42,7 +38,7 @@ class OwnedProjects extends Handler<List<Project>> {
   private final ReviewDb db;
 
   @Inject
-  OwnedProjects(final ProjectControl.Factory projectControlFactory,
+  VisibleProjects(final ProjectControl.Factory projectControlFactory,
       final IdentifiedUser user, final ReviewDb db) {
     this.projectControlFactory = projectControlFactory;
     this.user = user;
@@ -54,28 +50,19 @@ class OwnedProjects extends Handler<List<Project>> {
     final List<Project> result;
     if (user.isAdministrator()) {
       result = db.projects().all().toList();
-
     } else {
-      final HashSet<Project.NameKey> seen = new HashSet<Project.NameKey>();
       result = new ArrayList<Project>();
-      for (final AccountGroup.Id groupId : user.getEffectiveGroups()) {
+      for (Project p : db.projects().all().toList()) {
-        for (final RefRight r : db.refRights().byCategoryGroup(
-            ApprovalCategory.OWN, groupId)) {
-          final Project.NameKey name = r.getProjectNameKey();
-          if (!seen.add(name)) {
-            continue;
-          }
         try {
-            ProjectControl c = projectControlFactory.controlFor(name);
+          ProjectControl c = projectControlFactory.controlFor(p.getNameKey());
-            if (c.isOwnerAnyRef()) {
+          if (c.isVisible() || c.isOwner()) {
-              result.add(c.getProject());
+            result.add(p);
           }
         } catch (NoSuchProjectException e) {
           continue;
         }
       }
     }
-    }
     Collections.sort(result, new Comparator<Project>() {
       public int compare(final Project a, final Project b) {
         return a.getName().compareTo(b.getName());

gerrit-httpd/src/test/java/com/google/gerrit/httpd/rpc/project/ListBranchesTest.java

@@ -24,6 +24,7 @@ import static org.eclipse.jgit.lib.Constants.HEAD;
 import static org.eclipse.jgit.lib.Constants.R_HEADS;
 import static org.eclipse.jgit.lib.Ref.Storage.LOOSE;
 
+import com.google.gerrit.common.data.ListBranchesResult;
 import com.google.gerrit.reviewdb.Branch;
 import com.google.gerrit.reviewdb.Project;
 import com.google.gerrit.server.git.GitRepositoryManager;
@@ -121,11 +122,12 @@ public class ListBranchesTest extends LocalDiskRepositoryTestCase {
   }
 
 
-  private List<Branch> permitted(boolean getHead)
+  private ListBranchesResult permitted(boolean getHead)
       throws NoSuchProjectException, IOException {
     Map<String, Ref> refs = realDb.getAllRefs();
 
     validate().andReturn(pc);
+
     expect(grm.openRepository(eq(name.get()))).andReturn(mockDb);
     expect(mockDb.getAllRefs()).andDelegateTo(realDb);
     if (getHead) {
@@ -140,12 +142,16 @@ public class ListBranchesTest extends LocalDiskRepositoryTestCase {
     }
 
     mockDb.close();
+
+    expect(pc.canAddRefs()).andReturn(true);
+
     expectLastCall();
 
     doReplay();
-    final List<Branch> r = new ListBranches(pcf, grm, name).call();
+    final ListBranchesResult r = new ListBranches(pcf, grm, name).call();
     doVerify();
     assertNotNull(r);
+    assertNotNull(r.getBranches());
     return r;
   }
 
@@ -153,6 +159,9 @@ public class ListBranchesTest extends LocalDiskRepositoryTestCase {
     RefControl rc = createStrictMock(RefControl.class);
     refMocks.add(rc);
     expect(rc.isVisible()).andReturn(visible);
+    if (visible) {
+      expect(rc.canDelete()).andReturn(true);
+    }
 
     if (ref.isSymbolic()) {
       expect(pc.controlForRef(ref.getTarget().getName())).andReturn(rc);
@@ -162,10 +171,11 @@ public class ListBranchesTest extends LocalDiskRepositoryTestCase {
   }
 
   public void testEmptyProject() throws Exception {
-    List<Branch> r = permitted(true);
+    ListBranchesResult r = permitted(true);
-    assertEquals(1, r.size());
 
-    Branch b = r.get(0);
+    assertEquals(1, r.getBranches().size());
+
+    Branch b = r.getBranches().get(0);
     assertNotNull(b);
 
     assertNotNull(b.getNameKey());
@@ -182,10 +192,10 @@ public class ListBranchesTest extends LocalDiskRepositoryTestCase {
   public void testMasterBranch() throws Exception {
     set("master", idA);
 
-    List<Branch> r = permitted(false);
+    ListBranchesResult r = permitted(false);
-    assertEquals(2, r.size());
+    assertEquals(2, r.getBranches().size());
 
-    Branch b = r.get(0);
+    Branch b = r.getBranches().get(0);
     assertNotNull(b);
 
     assertNotNull(b.getNameKey());
@@ -198,7 +208,7 @@ public class ListBranchesTest extends LocalDiskRepositoryTestCase {
     assertNotNull(b.getRevision());
     assertEquals("master", b.getRevision().get());
 
-    b = r.get(1);
+    b = r.getBranches().get(1);
     assertNotNull(b);
 
     assertNotNull(b.getNameKey());
@@ -215,10 +225,10 @@ public class ListBranchesTest extends LocalDiskRepositoryTestCase {
   public void testBranchNotHead() throws Exception {
     set("foo", idA);
 
-    List<Branch> r = permitted(true);
+    ListBranchesResult r = permitted(true);
-    assertEquals(2, r.size());
+    assertEquals(2, r.getBranches().size());
 
-    Branch b = r.get(0);
+    Branch b = r.getBranches().get(0);
     assertNotNull(b);
 
     assertNotNull(b.getNameKey());
@@ -231,7 +241,7 @@ public class ListBranchesTest extends LocalDiskRepositoryTestCase {
     assertNotNull(b.getRevision());
     assertEquals("master", b.getRevision().get());
 
-    b = r.get(1);
+    b = r.getBranches().get(1);
     assertNotNull(b);
 
     assertNotNull(b.getNameKey());
@@ -258,18 +268,19 @@ public class ListBranchesTest extends LocalDiskRepositoryTestCase {
     for (Ref ref : u.values()) {
       assumeVisible(ref, true);
     }
+    expect(pc.canAddRefs()).andReturn(true);
     mockDb.close();
     expectLastCall();
 
     doReplay();
-    final List<Branch> r = new ListBranches(pcf, grm, name).call();
+    final ListBranchesResult r = new ListBranches(pcf, grm, name).call();
     doVerify();
     assertNotNull(r);
 
-    assertEquals(3, r.size());
+    assertEquals(3, r.getBranches().size());
-    assertEquals(HEAD, r.get(0).getShortName());
+    assertEquals(HEAD, r.getBranches().get(0).getShortName());
-    assertEquals("bar", r.get(1).getShortName());
+    assertEquals("bar", r.getBranches().get(1).getShortName());
-    assertEquals("foo", r.get(2).getShortName());
+    assertEquals("foo", r.getBranches().get(2).getShortName());
   }
 
   public void testHeadNotVisible() throws Exception {
@@ -284,14 +295,15 @@ public class ListBranchesTest extends LocalDiskRepositoryTestCase {
     expect(mockDb.getAllRefs()).andReturn(u);
     assumeVisible(bar, false);
     assumeVisible(bar, false);
+    expect(pc.canAddRefs()).andReturn(true);
     mockDb.close();
     expectLastCall();
 
     doReplay();
-    final List<Branch> r = new ListBranches(pcf, grm, name).call();
+    final ListBranchesResult r = new ListBranches(pcf, grm, name).call();
     doVerify();
     assertNotNull(r);
-    assertTrue(r.isEmpty());
+    assertTrue(r.getBranches().isEmpty());
   }
 
   public void testHeadVisibleButBranchHidden() throws Exception {
@@ -311,16 +323,17 @@ public class ListBranchesTest extends LocalDiskRepositoryTestCase {
     assumeVisible(bar, true);
     assumeVisible(bar, true);
     assumeVisible(foo, false);
+    expect(pc.canAddRefs()).andReturn(true);
     mockDb.close();
     expectLastCall();
 
     doReplay();
-    final List<Branch> r = new ListBranches(pcf, grm, name).call();
+    final ListBranchesResult r = new ListBranches(pcf, grm, name).call();
     doVerify();
     assertNotNull(r);
 
-    assertEquals(2, r.size());
+    assertEquals(2, r.getBranches().size());
-    assertEquals(HEAD, r.get(0).getShortName());
+    assertEquals(HEAD, r.getBranches().get(0).getShortName());
-    assertEquals("bar", r.get(1).getShortName());
+    assertEquals("bar", r.getBranches().get(1).getShortName());
   }
 }

gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/Branch.java

@@ -71,6 +71,7 @@ public final class Branch {
 
   protected NameKey name;
   protected RevId revision;
+  protected boolean canDelete;
 
   protected Branch() {
   }
@@ -98,4 +99,12 @@ public final class Branch {
   public void setRevision(final RevId id) {
     revision = id;
   }
+
+  public boolean getCanDelete() {
+    return canDelete;
+  }
+
+  public void setCanDelete(boolean canDelete) {
+    this.canDelete = canDelete;
+  }
 }

gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectControl.java

@@ -121,6 +121,11 @@ public class ProjectControl {
         || canPerformOnAnyRef(ApprovalCategory.READ, (short) 1);
   }
 
+  public boolean canAddRefs() {
+    return (canPerformOnAnyRef(ApprovalCategory.PUSH_HEAD, ApprovalCategory.PUSH_HEAD_CREATE)
+        || isOwnerAnyRef());
+  }
+
   /** Can this user see all the refs in this projects? */
   public boolean allRefsAreVisible() {
     return visibleForReplication()