opendev/gerrit
Code Issues Proposed changes

Specify exact dependencies for rollup-bin

Browse Source 
rollup-bin specified whole @tools_npm//:node_modules. As a result, any
rule which uses rollup-bin requires the whole content of the
node_modules folder. This leads to the issue with the remote build
executor which has a limit on the number of files in an input tree.

Issue: 12511
Change-Id: Iff5330417f78bdba4b5c1de4b67c3a10f15b7272
This commit is contained in:
Dmitrii Filippov 2020-03-30 15:32:37 +02:00
parent 39b009a78c
commit 7043396ac8
1 changed files with 5 additions and 1 deletions

6
tools/node_tools/BUILD

@ -8,8 +8,12 @@ package(default_visibility = ["//visibility:public"])
# Usage: rollup_bundle(rollup_bin = "//tools/node_tools:rollup-bin, ...) # Usage: rollup_bundle(rollup_bin = "//tools/node_tools:rollup-bin, ...)
nodejs_binary( nodejs_binary(
name = "rollup-bin", name = "rollup-bin",
# Define only minimal required dependencies.
# Otherwise remote build execution fails with the too many
# files error when it builds :release target.
data = [ data = [
"@tools_npm//:node_modules", "@tools_npm//rollup",
"@tools_npm//rollup-plugin-terser",
], ],
# The entry point must be "@tools_npm:node_modules/rollup/dist/bin/rollup", # The entry point must be "@tools_npm:node_modules/rollup/dist/bin/rollup",
# But bazel doesn't run it correctly with the following command line: # But bazel doesn't run it correctly with the following command line: