opendev/gerrit
Code Issues Proposed changes

Don't obtain 0 approvals or submit approvals in dashboards

Browse Source 
A 0 vote for a category is pointless.  It won't display as a value
in the client UI and is often created by the server when a user is
CC'd onto a change, or added as a reviewer.  There is no value in
sending it to the client when we get the approvals for the dashboard.

The submit approval is used as a log to say who submitted the
change, but is also not displayed in the UI, so we can skip over
it and not transmit.

Removing both of these items reduces the transfer size of the
response we need to send to decorate the approval columns in a
user's dashboard.

Change-Id: I28f1dded506285ce2071287db403ed5ac34ac61b
Signed-off-by: Shawn O. Pearce <sop@google.com>
This commit is contained in:
Shawn O. Pearce
2009-09-03 15:39:41 -07:00
parent 99c665d397
commit 7043676db6
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/main/java/com/google/gerrit/server/rpc/patch/PatchDetailServiceImpl.java
View File

@@ -349,6 +349,10 @@ class PatchDetailServiceImpl extends BaseServiceImplementation implements
if (change.getStatus().isOpen()) {
fs.normalize(approvalTypes.getApprovalType(category), ca);
}
if (ca.getValue() == 0
|| ApprovalCategory.SUBMIT.equals(category)) {
continue;
}
psas.put(category, ca);
}
@@ -390,6 +394,10 @@ class PatchDetailServiceImpl extends BaseServiceImplementation implements
if (change.getStatus().isOpen()) {
fs.normalize(approvalTypes.getApprovalType(category), ca);
}
if (ca.getValue() == 0
|| ApprovalCategory.SUBMIT.equals(category)) {
continue;
}
boolean keep = true;
if (psas.containsKey(category)) {
final short oldValue = psas.get(category).getValue();