opendev/gerrit
Code Issues Proposed changes

Simplify getNativeEvent().getKeyCode() to getNativeKeyCode()

Browse Source 
For KeyDownEvent and KeyUpEvent, the latter is just a shorthand for the
former. Unfortunately, KeyPressEvent doesn't have this shorthand.

Change-Id: I6dc37b93cf09be5cfa58bbb5fcc81d7f4b9a09e5
This commit is contained in:
Michael Zhou
2016-04-23 21:49:17 -04:00
parent be351a65e3
commit 72096e0bbb
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/GroupListScreen.java
View File

@@ -126,7 +126,7 @@ public class GroupListScreen extends Screen {
@Override @Override
public void onKeyUp(KeyUpEvent event) { public void onKeyUp(KeyUpEvent event) {
Query q = new Query(filterTxt.getValue()) Query q = new Query(filterTxt.getValue())
.open(event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER); .open(event.getNativeKeyCode() == KeyCodes.KEY_ENTER);
if (match.equals(q.qMatch)) { if (match.equals(q.qMatch)) {
q.start(start); q.start(start);
} }

2
gerrit-gwtui/src/main/java/com/google/gerrit/client/admin/ProjectListScreen.java
View File

@@ -183,7 +183,7 @@ public class ProjectListScreen extends PaginatedProjectScreen {
@Override @Override
public void onKeyUp(KeyUpEvent event) { public void onKeyUp(KeyUpEvent event) {
Query q = new Query(filterTxt.getValue()) Query q = new Query(filterTxt.getValue())
.open(event.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER); .open(event.getNativeKeyCode() == KeyCodes.KEY_ENTER);
if (match.equals(q.qMatch)) { if (match.equals(q.qMatch)) {
q.start(start); q.start(start);
} }

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Hashtags.java
View File

@@ -114,9 +114,9 @@ public class Hashtags extends Composite {
hashtagTextBox.addKeyDownHandler(new KeyDownHandler() { hashtagTextBox.addKeyDownHandler(new KeyDownHandler() {
@Override @Override
public void onKeyDown(KeyDownEvent e) { public void onKeyDown(KeyDownEvent e) {
if (e.getNativeEvent().getKeyCode() == KeyCodes.KEY_ESCAPE) { if (e.getNativeKeyCode() == KeyCodes.KEY_ESCAPE) {
onCancel(null); onCancel(null);
} else if (e.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER) { } else if (e.getNativeKeyCode() == KeyCodes.KEY_ENTER) {
onAdd(null); onAdd(null);
} }
} }

4
gerrit-gwtui/src/main/java/com/google/gerrit/client/ui/RemoteSuggestBox.java
View File

@@ -50,9 +50,9 @@ public class RemoteSuggestBox extends Composite implements Focusable, HasText,
public void onKeyDown(KeyDownEvent e) { public void onKeyDown(KeyDownEvent e) {
submitOnSelection = false; submitOnSelection = false;
if (e.getNativeEvent().getKeyCode() == KeyCodes.KEY_ESCAPE) { if (e.getNativeKeyCode() == KeyCodes.KEY_ESCAPE) {
CloseEvent.fire(RemoteSuggestBox.this, RemoteSuggestBox.this); CloseEvent.fire(RemoteSuggestBox.this, RemoteSuggestBox.this);
} else if (e.getNativeEvent().getKeyCode() == KeyCodes.KEY_ENTER) { } else if (e.getNativeKeyCode() == KeyCodes.KEY_ENTER) {
if (display.isSuggestionListShowing()) { if (display.isSuggestionListShowing()) {
if (textBox.getValue().equals(remoteSuggestOracle.getLast())) { if (textBox.getValue().equals(remoteSuggestOracle.getLast())) {
submitOnSelection = true; submitOnSelection = true;