opendev/gerrit
Code Issues Proposed changes

Create SubmoduleSectionParser using assisted injection

Browse Source 
This will allow to change dependencies of SubmoduleSectionParser without
adding them to SubmoduleOp only to pass them to SubmoduleSectionParser
constructor.

Change-Id: Ib995027284310caec21cd367ffde3c5f27b2eb3f
This commit is contained in:
Hugo Arès
2015-04-16 15:50:49 -04:00
parent 1ad61122e2
commit 723d26d39f
4 changed files with 25 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
gerrit-server/src/main/java/com/google/gerrit/server/util/SubmoduleSectionParser.java
View File

@@ -18,6 +18,8 @@ import com.google.gerrit.reviewdb.client.Branch;
import com.google.gerrit.reviewdb.client.Project;
import com.google.gerrit.reviewdb.client.SubmoduleSubscription;
import com.google.gerrit.server.git.GitRepositoryManager;
import com.google.inject.Inject;
import com.google.inject.assistedinject.Assisted;
import org.eclipse.jgit.lib.BlobBasedConfig;
import org.eclipse.jgit.lib.Constants;
@@ -45,18 +47,26 @@ import java.util.List;
* </pre>
*/
public class SubmoduleSectionParser {
public interface Factory {
SubmoduleSectionParser create(BlobBasedConfig bbc, String thisServer,
Branch.NameKey superProjectBranch);
}
private final GitRepositoryManager repoManager;
private final BlobBasedConfig bbc;
private final String thisServer;
private final Branch.NameKey superProjectBranch;
private final GitRepositoryManager repoManager;
public SubmoduleSectionParser(final BlobBasedConfig bbc,
final String thisServer, final Branch.NameKey superProjectBranch,
final GitRepositoryManager repoManager) {
@Inject
public SubmoduleSectionParser(GitRepositoryManager repoManager,
@Assisted BlobBasedConfig bbc,
@Assisted String thisServer,
@Assisted Branch.NameKey superProjectBranch) {
this.repoManager = repoManager;
this.bbc = bbc;
this.thisServer = thisServer;
this.superProjectBranch = superProjectBranch;
this.repoManager = repoManager;
}
public List<SubmoduleSubscription> parseAllSections() {