diff --git a/.bazelversion b/.bazelversion index 260bb3085e..09d1d01416 100644 --- a/.bazelversion +++ b/.bazelversion @@ -1,2 +1,2 @@ -0.26.1 +0.29.0 diff --git a/Documentation/config-gerrit.txt b/Documentation/config-gerrit.txt index 7be0678820..0d08c1c644 100644 --- a/Documentation/config-gerrit.txt +++ b/Documentation/config-gerrit.txt @@ -2825,6 +2825,46 @@ to disk when the process finishes. + Defaults to 300000 ms (5 minutes). + +[[index.name.maxMergeCount]]index.name.maxMergeCount:: ++ +Determines the max number of simultaneous merges that are allowed. If a merge +is necessary yet we already have this many threads running, the incoming thread +(that is calling add/updateDocument) will block until a merge thread has +completed. Note that Lucene will only run the smallest maxThreadCount merges +at a time. See the +link:https://lucene.apache.org/core/5_5_0/core/org/apache/lucene/index/ConcurrentMergeScheduler.html#setDefaultMaxMergesAndThreads(boolean)[ +Lucene documentation] for further details. ++ +Defaults to -1 for (auto detection). + + +[[index.name.maxThreadCount]]index.name.maxThreadCount:: ++ +Determines the max number of simultaneous Lucene merge threads that should be running at +once. This must be less than or equal to maxMergeCount. See the +link:https://lucene.apache.org/core/5_5_0/core/org/apache/lucene/index/ConcurrentMergeScheduler.html#setDefaultMaxMergesAndThreads(boolean)[ +Lucene documentation] for further details. ++ +For further details on Lucene index configuration (auto detection) which +affects maxThreadCount and maxMergeCount settings. +See the +link:https://lucene.apache.org/core/5_5_0/core/org/apache/lucene/index/ConcurrentMergeScheduler.html#AUTO_DETECT_MERGES_AND_THREADS[ +Lucene documentation] ++ +Defaults to -1 for (auto detection). + +[[index.name.enableAutoIOThrottle]]index.name.enableAutoIOThrottle:: ++ +Allows the control of whether automatic IO throttling is enabled and used by +default in the lucene merge queue. Automatic dynamic IO throttling, which when +on is used to adaptively rate limit writes bytes/sec to the minimal rate necessary +so merges do not fall behind. See the +link:https://lucene.apache.org/core/5_5_0/core/org/apache/lucene/index/ConcurrentMergeScheduler.html#enableAutoIOThrottle()[ +Lucene documentation] for further details. ++ +Defaults to true (throttling enabled). + Sample Lucene index configuration: ---- [index] @@ -2833,10 +2873,17 @@ Sample Lucene index configuration: [index "changes_open"] ramBufferSize = 60 m maxBufferedDocs = 3000 + maxThreadCount = 5 + maxMergeCount = 50 + [index "changes_closed"] ramBufferSize = 20 m maxBufferedDocs = 500 + maxThreadCount = 10 + maxMergeCount = 100 + enableIOThrottle = false + ---- [[elasticsearch]] diff --git a/WORKSPACE b/WORKSPACE index 2cfe1a6a19..8c714bce5d 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -66,7 +66,19 @@ http_file( load("@bazel_skylib//lib:versions.bzl", "versions") -versions.check(minimum_bazel_version = "0.26.1") +versions.check(minimum_bazel_version = "0.29.0") + +# Rules Python +http_archive( + name = "rules_python", + sha256 = "b5bab4c47e863e0fbb77df4a40c45ca85f98f5a2826939181585644c9f31b97b", + strip_prefix = "rules_python-9d68f24659e8ce8b736590ba1e4418af06ec2552", + urls = ["https://github.com/bazelbuild/rules_python/archive/9d68f24659e8ce8b736590ba1e4418af06ec2552.tar.gz"], +) + +load("@rules_python//python:repositories.bzl", "py_repositories") + +py_repositories() load("@io_bazel_rules_closure//closure:defs.bzl", "closure_repositories") @@ -106,6 +118,17 @@ load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies", "go_repository") gazelle_dependencies() +# Protobuf rules support +http_archive( + name = "rules_proto", + sha256 = "602e7161d9195e50246177e7c55b2f39950a9cf7366f74ed5f22fd45750cd208", + strip_prefix = "rules_proto-97d8af4dc474595af3900dd85cb3a29ad28cc313", + urls = [ + "https://mirror.bazel.build/github.com/bazelbuild/rules_proto/archive/97d8af4dc474595af3900dd85cb3a29ad28cc313.tar.gz", + "https://github.com/bazelbuild/rules_proto/archive/97d8af4dc474595af3900dd85cb3a29ad28cc313.tar.gz", + ], +) + # Dependencies for PolyGerrit local dev server. go_repository( name = "com_github_howeyc_fsnotify", diff --git a/antlr3/BUILD b/antlr3/BUILD index 2d3050eb02..549946a2a0 100644 --- a/antlr3/BUILD +++ b/antlr3/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//tools/bzl:genrule2.bzl", "genrule2") genrule2( diff --git a/java/BUILD b/java/BUILD index 4fc4d79c8a..77611e4353 100644 --- a/java/BUILD +++ b/java/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_binary", "java_library") + java_binary( name = "gerrit-main-class", main_class = "Main", diff --git a/java/com/google/gerrit/acceptance/BUILD b/java/com/google/gerrit/acceptance/BUILD index 7bbdde66ec..02f218aba7 100644 --- a/java/com/google/gerrit/acceptance/BUILD +++ b/java/com/google/gerrit/acceptance/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_binary", "java_library") load("//tools/bzl:java.bzl", "java_library2") load("//tools/bzl:javadoc.bzl", "java_doc") diff --git a/java/com/google/gerrit/asciidoctor/BUILD b/java/com/google/gerrit/asciidoctor/BUILD index f5178a0939..94ec20db7d 100644 --- a/java/com/google/gerrit/asciidoctor/BUILD +++ b/java/com/google/gerrit/asciidoctor/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_binary", "java_library") + java_binary( name = "asciidoc", main_class = "com.google.gerrit.asciidoctor.AsciiDoctor", diff --git a/java/com/google/gerrit/common/BUILD b/java/com/google/gerrit/common/BUILD index 8d658bc963..717f58556b 100644 --- a/java/com/google/gerrit/common/BUILD +++ b/java/com/google/gerrit/common/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + ANNOTATIONS = [ "Nullable.java", "UsedAt.java", diff --git a/java/com/google/gerrit/common/data/testing/BUILD b/java/com/google/gerrit/common/data/testing/BUILD index 32815d588e..8ab01dead8 100644 --- a/java/com/google/gerrit/common/data/testing/BUILD +++ b/java/com/google/gerrit/common/data/testing/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "common-data-test-util", testonly = True, diff --git a/java/com/google/gerrit/elasticsearch/BUILD b/java/com/google/gerrit/elasticsearch/BUILD index f919aade4e..a9b145bfbc 100644 --- a/java/com/google/gerrit/elasticsearch/BUILD +++ b/java/com/google/gerrit/elasticsearch/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "elasticsearch", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gerrit/exceptions/BUILD b/java/com/google/gerrit/exceptions/BUILD index 50bf883bd6..e08c3fd79f 100644 --- a/java/com/google/gerrit/exceptions/BUILD +++ b/java/com/google/gerrit/exceptions/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "exceptions", srcs = glob(["*.java"]), diff --git a/java/com/google/gerrit/extensions/BUILD b/java/com/google/gerrit/extensions/BUILD index b69d2c8d4e..b46b9cc736 100644 --- a/java/com/google/gerrit/extensions/BUILD +++ b/java/com/google/gerrit/extensions/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_binary", "java_library") load("//lib/jgit:jgit.bzl", "JGIT_DOC_URL") load("//lib:guava.bzl", "GUAVA_DOC_URL") load("//tools/bzl:javadoc.bzl", "java_doc") diff --git a/java/com/google/gerrit/extensions/common/testing/BUILD b/java/com/google/gerrit/extensions/common/testing/BUILD index 7092d21d48..9cecb66e0c 100644 --- a/java/com/google/gerrit/extensions/common/testing/BUILD +++ b/java/com/google/gerrit/extensions/common/testing/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "common-test-util", testonly = True, diff --git a/java/com/google/gerrit/extensions/restapi/testing/BUILD b/java/com/google/gerrit/extensions/restapi/testing/BUILD index 3417cae2a9..4c44d2ab1e 100644 --- a/java/com/google/gerrit/extensions/restapi/testing/BUILD +++ b/java/com/google/gerrit/extensions/restapi/testing/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "restapi-test-util", testonly = True, diff --git a/java/com/google/gerrit/git/BUILD b/java/com/google/gerrit/git/BUILD index f0c01debcd..4c4d5bcc89 100644 --- a/java/com/google/gerrit/git/BUILD +++ b/java/com/google/gerrit/git/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "git", srcs = glob(["*.java"]), diff --git a/java/com/google/gerrit/git/testing/BUILD b/java/com/google/gerrit/git/testing/BUILD index 497510d2a5..13fddc1715 100644 --- a/java/com/google/gerrit/git/testing/BUILD +++ b/java/com/google/gerrit/git/testing/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + package(default_testonly = True) java_library( diff --git a/java/com/google/gerrit/gpg/BUILD b/java/com/google/gerrit/gpg/BUILD index 06e44d6c39..f11b9b92bd 100644 --- a/java/com/google/gerrit/gpg/BUILD +++ b/java/com/google/gerrit/gpg/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "gpg", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gerrit/gpg/testing/BUILD b/java/com/google/gerrit/gpg/testing/BUILD index 0282d3ad4e..b227dd5a79 100644 --- a/java/com/google/gerrit/gpg/testing/BUILD +++ b/java/com/google/gerrit/gpg/testing/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "gpg-test-util", testonly = True, diff --git a/java/com/google/gerrit/httpd/BUILD b/java/com/google/gerrit/httpd/BUILD index 5009211390..96c56c85ec 100644 --- a/java/com/google/gerrit/httpd/BUILD +++ b/java/com/google/gerrit/httpd/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "httpd", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gerrit/httpd/auth/oauth/BUILD b/java/com/google/gerrit/httpd/auth/oauth/BUILD index dd3e5fc044..b74a65a20b 100644 --- a/java/com/google/gerrit/httpd/auth/oauth/BUILD +++ b/java/com/google/gerrit/httpd/auth/oauth/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "oauth", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gerrit/httpd/auth/openid/BUILD b/java/com/google/gerrit/httpd/auth/openid/BUILD index f09f93def1..95b1efc191 100644 --- a/java/com/google/gerrit/httpd/auth/openid/BUILD +++ b/java/com/google/gerrit/httpd/auth/openid/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "openid", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gerrit/httpd/init/BUILD b/java/com/google/gerrit/httpd/init/BUILD index df072b24f2..09772fddca 100644 --- a/java/com/google/gerrit/httpd/init/BUILD +++ b/java/com/google/gerrit/httpd/init/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "init", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gerrit/index/BUILD b/java/com/google/gerrit/index/BUILD index dfdc01428f..55c7746924 100644 --- a/java/com/google/gerrit/index/BUILD +++ b/java/com/google/gerrit/index/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + QUERY_PARSE_EXCEPTION_SRCS = [ "query/QueryParseException.java", "query/QueryRequiresAuthException.java", diff --git a/java/com/google/gerrit/index/project/BUILD b/java/com/google/gerrit/index/project/BUILD index f32d8c0f7a..2c460fdca1 100644 --- a/java/com/google/gerrit/index/project/BUILD +++ b/java/com/google/gerrit/index/project/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "project", srcs = glob(["*.java"]), diff --git a/java/com/google/gerrit/index/query/testing/BUILD b/java/com/google/gerrit/index/query/testing/BUILD index ee346a8883..1785f49c3b 100644 --- a/java/com/google/gerrit/index/query/testing/BUILD +++ b/java/com/google/gerrit/index/query/testing/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + package( default_testonly = True, default_visibility = ["//visibility:public"], diff --git a/java/com/google/gerrit/jgit/BUILD b/java/com/google/gerrit/jgit/BUILD index 2387614e99..e67ebfe1ff 100644 --- a/java/com/google/gerrit/jgit/BUILD +++ b/java/com/google/gerrit/jgit/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "jgit", srcs = [ diff --git a/java/com/google/gerrit/json/BUILD b/java/com/google/gerrit/json/BUILD index 7282dc46ed..d9cec456fc 100644 --- a/java/com/google/gerrit/json/BUILD +++ b/java/com/google/gerrit/json/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "json", srcs = glob(["*.java"]), diff --git a/java/com/google/gerrit/launcher/BUILD b/java/com/google/gerrit/launcher/BUILD index bac0c532bb..15fa0ce9aa 100644 --- a/java/com/google/gerrit/launcher/BUILD +++ b/java/com/google/gerrit/launcher/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + # NOTE: GerritLauncher must be a single, self-contained class. Do not add any # additional srcs or deps to this rule. java_library( diff --git a/java/com/google/gerrit/lifecycle/BUILD b/java/com/google/gerrit/lifecycle/BUILD index 7ba6123b92..a3f3d81a87 100644 --- a/java/com/google/gerrit/lifecycle/BUILD +++ b/java/com/google/gerrit/lifecycle/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "lifecycle", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gerrit/lucene/BUILD b/java/com/google/gerrit/lucene/BUILD index fa4c923e1a..40b2548b46 100644 --- a/java/com/google/gerrit/lucene/BUILD +++ b/java/com/google/gerrit/lucene/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + QUERY_BUILDER = ["QueryBuilder.java"] java_library( diff --git a/java/com/google/gerrit/lucene/GerritIndexWriterConfig.java b/java/com/google/gerrit/lucene/GerritIndexWriterConfig.java index 75e03e32b5..f6b2f0edf6 100644 --- a/java/com/google/gerrit/lucene/GerritIndexWriterConfig.java +++ b/java/com/google/gerrit/lucene/GerritIndexWriterConfig.java @@ -21,6 +21,7 @@ import com.google.common.collect.ImmutableMap; import com.google.gerrit.server.config.ConfigUtil; import org.apache.lucene.analysis.CharArraySet; import org.apache.lucene.analysis.standard.StandardAnalyzer; +import org.apache.lucene.index.ConcurrentMergeScheduler; import org.apache.lucene.index.IndexWriterConfig; import org.apache.lucene.index.IndexWriterConfig.OpenMode; import org.eclipse.jgit.lib.Config; @@ -42,6 +43,21 @@ class GerritIndexWriterConfig { new IndexWriterConfig(analyzer) .setOpenMode(OpenMode.CREATE_OR_APPEND) .setCommitOnClose(true); + + int maxMergeCount = cfg.getInt("index", name, "maxMergeCount", -1); + int maxThreadCount = cfg.getInt("index", name, "maxThreadCount", -1); + boolean enableAutoIOThrottle = cfg.getBoolean("index", name, "enableAutoIOThrottle", true); + if (maxMergeCount != -1 || maxThreadCount != -1 || !enableAutoIOThrottle) { + ConcurrentMergeScheduler mergeScheduler = new ConcurrentMergeScheduler(); + if (maxMergeCount != -1 || maxThreadCount != -1) { + mergeScheduler.setMaxMergesAndThreads(maxMergeCount, maxThreadCount); + } + if (!enableAutoIOThrottle) { + mergeScheduler.disableAutoIOThrottle(); + } + luceneConfig.setMergeScheduler(mergeScheduler); + } + double m = 1 << 20; luceneConfig.setRAMBufferSizeMB( cfg.getLong( diff --git a/java/com/google/gerrit/mail/BUILD b/java/com/google/gerrit/mail/BUILD index 90bb82cc0c..6be5f0e4e4 100644 --- a/java/com/google/gerrit/mail/BUILD +++ b/java/com/google/gerrit/mail/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "mail", srcs = glob(["*.java"]), diff --git a/java/com/google/gerrit/metrics/BUILD b/java/com/google/gerrit/metrics/BUILD index b7b99811f7..786ef68bf5 100644 --- a/java/com/google/gerrit/metrics/BUILD +++ b/java/com/google/gerrit/metrics/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "metrics", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gerrit/metrics/dropwizard/BUILD b/java/com/google/gerrit/metrics/dropwizard/BUILD index 9adb375f25..4b3859f7a8 100644 --- a/java/com/google/gerrit/metrics/dropwizard/BUILD +++ b/java/com/google/gerrit/metrics/dropwizard/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "dropwizard", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gerrit/pgm/BUILD b/java/com/google/gerrit/pgm/BUILD index 02c083c1f5..ea6e9b7f4f 100644 --- a/java/com/google/gerrit/pgm/BUILD +++ b/java/com/google/gerrit/pgm/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + # TODO(davido): This indirection doesn't avoid unwanted depdencies # in acceptance-framework and should be removed. Instead, provided_deps # should be used, once https://github.com/bazelbuild/bazel/issues/1402 diff --git a/java/com/google/gerrit/pgm/http/BUILD b/java/com/google/gerrit/pgm/http/BUILD index 838c614843..34115ae811 100644 --- a/java/com/google/gerrit/pgm/http/BUILD +++ b/java/com/google/gerrit/pgm/http/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "http", visibility = ["//visibility:public"], diff --git a/java/com/google/gerrit/pgm/http/jetty/BUILD b/java/com/google/gerrit/pgm/http/jetty/BUILD index a6a13dc74c..ea3afe118c 100644 --- a/java/com/google/gerrit/pgm/http/jetty/BUILD +++ b/java/com/google/gerrit/pgm/http/jetty/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "jetty", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gerrit/pgm/init/BUILD b/java/com/google/gerrit/pgm/init/BUILD index b2a4d72f85..eb0d49e36a 100644 --- a/java/com/google/gerrit/pgm/init/BUILD +++ b/java/com/google/gerrit/pgm/init/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "init", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gerrit/pgm/init/api/BUILD b/java/com/google/gerrit/pgm/init/api/BUILD index 5b07fc6cfd..19203fcc48 100644 --- a/java/com/google/gerrit/pgm/init/api/BUILD +++ b/java/com/google/gerrit/pgm/init/api/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "api", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gerrit/pgm/util/BUILD b/java/com/google/gerrit/pgm/util/BUILD index ffd1cbd3c2..94798f70ad 100644 --- a/java/com/google/gerrit/pgm/util/BUILD +++ b/java/com/google/gerrit/pgm/util/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "util", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gerrit/prettify/BUILD b/java/com/google/gerrit/prettify/BUILD index 88b5b60ec1..76afbe77b8 100644 --- a/java/com/google/gerrit/prettify/BUILD +++ b/java/com/google/gerrit/prettify/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "server", srcs = glob(["common/**/*.java"]), diff --git a/java/com/google/gerrit/proto/BUILD b/java/com/google/gerrit/proto/BUILD index 4f05bf61f3..98558c54f0 100644 --- a/java/com/google/gerrit/proto/BUILD +++ b/java/com/google/gerrit/proto/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "proto", srcs = ["Protos.java"], diff --git a/java/com/google/gerrit/proto/testing/BUILD b/java/com/google/gerrit/proto/testing/BUILD index 48115ff157..acfa8f06ee 100644 --- a/java/com/google/gerrit/proto/testing/BUILD +++ b/java/com/google/gerrit/proto/testing/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + package(default_testonly = True) java_library( diff --git a/java/com/google/gerrit/reviewdb/BUILD b/java/com/google/gerrit/reviewdb/BUILD index 588c47a217..3bc6528d5d 100644 --- a/java/com/google/gerrit/reviewdb/BUILD +++ b/java/com/google/gerrit/reviewdb/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + package( default_visibility = ["//visibility:public"], ) diff --git a/java/com/google/gerrit/server/BUILD b/java/com/google/gerrit/server/BUILD index a3dc725dae..d2b7584a42 100644 --- a/java/com/google/gerrit/server/BUILD +++ b/java/com/google/gerrit/server/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//tools/bzl:javadoc.bzl", "java_doc") CONSTANTS_SRC = [ diff --git a/java/com/google/gerrit/server/api/BUILD b/java/com/google/gerrit/server/api/BUILD index b9e26de154..459c16ae0e 100644 --- a/java/com/google/gerrit/server/api/BUILD +++ b/java/com/google/gerrit/server/api/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "api", srcs = glob( diff --git a/java/com/google/gerrit/server/audit/BUILD b/java/com/google/gerrit/server/audit/BUILD index 71cd3a1d60..5c2a40aa06 100644 --- a/java/com/google/gerrit/server/audit/BUILD +++ b/java/com/google/gerrit/server/audit/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "audit", srcs = glob( diff --git a/java/com/google/gerrit/server/cache/h2/BUILD b/java/com/google/gerrit/server/cache/h2/BUILD index f85b498ce1..79baefc467 100644 --- a/java/com/google/gerrit/server/cache/h2/BUILD +++ b/java/com/google/gerrit/server/cache/h2/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "h2", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gerrit/server/cache/mem/BUILD b/java/com/google/gerrit/server/cache/mem/BUILD index 4106714b3d..eb0695e1b1 100644 --- a/java/com/google/gerrit/server/cache/mem/BUILD +++ b/java/com/google/gerrit/server/cache/mem/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "mem", srcs = glob(["*.java"]), diff --git a/java/com/google/gerrit/server/cache/serialize/BUILD b/java/com/google/gerrit/server/cache/serialize/BUILD index 9600074920..76dcbb1c28 100644 --- a/java/com/google/gerrit/server/cache/serialize/BUILD +++ b/java/com/google/gerrit/server/cache/serialize/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "serialize", srcs = glob(["*.java"]), diff --git a/java/com/google/gerrit/server/cache/testing/BUILD b/java/com/google/gerrit/server/cache/testing/BUILD index 16cbe17ff7..09f698c125 100644 --- a/java/com/google/gerrit/server/cache/testing/BUILD +++ b/java/com/google/gerrit/server/cache/testing/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + package(default_testonly = True) java_library( diff --git a/java/com/google/gerrit/server/git/receive/BUILD b/java/com/google/gerrit/server/git/receive/BUILD index da21fbb245..b1bf933374 100644 --- a/java/com/google/gerrit/server/git/receive/BUILD +++ b/java/com/google/gerrit/server/git/receive/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "receive", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gerrit/server/group/db/testing/BUILD b/java/com/google/gerrit/server/group/db/testing/BUILD index c13abbaf66..b5d5a43f5f 100644 --- a/java/com/google/gerrit/server/group/db/testing/BUILD +++ b/java/com/google/gerrit/server/group/db/testing/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + package(default_visibility = ["//visibility:public"]) java_library( diff --git a/java/com/google/gerrit/server/group/testing/BUILD b/java/com/google/gerrit/server/group/testing/BUILD index 3ef712c87e..9b6d8de925 100644 --- a/java/com/google/gerrit/server/group/testing/BUILD +++ b/java/com/google/gerrit/server/group/testing/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + package(default_visibility = ["//visibility:public"]) java_library( diff --git a/java/com/google/gerrit/server/ioutil/BUILD b/java/com/google/gerrit/server/ioutil/BUILD index ea91929b4b..ed58d5bd40 100644 --- a/java/com/google/gerrit/server/ioutil/BUILD +++ b/java/com/google/gerrit/server/ioutil/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "ioutil", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gerrit/server/logging/BUILD b/java/com/google/gerrit/server/logging/BUILD index cf8e9db58f..f64af3b766 100644 --- a/java/com/google/gerrit/server/logging/BUILD +++ b/java/com/google/gerrit/server/logging/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "logging", srcs = glob( diff --git a/java/com/google/gerrit/server/project/testing/BUILD b/java/com/google/gerrit/server/project/testing/BUILD index f221e00dc9..968e3da744 100644 --- a/java/com/google/gerrit/server/project/testing/BUILD +++ b/java/com/google/gerrit/server/project/testing/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "project-test-util", testonly = True, diff --git a/java/com/google/gerrit/server/restapi/BUILD b/java/com/google/gerrit/server/restapi/BUILD index e083402ded..9e733b251b 100644 --- a/java/com/google/gerrit/server/restapi/BUILD +++ b/java/com/google/gerrit/server/restapi/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + package( default_visibility = ["//visibility:public"], ) diff --git a/java/com/google/gerrit/server/schema/BUILD b/java/com/google/gerrit/server/schema/BUILD index a8020b1100..ee99c67c71 100644 --- a/java/com/google/gerrit/server/schema/BUILD +++ b/java/com/google/gerrit/server/schema/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "schema", srcs = glob( diff --git a/java/com/google/gerrit/server/schema/testing/BUILD b/java/com/google/gerrit/server/schema/testing/BUILD index c520f437b3..d641c47917 100644 --- a/java/com/google/gerrit/server/schema/testing/BUILD +++ b/java/com/google/gerrit/server/schema/testing/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + package(default_visibility = ["//visibility:public"]) java_library( diff --git a/java/com/google/gerrit/server/securestore/testing/BUILD b/java/com/google/gerrit/server/securestore/testing/BUILD index 9b76b9ee79..c2582b9a26 100644 --- a/java/com/google/gerrit/server/securestore/testing/BUILD +++ b/java/com/google/gerrit/server/securestore/testing/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + package(default_testonly = True) java_library( diff --git a/java/com/google/gerrit/server/util/git/BUILD b/java/com/google/gerrit/server/util/git/BUILD index 81ca9cded9..a8ae918829 100644 --- a/java/com/google/gerrit/server/util/git/BUILD +++ b/java/com/google/gerrit/server/util/git/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "git", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gerrit/server/util/time/BUILD b/java/com/google/gerrit/server/util/time/BUILD index 1d1305d266..ea39efe455 100644 --- a/java/com/google/gerrit/server/util/time/BUILD +++ b/java/com/google/gerrit/server/util/time/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "time", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gerrit/sshd/BUILD b/java/com/google/gerrit/sshd/BUILD index 42ef7d5b76..4ef70c7229 100644 --- a/java/com/google/gerrit/sshd/BUILD +++ b/java/com/google/gerrit/sshd/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "sshd", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gerrit/testing/BUILD b/java/com/google/gerrit/testing/BUILD index ec5076e17e..b7b1e5f8e9 100644 --- a/java/com/google/gerrit/testing/BUILD +++ b/java/com/google/gerrit/testing/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "gerrit-test-util", testonly = True, diff --git a/java/com/google/gerrit/truth/BUILD b/java/com/google/gerrit/truth/BUILD index 6f958b12ca..f21e3c9548 100644 --- a/java/com/google/gerrit/truth/BUILD +++ b/java/com/google/gerrit/truth/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "truth", testonly = True, diff --git a/java/com/google/gerrit/util/cli/BUILD b/java/com/google/gerrit/util/cli/BUILD index b9b9bba370..e4f2c21d86 100644 --- a/java/com/google/gerrit/util/cli/BUILD +++ b/java/com/google/gerrit/util/cli/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "cli", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gerrit/util/http/BUILD b/java/com/google/gerrit/util/http/BUILD index 30d3adc735..5ecb7a1edc 100644 --- a/java/com/google/gerrit/util/http/BUILD +++ b/java/com/google/gerrit/util/http/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "http", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gerrit/util/ssl/BUILD b/java/com/google/gerrit/util/ssl/BUILD index 4f65b61b56..e0641c73c0 100644 --- a/java/com/google/gerrit/util/ssl/BUILD +++ b/java/com/google/gerrit/util/ssl/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "ssl", srcs = glob(["**/*.java"]), diff --git a/java/com/google/gwtorm/BUILD b/java/com/google/gwtorm/BUILD index e9cac34a43..baf7a8cb76 100644 --- a/java/com/google/gwtorm/BUILD +++ b/java/com/google/gwtorm/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "gwtorm", srcs = glob(["**/*.java"]), diff --git a/java/gerrit/BUILD b/java/gerrit/BUILD index f416f11649..d7e23069ba 100644 --- a/java/gerrit/BUILD +++ b/java/gerrit/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "prolog-predicates", srcs = glob(["**/*.java"]), diff --git a/java/org/apache/commons/net/BUILD b/java/org/apache/commons/net/BUILD index 49519334df..c322ecd1dd 100644 --- a/java/org/apache/commons/net/BUILD +++ b/java/org/apache/commons/net/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "net", srcs = glob(["**/*.java"]), diff --git a/javatests/com/google/gerrit/acceptance/api/group/BUILD b/javatests/com/google/gerrit/acceptance/api/group/BUILD index a12342a69f..e311e256dd 100644 --- a/javatests/com/google/gerrit/acceptance/api/group/BUILD +++ b/javatests/com/google/gerrit/acceptance/api/group/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//javatests/com/google/gerrit/acceptance:tests.bzl", "acceptance_tests") acceptance_tests( diff --git a/javatests/com/google/gerrit/acceptance/git/BUILD b/javatests/com/google/gerrit/acceptance/git/BUILD index cabb1ba777..b3e0f5a12e 100644 --- a/javatests/com/google/gerrit/acceptance/git/BUILD +++ b/javatests/com/google/gerrit/acceptance/git/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//javatests/com/google/gerrit/acceptance:tests.bzl", "acceptance_tests") [acceptance_tests( diff --git a/javatests/com/google/gerrit/acceptance/pgm/BUILD b/javatests/com/google/gerrit/acceptance/pgm/BUILD index e0ed78a539..d15c6ceb0d 100644 --- a/javatests/com/google/gerrit/acceptance/pgm/BUILD +++ b/javatests/com/google/gerrit/acceptance/pgm/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//javatests/com/google/gerrit/acceptance:tests.bzl", "acceptance_tests") acceptance_tests( diff --git a/javatests/com/google/gerrit/acceptance/rest/account/BUILD b/javatests/com/google/gerrit/acceptance/rest/account/BUILD index 3b46414b31..66ea6f33c3 100644 --- a/javatests/com/google/gerrit/acceptance/rest/account/BUILD +++ b/javatests/com/google/gerrit/acceptance/rest/account/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//javatests/com/google/gerrit/acceptance:tests.bzl", "acceptance_tests") acceptance_tests( diff --git a/javatests/com/google/gerrit/acceptance/rest/change/BUILD b/javatests/com/google/gerrit/acceptance/rest/change/BUILD index 9a6537895c..7ccf10f717 100644 --- a/javatests/com/google/gerrit/acceptance/rest/change/BUILD +++ b/javatests/com/google/gerrit/acceptance/rest/change/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//javatests/com/google/gerrit/acceptance:tests.bzl", "acceptance_tests") SUBMIT_UTIL_SRCS = glob(["AbstractSubmit*.java"]) diff --git a/javatests/com/google/gerrit/acceptance/rest/project/BUILD b/javatests/com/google/gerrit/acceptance/rest/project/BUILD index 131c24a20d..200b26a0a0 100644 --- a/javatests/com/google/gerrit/acceptance/rest/project/BUILD +++ b/javatests/com/google/gerrit/acceptance/rest/project/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//javatests/com/google/gerrit/acceptance:tests.bzl", "acceptance_tests") acceptance_tests( diff --git a/javatests/com/google/gerrit/acceptance/rest/util/BUILD b/javatests/com/google/gerrit/acceptance/rest/util/BUILD index cc72e8ac6b..1d3fe65015 100644 --- a/javatests/com/google/gerrit/acceptance/rest/util/BUILD +++ b/javatests/com/google/gerrit/acceptance/rest/util/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "util", testonly = True, diff --git a/javatests/com/google/gerrit/acceptance/server/mail/BUILD b/javatests/com/google/gerrit/acceptance/server/mail/BUILD index e21789b966..5d7e65e10c 100644 --- a/javatests/com/google/gerrit/acceptance/server/mail/BUILD +++ b/javatests/com/google/gerrit/acceptance/server/mail/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//javatests/com/google/gerrit/acceptance:tests.bzl", "acceptance_tests") DEPS = [ diff --git a/javatests/com/google/gerrit/acceptance/ssh/BUILD b/javatests/com/google/gerrit/acceptance/ssh/BUILD index 00a0914af6..56343228bc 100644 --- a/javatests/com/google/gerrit/acceptance/ssh/BUILD +++ b/javatests/com/google/gerrit/acceptance/ssh/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//javatests/com/google/gerrit/acceptance:tests.bzl", "acceptance_tests") java_library( diff --git a/javatests/com/google/gerrit/elasticsearch/BUILD b/javatests/com/google/gerrit/elasticsearch/BUILD index a2bd092c8f..e50f2b5451 100644 --- a/javatests/com/google/gerrit/elasticsearch/BUILD +++ b/javatests/com/google/gerrit/elasticsearch/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//tools/bzl:junit.bzl", "junit_tests") java_library( diff --git a/javatests/com/google/gerrit/server/BUILD b/javatests/com/google/gerrit/server/BUILD index a19a48b122..2fcc8420c5 100644 --- a/javatests/com/google/gerrit/server/BUILD +++ b/javatests/com/google/gerrit/server/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//tools/bzl:junit.bzl", "junit_tests") CUSTOM_TRUTH_SUBJECTS = glob([ diff --git a/javatests/com/google/gerrit/server/query/account/BUILD b/javatests/com/google/gerrit/server/query/account/BUILD index e41d390315..7b72f4e268 100644 --- a/javatests/com/google/gerrit/server/query/account/BUILD +++ b/javatests/com/google/gerrit/server/query/account/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//tools/bzl:junit.bzl", "junit_tests") ABSTRACT_QUERY_TEST = ["AbstractQueryAccountsTest.java"] diff --git a/javatests/com/google/gerrit/server/query/change/BUILD b/javatests/com/google/gerrit/server/query/change/BUILD index e8a63b8773..4a3f508cdc 100644 --- a/javatests/com/google/gerrit/server/query/change/BUILD +++ b/javatests/com/google/gerrit/server/query/change/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//tools/bzl:junit.bzl", "junit_tests") ABSTRACT_QUERY_TEST = ["AbstractQueryChangesTest.java"] diff --git a/javatests/com/google/gerrit/server/query/group/BUILD b/javatests/com/google/gerrit/server/query/group/BUILD index 3f147c929b..1271f4e1ed 100644 --- a/javatests/com/google/gerrit/server/query/group/BUILD +++ b/javatests/com/google/gerrit/server/query/group/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//tools/bzl:junit.bzl", "junit_tests") ABSTRACT_QUERY_TEST = ["AbstractQueryGroupsTest.java"] diff --git a/javatests/com/google/gerrit/server/query/project/BUILD b/javatests/com/google/gerrit/server/query/project/BUILD index 4ce1c00b4b..e978be6114 100644 --- a/javatests/com/google/gerrit/server/query/project/BUILD +++ b/javatests/com/google/gerrit/server/query/project/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//tools/bzl:junit.bzl", "junit_tests") ABSTRACT_QUERY_TEST = ["AbstractQueryProjectsTest.java"] diff --git a/javatests/com/google/gerrit/util/http/testutil/BUILD b/javatests/com/google/gerrit/util/http/testutil/BUILD index adae68e375..5cb94c6d60 100644 --- a/javatests/com/google/gerrit/util/http/testutil/BUILD +++ b/javatests/com/google/gerrit/util/http/testutil/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "testutil", testonly = True, diff --git a/lib/BUILD b/lib/BUILD index f98f6fe7b5..ab2bad92c8 100644 --- a/lib/BUILD +++ b/lib/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + exports_files(glob([ "LICENSE-*", ])) diff --git a/lib/antlr/BUILD b/lib/antlr/BUILD index c35c2b5943..076aea9ab0 100644 --- a/lib/antlr/BUILD +++ b/lib/antlr/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_binary", "java_library") + package(default_visibility = ["//java/com/google/gerrit/index:__pkg__"]) [java_library( diff --git a/lib/asciidoctor/BUILD b/lib/asciidoctor/BUILD index 62b1114219..b46c08d9aa 100644 --- a/lib/asciidoctor/BUILD +++ b/lib/asciidoctor/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "asciidoctor", data = ["//lib:LICENSE-asciidoctor"], diff --git a/lib/auto/BUILD b/lib/auto/BUILD index 1e722bcae5..b60a10199e 100644 --- a/lib/auto/BUILD +++ b/lib/auto/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library", "java_plugin") + java_plugin( name = "auto-annotation-plugin", processor_class = "com.google.auto.value.processor.AutoAnnotationProcessor", diff --git a/lib/bouncycastle/BUILD b/lib/bouncycastle/BUILD index cf3e996263..43ba6e1cec 100644 --- a/lib/bouncycastle/BUILD +++ b/lib/bouncycastle/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "bcprov", data = ["//lib:LICENSE-bouncycastle"], diff --git a/lib/commons/BUILD b/lib/commons/BUILD index e8de396541..38b1b6de84 100644 --- a/lib/commons/BUILD +++ b/lib/commons/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + package(default_visibility = ["//visibility:public"]) java_library( diff --git a/lib/dropwizard/BUILD b/lib/dropwizard/BUILD index 4ae12f14c5..174b7ad12d 100644 --- a/lib/dropwizard/BUILD +++ b/lib/dropwizard/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "dropwizard-core", data = ["//lib:LICENSE-Apache2.0"], diff --git a/lib/easymock/BUILD b/lib/easymock/BUILD index 352d2a778c..90c9673d31 100644 --- a/lib/easymock/BUILD +++ b/lib/easymock/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "easymock", data = ["//lib:LICENSE-DO_NOT_DISTRIBUTE"], diff --git a/lib/elasticsearch-rest-client/BUILD b/lib/elasticsearch-rest-client/BUILD index 8df3c704ef..e323263beb 100644 --- a/lib/elasticsearch-rest-client/BUILD +++ b/lib/elasticsearch-rest-client/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + package(default_visibility = ["//visibility:public"]) java_library( diff --git a/lib/flogger/BUILD b/lib/flogger/BUILD index c41e12f224..35c3c628f1 100644 --- a/lib/flogger/BUILD +++ b/lib/flogger/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "api", data = ["//lib:LICENSE-Apache2.0"], diff --git a/lib/gitiles/BUILD b/lib/gitiles/BUILD index b1bbca16b9..6e0380170a 100644 --- a/lib/gitiles/BUILD +++ b/lib/gitiles/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "gitiles", visibility = ["//visibility:public"], diff --git a/lib/greenmail/BUILD b/lib/greenmail/BUILD index 9cbd0eb55a..e8845e2628 100644 --- a/lib/greenmail/BUILD +++ b/lib/greenmail/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + package(default_visibility = ["//visibility:public"]) POST_JDK8_DEPS = [":javax-activation"] diff --git a/lib/guice/BUILD b/lib/guice/BUILD index 7f384e2657..f73984b7c8 100644 --- a/lib/guice/BUILD +++ b/lib/guice/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "guice", data = ["//lib:LICENSE-Apache2.0"], diff --git a/lib/httpcomponents/BUILD b/lib/httpcomponents/BUILD index 03d9b68e2b..07d4bb9683 100644 --- a/lib/httpcomponents/BUILD +++ b/lib/httpcomponents/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + package(default_visibility = ["//visibility:public"]) java_library( diff --git a/lib/jackson/BUILD b/lib/jackson/BUILD index 0034748d28..3eed77ad6e 100644 --- a/lib/jackson/BUILD +++ b/lib/jackson/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "jackson-core", data = ["//lib:LICENSE-Apache2.0"], diff --git a/lib/jetty/BUILD b/lib/jetty/BUILD index b78ac58806..641738597d 100644 --- a/lib/jetty/BUILD +++ b/lib/jetty/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "servlet", data = ["//lib:LICENSE-Apache2.0"], diff --git a/lib/jgit/org.eclipse.jgit.archive/BUILD b/lib/jgit/org.eclipse.jgit.archive/BUILD index 27426235ef..151cd71b6f 100644 --- a/lib/jgit/org.eclipse.jgit.archive/BUILD +++ b/lib/jgit/org.eclipse.jgit.archive/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//lib/jgit:jgit.bzl", "jgit_dep") java_library( diff --git a/lib/jgit/org.eclipse.jgit.http.server/BUILD b/lib/jgit/org.eclipse.jgit.http.server/BUILD index 001ad8b5c8..fd634a5cc9 100644 --- a/lib/jgit/org.eclipse.jgit.http.server/BUILD +++ b/lib/jgit/org.eclipse.jgit.http.server/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//lib/jgit:jgit.bzl", "jgit_dep") java_library( diff --git a/lib/jgit/org.eclipse.jgit.junit/BUILD b/lib/jgit/org.eclipse.jgit.junit/BUILD index 29d80d35c3..abc522b8a0 100644 --- a/lib/jgit/org.eclipse.jgit.junit/BUILD +++ b/lib/jgit/org.eclipse.jgit.junit/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//lib/jgit:jgit.bzl", "jgit_dep") java_library( diff --git a/lib/jgit/org.eclipse.jgit/BUILD b/lib/jgit/org.eclipse.jgit/BUILD index dc111718ae..c1f260740f 100644 --- a/lib/jgit/org.eclipse.jgit/BUILD +++ b/lib/jgit/org.eclipse.jgit/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//lib/jgit:jgit.bzl", "jgit_dep") java_library( diff --git a/lib/jsoup/BUILD b/lib/jsoup/BUILD index 3142dacb02..71719010b7 100644 --- a/lib/jsoup/BUILD +++ b/lib/jsoup/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "jsoup", data = ["//lib:LICENSE-jsoup"], diff --git a/lib/log/BUILD b/lib/log/BUILD index 8e4c9271d2..128e8ba15e 100644 --- a/lib/log/BUILD +++ b/lib/log/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "api", data = ["//lib:LICENSE-slf4j"], diff --git a/lib/lucene/BUILD b/lib/lucene/BUILD index adb5030c2c..b8b2457fcc 100644 --- a/lib/lucene/BUILD +++ b/lib/lucene/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//tools/bzl:maven.bzl", "merge_maven_jars") package(default_visibility = ["//visibility:public"]) diff --git a/lib/mail/BUILD b/lib/mail/BUILD index eca2b6b7f9..489f54498f 100644 --- a/lib/mail/BUILD +++ b/lib/mail/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "mail", data = ["//lib:LICENSE-DO_NOT_DISTRIBUTE"], diff --git a/lib/mime4j/BUILD b/lib/mime4j/BUILD index ee407c37cc..577661dedb 100644 --- a/lib/mime4j/BUILD +++ b/lib/mime4j/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "core", data = ["//lib:LICENSE-Apache2.0"], diff --git a/lib/mina/BUILD b/lib/mina/BUILD index 6ee7e41657..5ad47cd3f1 100644 --- a/lib/mina/BUILD +++ b/lib/mina/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "sshd", data = ["//lib:LICENSE-Apache2.0"], diff --git a/lib/mockito/BUILD b/lib/mockito/BUILD index df7537b7f0..cfec8a0ded 100644 --- a/lib/mockito/BUILD +++ b/lib/mockito/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + package( default_testonly = True, default_visibility = ["//visibility:private"], diff --git a/lib/openid/BUILD b/lib/openid/BUILD index faa073b6bc..c27e8ab359 100644 --- a/lib/openid/BUILD +++ b/lib/openid/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "consumer", data = ["//lib:LICENSE-Apache2.0"], diff --git a/lib/ow2/BUILD b/lib/ow2/BUILD index 5a82572830..7fe7e2d7c0 100644 --- a/lib/ow2/BUILD +++ b/lib/ow2/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "ow2-asm", data = ["//lib:LICENSE-ow2"], diff --git a/lib/powermock/BUILD b/lib/powermock/BUILD index 57880f4e32..39df164aa8 100644 --- a/lib/powermock/BUILD +++ b/lib/powermock/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "powermock-module-junit4", data = ["//lib:LICENSE-DO_NOT_DISTRIBUTE"], diff --git a/lib/prolog/BUILD b/lib/prolog/BUILD index 8518af7010..6ae443469c 100644 --- a/lib/prolog/BUILD +++ b/lib/prolog/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_binary", "java_library") + java_library( name = "runtime", data = ["//lib:LICENSE-prologcafe"], diff --git a/lib/prolog/prolog.bzl b/lib/prolog/prolog.bzl index 4d4dd3a394..ffc3198228 100644 --- a/lib/prolog/prolog.bzl +++ b/lib/prolog/prolog.bzl @@ -12,6 +12,8 @@ # See the License for the specific language governing permissions and # limitations under the License. +load("@rules_java//java:defs.bzl", "java_library") + def prolog_cafe_library( name, srcs, @@ -26,7 +28,7 @@ def prolog_cafe_library( tools = ["//lib/prolog:compiler-bin"], outs = [name + ".srcjar"], ) - native.java_library( + java_library( name = name, srcs = [":" + name + "__pl2j"], deps = ["//lib/prolog:runtime-neverlink"] + deps, diff --git a/lib/testcontainers/BUILD b/lib/testcontainers/BUILD index 25ca327565..a37b733f25 100644 --- a/lib/testcontainers/BUILD +++ b/lib/testcontainers/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "duct-tape", testonly = True, diff --git a/lib/truth/BUILD b/lib/truth/BUILD index db5bc489ef..bb30945529 100644 --- a/lib/truth/BUILD +++ b/lib/truth/BUILD @@ -1,3 +1,5 @@ +load("@rules_java//java:defs.bzl", "java_library") + java_library( name = "truth", data = ["//lib:LICENSE-DO_NOT_DISTRIBUTE"], diff --git a/plugins/BUILD b/plugins/BUILD index 7d81213c6d..3e937687dd 100644 --- a/plugins/BUILD +++ b/plugins/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_binary", "java_library") load("//tools/bzl:genrule2.bzl", "genrule2") load("//tools/bzl:javadoc.bzl", "java_doc") load( diff --git a/plugins/replication b/plugins/replication index 86bf0a7166..6698a9e087 160000 --- a/plugins/replication +++ b/plugins/replication @@ -1 +1 @@ -Subproject commit 86bf0a716608deba7b374cfa1fbdb10c8eb2f4fa +Subproject commit 6698a9e0878519c3a01d9f891e53f8411e6f1d98 diff --git a/proto/BUILD b/proto/BUILD index cef28a1172..57be2658eb 100644 --- a/proto/BUILD +++ b/proto/BUILD @@ -1,3 +1,6 @@ +load("@rules_java//java:defs.bzl", "java_proto_library") +load("@rules_proto//proto:defs.bzl", "proto_library") + proto_library( name = "cache_proto", srcs = ["cache.proto"], diff --git a/proto/testing/BUILD b/proto/testing/BUILD index b9032cf552..3701394bbe 100644 --- a/proto/testing/BUILD +++ b/proto/testing/BUILD @@ -1,3 +1,6 @@ +load("@rules_proto//proto:defs.bzl", "proto_library") +load("@rules_java//java:defs.bzl", "java_proto_library") + proto_library( name = "test_proto", testonly = 1, diff --git a/resources/BUILD b/resources/BUILD index 18d8df6492..b53ae4c691 100644 --- a/resources/BUILD +++ b/resources/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_import") load("//tools/bzl:genrule2.bzl", "genrule2") java_import( diff --git a/tools/BUILD b/tools/BUILD index f51ee76e8a..5f4e4415d2 100644 --- a/tools/BUILD +++ b/tools/BUILD @@ -1,3 +1,5 @@ +load("@rules_python//python:defs.bzl", "py_binary") +load("@rules_java//java:defs.bzl", "java_package_configuration") load( "@bazel_tools//tools/jdk:default_java_toolchain.bzl", "JDK9_JVM_OPTS", diff --git a/tools/bzl/java.bzl b/tools/bzl/java.bzl index 7c41fbed52..8996b69360 100644 --- a/tools/bzl/java.bzl +++ b/tools/bzl/java.bzl @@ -15,11 +15,13 @@ # Syntactic sugar for native java_library() rule: # accept exported_deps attributes +load("@rules_java//java:defs.bzl", "java_library") + def java_library2(deps = [], exported_deps = [], exports = [], **kwargs): if exported_deps: deps = deps + exported_deps exports = exports + exported_deps - native.java_library( + java_library( deps = deps, exports = exports, **kwargs diff --git a/tools/bzl/junit.bzl b/tools/bzl/junit.bzl index 1a3099728d..613efb1846 100644 --- a/tools/bzl/junit.bzl +++ b/tools/bzl/junit.bzl @@ -18,6 +18,8 @@ # See https://github.com/bazelbuild/bazel/issues/1017 for background. +load("@rules_java//java:defs.bzl", "java_test") + _OUTPUT = """import org.junit.runners.Suite; import org.junit.runner.RunWith; @@ -84,7 +86,7 @@ def junit_tests(name, srcs, **kwargs): "//:java_next": POST_JDK8_OPTS, "//conditions:default": [], }) - native.java_test( + java_test( name = name, test_class = s_name, srcs = srcs + [":" + s_name], diff --git a/tools/bzl/maven.bzl b/tools/bzl/maven.bzl index 71aa91c3e8..36e3084e78 100644 --- a/tools/bzl/maven.bzl +++ b/tools/bzl/maven.bzl @@ -14,6 +14,8 @@ # Merge maven files +load("@rules_java//java:defs.bzl", "java_import") + def cmd(jars): return ("$(location //tools:merge_jars) $@ " + " ".join(["$(location %s)" % j for j in jars])) @@ -25,7 +27,7 @@ def merge_maven_jars(name, srcs, **kwargs): tools = srcs + ["//tools:merge_jars"], outs = ["%s__merged.jar" % name], ) - native.java_import( + java_import( name = name, jars = [":%s__merged_bin" % name], **kwargs diff --git a/tools/bzl/plugin.bzl b/tools/bzl/plugin.bzl index 066fe43e67..ed64d1b775 100644 --- a/tools/bzl/plugin.bzl +++ b/tools/bzl/plugin.bzl @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_binary", "java_library") load("//tools/bzl:genrule2.bzl", "genrule2") PLUGIN_DEPS = ["//plugins:plugin-lib"] @@ -21,7 +22,7 @@ def gerrit_plugin( dir_name = None, target_suffix = "", **kwargs): - native.java_library( + java_library( name = name + "__plugin", srcs = srcs, resources = resources, @@ -35,7 +36,7 @@ def gerrit_plugin( if not dir_name: dir_name = name - native.java_binary( + java_binary( name = "%s__non_stamped" % name, deploy_manifest_lines = manifest_entries + ["Gerrit-ApiType: plugin"], main_class = "Dummy", diff --git a/tools/eclipse/BUILD b/tools/eclipse/BUILD index 814a56f663..e091fc15ac 100644 --- a/tools/eclipse/BUILD +++ b/tools/eclipse/BUILD @@ -1,3 +1,4 @@ +load("@rules_java//java:defs.bzl", "java_library") load("//tools/bzl:classpath.bzl", "classpath_collector") load("//tools/bzl:pkg_war.bzl", "LIBS", "PGMLIBS") load(