opendev/gerrit
Code Issues Proposed changes

In AbstractChangeUpdate, restrict access levels and add @Nullable annotation

Browse Source 
Change-Id: I5b242c49eb22780fb73d977d013245c2a402a790
This commit is contained in:
Joerg Zieren 2019-11-21 18:14:08 +01:00
parent 98e0ed4543
commit 72e855c2bf
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
java/com/google/gerrit/server/notedb/AbstractChangeUpdate.java
View File

@ -51,11 +51,11 @@ public abstract class AbstractChangeUpdate {
private final Change change;
protected final PersonIdent serverIdent;
protected PatchSet.Id psId;
@Nullable protected PatchSet.Id psId;
private ObjectId result;
protected boolean rootOnly;
boolean rootOnly;
protected AbstractChangeUpdate(
AbstractChangeUpdate(
ChangeNotes notes,
CurrentUser user,
PersonIdent serverIdent,
@ -72,7 +72,7 @@ public abstract class AbstractChangeUpdate {
this.when = when;
}
protected AbstractChangeUpdate(
AbstractChangeUpdate(
ChangeNoteUtil noteUtil,
PersonIdent serverIdent,
@Nullable ChangeNotes notes,
@ -172,7 +172,7 @@ public abstract class AbstractChangeUpdate {
public abstract boolean isEmpty();
/** Wether this update can only be a root commit. */
public boolean isRootOnly() {
boolean isRootOnly() {
return rootOnly;
}
@ -256,7 +256,7 @@ public abstract class AbstractChangeUpdate {
protected abstract CommitBuilder applyImpl(RevWalk rw, ObjectInserter ins, ObjectId curr)
throws IOException;
protected static final CommitBuilder NO_OP_UPDATE = new CommitBuilder();
static final CommitBuilder NO_OP_UPDATE = new CommitBuilder();
ObjectId getResult() {
return result;
@ -270,7 +270,7 @@ public abstract class AbstractChangeUpdate {
return ins.insert(Constants.OBJ_TREE, new byte[] {});
}
protected void verifyComment(Comment c) {
void verifyComment(Comment c) {
checkArgument(c.getCommitId() != null, "commit ID required for comment: %s", c);
checkArgument(
c.author.getId().equals(getAccountId()),