From 738eb640cdbfd7631bd5aa7f5349fcceb26fb2bc Mon Sep 17 00:00:00 2001 From: Logan Hanks Date: Mon, 2 Oct 2017 05:43:48 -0700 Subject: [PATCH] Only display assignee in change list if assigned Without this fix, unassigned changes will have an empty grey circle in the assignee column. Change-Id: I11d54da5ed60145cf722ddf031d2254eaa0b91e1 (cherry picked from commit 0f108b0890ede4363253fad5f2768c2c0370428b) --- .../gr-change-list-item/gr-change-list-item.html | 4 +++- .../gr-change-list-item/gr-change-list-item_test.html | 11 +++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.html b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.html index 83a4362d86..a2c785337f 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.html +++ b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.html @@ -139,7 +139,9 @@ limitations under the License. - + diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.html b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.html index cd07b5aab5..243a8ab083 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.html +++ b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.html @@ -186,5 +186,16 @@ limitations under the License. const elementClass = '.bad'; assert.isNotOk(element.$$(elementClass)); }); + + test('assignee only displayed if there is one', () => { + assert.isNotOk(element.$$('.assignee gr-account-link')); + element.change = { + assignee: { + name: 'test', + }, + }; + flushAsynchronousOperations(); + assert.isOk(element.$$('.assignee gr-account-link')); + }); });