opendev/gerrit
Code Issues Proposed changes

Close the "Keyboard Shortcuts" popup on press

Browse Source 
Close the "Keyboard Shortcuts" popup on Escape press instead
of release. The previous commit (052cbef) did this on press,
but for consistency with other popup key actions it should be
done on press.

Bug: Issue 1996
Change-Id: I50031016ee5017c1a9eff5ace0e59cc527d1d418
This commit is contained in:
Johan Dahlin
2013-07-09 09:52:18 -03:00
parent cc3ca421aa
commit 74447c0995
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gerrit-gwtexpui/src/main/java/com/google/gwtexpui/globalkey/client/KeyHelpPopup.java
View File

@@ -19,8 +19,8 @@ import com.google.gwt.event.dom.client.ClickHandler;
import com.google.gwt.event.dom.client.KeyCodes; import com.google.gwt.event.dom.client.KeyCodes;
import com.google.gwt.event.dom.client.KeyPressEvent; import com.google.gwt.event.dom.client.KeyPressEvent;
import com.google.gwt.event.dom.client.KeyPressHandler; import com.google.gwt.event.dom.client.KeyPressHandler;
import com.google.gwt.event.dom.client.KeyUpEvent; import com.google.gwt.event.dom.client.KeyDownEvent;
import com.google.gwt.event.dom.client.KeyUpHandler; import com.google.gwt.event.dom.client.KeyDownHandler;
import com.google.gwt.user.client.DOM; import com.google.gwt.user.client.DOM;
import com.google.gwt.user.client.ui.Anchor; import com.google.gwt.user.client.ui.Anchor;
import com.google.gwt.user.client.ui.FlowPanel; import com.google.gwt.user.client.ui.FlowPanel;
@@ -41,7 +41,7 @@ import java.util.List;
public class KeyHelpPopup extends PluginSafePopupPanel implements public class KeyHelpPopup extends PluginSafePopupPanel implements
KeyPressHandler, KeyUpHandler { KeyPressHandler, KeyDownHandler {
private final FocusPanel focus; private final FocusPanel focus;
public KeyHelpPopup() { public KeyHelpPopup() {
@@ -80,7 +80,7 @@ public class KeyHelpPopup extends PluginSafePopupPanel implements
DOM.setStyleAttribute(focus.getElement(), "outline", "0px"); DOM.setStyleAttribute(focus.getElement(), "outline", "0px");
DOM.setElementAttribute(focus.getElement(), "hideFocus", "true"); DOM.setElementAttribute(focus.getElement(), "hideFocus", "true");
focus.addKeyPressHandler(this); focus.addKeyPressHandler(this);
focus.addKeyUpHandler(this); focus.addKeyDownHandler(this);
add(focus); add(focus);
} }
@@ -105,7 +105,7 @@ public class KeyHelpPopup extends PluginSafePopupPanel implements
} }
@Override @Override
public void onKeyUp(final KeyUpEvent event) { public void onKeyDown(final KeyDownEvent event) {
if (event.getNativeKeyCode() == KeyCodes.KEY_ESCAPE) { if (event.getNativeKeyCode() == KeyCodes.KEY_ESCAPE) {
hide(); hide();
} }