opendev/gerrit
Code Issues Proposed changes

Merge "Replace dispatchEvent with dispatchEventThroughTarget"

Browse Source
This commit is contained in:
Dhruv Srivastava
2020-10-12 17:13:36 +00:00
committed by Gerrit Code Review
parent 70470c7deb 98fc1774da
commit 744b30bafc
2 changed files with 14 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
polygerrit-ui/app/elements/shared/gr-hovercard-account/gr-hovercard-account.ts
View File

@@ -145,16 +145,12 @@ export class GrHovercardAccount extends GestureEventListeners(
_handleClickAddToAttentionSet() { _handleClickAddToAttentionSet() {
if (!this.change || !this.account._account_id) return; if (!this.change || !this.account._account_id) return;
this.dispatchEvent( this.dispatchEventThroughTarget('show-alert', {
new CustomEvent('show-alert', {
detail: { detail: {
message: 'Saving attention set update ...', message: 'Saving attention set update ...',
dismissOnNavigation: true, dismissOnNavigation: true,
}, },
composed: true, });
bubbles: true,
})
);
// We are deliberately updating the UI before making the API call. It is a // We are deliberately updating the UI before making the API call. It is a
// risk that we are taking to achieve a better UX for 99.9% of the cases. // risk that we are taking to achieve a better UX for 99.9% of the cases.
@@ -181,16 +177,12 @@ export class GrHovercardAccount extends GestureEventListeners(
_handleClickRemoveFromAttentionSet() { _handleClickRemoveFromAttentionSet() {
if (!this.change || !this.account._account_id) return; if (!this.change || !this.account._account_id) return;
this.dispatchEvent( this.dispatchEventThroughTarget('show-alert', {
new CustomEvent('show-alert', {
detail: { detail: {
message: 'Saving attention set update ...', message: 'Saving attention set update ...',
dismissOnNavigation: true, dismissOnNavigation: true,
}, },
composed: true, });
bubbles: true,
})
);
// We are deliberately updating the UI before making the API call. It is a // We are deliberately updating the UI before making the API call. It is a
// risk that we are taking to achieve a better UX for 99.9% of the cases. // risk that we are taking to achieve a better UX for 99.9% of the cases.

4
polygerrit-ui/app/elements/shared/gr-hovercard-account/gr-hovercard-account_test.js
View File

@@ -115,7 +115,7 @@ suite('gr-hovercard-account tests', () => {
const showAlertListener = sinon.spy(); const showAlertListener = sinon.spy();
const hideAlertListener = sinon.spy(); const hideAlertListener = sinon.spy();
const updatedListener = sinon.spy(); const updatedListener = sinon.spy();
element.addEventListener('show-alert', showAlertListener); element._target.addEventListener('show-alert', showAlertListener);
element._target.addEventListener('hide-alert', hideAlertListener); element._target.addEventListener('hide-alert', hideAlertListener);
element._target.addEventListener('attention-set-updated', updatedListener); element._target.addEventListener('attention-set-updated', updatedListener);
@@ -149,7 +149,7 @@ suite('gr-hovercard-account tests', () => {
const showAlertListener = sinon.spy(); const showAlertListener = sinon.spy();
const hideAlertListener = sinon.spy(); const hideAlertListener = sinon.spy();
const updatedListener = sinon.spy(); const updatedListener = sinon.spy();
element.addEventListener('show-alert', showAlertListener); element._target.addEventListener('show-alert', showAlertListener);
element._target.addEventListener('hide-alert', hideAlertListener); element._target.addEventListener('hide-alert', hideAlertListener);
element._target.addEventListener('attention-set-updated', updatedListener); element._target.addEventListener('attention-set-updated', updatedListener);